* [PATCH] dma: ipu: ipu_idmac: Fix section mismatch
@ 2013-03-12 23:53 Fabio Estevam
2013-03-14 0:39 ` Maxin B. John
2013-03-21 8:24 ` Vinod Koul
0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2013-03-12 23:53 UTC (permalink / raw)
To: vinod.koul; +Cc: maxin.john, s.hauer, linux-kernel, Fabio Estevam
From: Fabio Estevam <fabio.estevam@freescale.com>
Since commit 84c1e63c12 (dma: Remove erroneous __exit and __exit_p() references)
the following section mismatch happens:
WARNING: drivers/built-in.o(.text+0x20f94): Section mismatch in reference from the function ipu_remove() to the function .exit.text:ipu_idmac_exit()
The function ipu_remove() references a function in an exit section.
Often the function ipu_idmac_exit() has valid usage outside the exit section
and the fix is to remove the __exit annotation of ipu_idmac_exit.
Remove the '__exit' annotation from ipu_idmac_exit in order to fix it.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
drivers/dma/ipu/ipu_idmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
index d6d5d7e..d39c2cd 100644
--- a/drivers/dma/ipu/ipu_idmac.c
+++ b/drivers/dma/ipu/ipu_idmac.c
@@ -1642,7 +1642,7 @@ static int __init ipu_idmac_init(struct ipu *ipu)
return dma_async_device_register(&idmac->dma);
}
-static void __exit ipu_idmac_exit(struct ipu *ipu)
+static void ipu_idmac_exit(struct ipu *ipu)
{
int i;
struct idmac *idmac = &ipu->idmac;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dma: ipu: ipu_idmac: Fix section mismatch
2013-03-12 23:53 [PATCH] dma: ipu: ipu_idmac: Fix section mismatch Fabio Estevam
@ 2013-03-14 0:39 ` Maxin B. John
2013-03-20 5:17 ` Fabio Estevam
2013-03-21 8:24 ` Vinod Koul
1 sibling, 1 reply; 4+ messages in thread
From: Maxin B. John @ 2013-03-14 0:39 UTC (permalink / raw)
To: Fabio Estevam
Cc: vinod.koul, maxin.john, s.hauer, linux-kernel, Fabio Estevam
On Wed, Mar 13, 2013 at 1:53 AM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Since commit 84c1e63c12 (dma: Remove erroneous __exit and __exit_p() references)
> the following section mismatch happens:
>
> WARNING: drivers/built-in.o(.text+0x20f94): Section mismatch in reference from the function ipu_remove() to the function .exit.text:ipu_idmac_exit()
> The function ipu_remove() references a function in an exit section.
> Often the function ipu_idmac_exit() has valid usage outside the exit section
> and the fix is to remove the __exit annotation of ipu_idmac_exit.
>
> Remove the '__exit' annotation from ipu_idmac_exit in order to fix it.
Good catch...
Acked-by: Maxin B. John <maxin.john@enea.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> drivers/dma/ipu/ipu_idmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
> index d6d5d7e..d39c2cd 100644
> --- a/drivers/dma/ipu/ipu_idmac.c
> +++ b/drivers/dma/ipu/ipu_idmac.c
> @@ -1642,7 +1642,7 @@ static int __init ipu_idmac_init(struct ipu *ipu)
> return dma_async_device_register(&idmac->dma);
> }
>
> -static void __exit ipu_idmac_exit(struct ipu *ipu)
> +static void ipu_idmac_exit(struct ipu *ipu)
> {
> int i;
> struct idmac *idmac = &ipu->idmac;
> --
> 1.7.9.5
>
> --
Warm Regards,
Maxin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dma: ipu: ipu_idmac: Fix section mismatch
2013-03-14 0:39 ` Maxin B. John
@ 2013-03-20 5:17 ` Fabio Estevam
0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2013-03-20 5:17 UTC (permalink / raw)
To: Maxin B. John
Cc: vinod.koul, maxin.john, s.hauer, linux-kernel, Fabio Estevam
Hi Vinod,
On Wed, Mar 13, 2013 at 9:39 PM, Maxin B. John <maxin.john@gmail.com> wrote:
> On Wed, Mar 13, 2013 at 1:53 AM, Fabio Estevam <festevam@gmail.com> wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Since commit 84c1e63c12 (dma: Remove erroneous __exit and __exit_p() references)
>> the following section mismatch happens:
>>
>> WARNING: drivers/built-in.o(.text+0x20f94): Section mismatch in reference from the function ipu_remove() to the function .exit.text:ipu_idmac_exit()
>> The function ipu_remove() references a function in an exit section.
>> Often the function ipu_idmac_exit() has valid usage outside the exit section
>> and the fix is to remove the __exit annotation of ipu_idmac_exit.
>>
>> Remove the '__exit' annotation from ipu_idmac_exit in order to fix it.
>
> Good catch...
> Acked-by: Maxin B. John <maxin.john@enea.com>
Can this one be applied?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dma: ipu: ipu_idmac: Fix section mismatch
2013-03-12 23:53 [PATCH] dma: ipu: ipu_idmac: Fix section mismatch Fabio Estevam
2013-03-14 0:39 ` Maxin B. John
@ 2013-03-21 8:24 ` Vinod Koul
1 sibling, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2013-03-21 8:24 UTC (permalink / raw)
To: Fabio Estevam; +Cc: maxin.john, s.hauer, linux-kernel, Fabio Estevam
On Tue, Mar 12, 2013 at 08:53:37PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Since commit 84c1e63c12 (dma: Remove erroneous __exit and __exit_p() references)
> the following section mismatch happens:
>
> WARNING: drivers/built-in.o(.text+0x20f94): Section mismatch in reference from the function ipu_remove() to the function .exit.text:ipu_idmac_exit()
> The function ipu_remove() references a function in an exit section.
> Often the function ipu_idmac_exit() has valid usage outside the exit section
> and the fix is to remove the __exit annotation of ipu_idmac_exit.
>
> Remove the '__exit' annotation from ipu_idmac_exit in order to fix it.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied Thanks
--
~Vinod
> ---
> drivers/dma/ipu/ipu_idmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
> index d6d5d7e..d39c2cd 100644
> --- a/drivers/dma/ipu/ipu_idmac.c
> +++ b/drivers/dma/ipu/ipu_idmac.c
> @@ -1642,7 +1642,7 @@ static int __init ipu_idmac_init(struct ipu *ipu)
> return dma_async_device_register(&idmac->dma);
> }
>
> -static void __exit ipu_idmac_exit(struct ipu *ipu)
> +static void ipu_idmac_exit(struct ipu *ipu)
> {
> int i;
> struct idmac *idmac = &ipu->idmac;
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-21 8:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-12 23:53 [PATCH] dma: ipu: ipu_idmac: Fix section mismatch Fabio Estevam
2013-03-14 0:39 ` Maxin B. John
2013-03-20 5:17 ` Fabio Estevam
2013-03-21 8:24 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).