From: Michal Hocko <mhocko@suse.cz>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>, Hugh Dickins <hughd@google.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Andi Kleen <andi@firstfloor.org>, Hillf Danton <dhillf@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()
Date: Wed, 27 Mar 2013 14:52:50 +0100 [thread overview]
Message-ID: <20130327135250.GI16579@dhcp22.suse.cz> (raw)
In-Reply-To: <87boa69z6j.fsf@linux.vnet.ibm.com>
On Tue 26-03-13 16:59:40, Aneesh Kumar K.V wrote:
> Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> writes:
[...]
> > diff --git v3.9-rc3.orig/mm/memory-failure.c v3.9-rc3/mm/memory-failure.c
> > index df0694c..4e01082 100644
> > --- v3.9-rc3.orig/mm/memory-failure.c
> > +++ v3.9-rc3/mm/memory-failure.c
> > @@ -1467,6 +1467,7 @@ static int soft_offline_huge_page(struct page *page, int flags)
> > int ret;
> > unsigned long pfn = page_to_pfn(page);
> > struct page *hpage = compound_head(page);
> > + LIST_HEAD(pagelist);
> >
> > /*
> > * This double-check of PageHWPoison is to avoid the race with
> > @@ -1482,12 +1483,20 @@ static int soft_offline_huge_page(struct page *page, int flags)
> > unlock_page(hpage);
> >
> > /* Keep page count to indicate a given hugepage is isolated. */
> > - ret = migrate_huge_page(hpage, new_page, MPOL_MF_MOVE_ALL,
> > - MIGRATE_SYNC);
> > - put_page(hpage);
> > + list_move(&hpage->lru, &pagelist);
>
> we use hpage->lru to add the hpage to h->hugepage_activelist. This will
> break a hugetlb cgroup removal isn't it ?
This particular part will not break removal because
hugetlb_cgroup_css_offline loops until hugetlb_cgroup_have_usage is 0.
Little bit offtopic:
Btw. hugetlb migration breaks to charging even before this patchset
AFAICS. The above put_page should remove the last reference and then it
will uncharge it but I do not see anything that would charge a new page.
This is all because regula LRU pages are uncharged when they are
unmapped. But this a different story not related to this series.
[...]
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2013-03-27 13:52 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 20:23 [PATCH v2 0/10] extend hugepage migration Naoya Horiguchi
2013-03-22 20:23 ` [PATCH 01/10] migrate: add migrate_entry_wait_huge() Naoya Horiguchi
2013-03-23 15:55 ` Rik van Riel
2013-03-25 10:13 ` Michal Hocko
2013-03-26 4:25 ` Naoya Horiguchi
2013-04-05 20:33 ` KOSAKI Motohiro
2013-04-08 20:00 ` Naoya Horiguchi
2013-04-05 20:33 ` KOSAKI Motohiro
2013-03-22 20:23 ` [PATCH 02/10] migrate: make core migration code aware of hugepage Naoya Horiguchi
2013-03-25 10:57 ` Michal Hocko
2013-03-26 4:33 ` Naoya Horiguchi
2013-03-26 8:49 ` Michal Hocko
2013-04-05 20:41 ` KOSAKI Motohiro
2013-03-22 20:23 ` [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page() Naoya Horiguchi
2013-03-25 12:31 ` Michal Hocko
2013-03-26 4:34 ` Naoya Horiguchi
2013-03-26 9:49 ` Michal Hocko
2013-03-26 20:35 ` Naoya Horiguchi
2013-03-27 13:00 ` Michal Hocko
2013-04-05 21:11 ` KOSAKI Motohiro
2013-03-26 11:29 ` Aneesh Kumar K.V
2013-03-27 13:52 ` Michal Hocko [this message]
2013-03-27 19:19 ` Naoya Horiguchi
2013-03-28 8:53 ` Michal Hocko
2013-03-29 5:26 ` Aneesh Kumar K.V
2013-03-29 9:36 ` Michal Hocko
2013-04-01 5:13 ` Aneesh Kumar K.V
2013-04-02 9:45 ` Michal Hocko
2013-03-22 20:23 ` [PATCH 04/10] migrate: clean up migrate_huge_page() Naoya Horiguchi
2013-04-05 21:13 ` KOSAKI Motohiro
2013-03-22 20:23 ` [PATCH 05/10] migrate: add hugepage migration code to migrate_pages() Naoya Horiguchi
2013-03-25 13:04 ` Michal Hocko
2013-03-26 5:13 ` Naoya Horiguchi
2013-03-26 8:55 ` Michal Hocko
2013-04-05 21:17 ` KOSAKI Motohiro
2013-04-08 20:21 ` Naoya Horiguchi
2013-03-22 20:23 ` [PATCH 06/10] migrate: add hugepage migration code to move_pages() Naoya Horiguchi
2013-03-25 13:36 ` Michal Hocko
2013-03-26 7:06 ` Naoya Horiguchi
2013-03-26 10:02 ` Michal Hocko
2013-03-26 20:37 ` Naoya Horiguchi
2013-03-22 20:23 ` [PATCH 07/10] mbind: add hugepage migration code to mbind() Naoya Horiguchi
2013-03-25 13:49 ` Michal Hocko
2013-04-05 22:23 ` KOSAKI Motohiro
2013-04-06 7:04 ` Michal Hocko
2013-04-05 22:18 ` KOSAKI Motohiro
2013-04-08 20:25 ` Naoya Horiguchi
2013-03-22 20:23 ` [PATCH 08/10] migrate: remove VM_HUGETLB from vma flag check in vma_migratable() Naoya Horiguchi
2013-03-22 20:23 ` [PATCH 09/10] memory-hotplug: enable memory hotplug to handle hugepage Naoya Horiguchi
2013-03-25 15:09 ` Michal Hocko
2013-03-26 18:23 ` Naoya Horiguchi
2013-03-27 14:19 ` Michal Hocko
2013-03-27 21:29 ` Naoya Horiguchi
2013-03-27 21:58 ` Naoya Horiguchi
2013-03-27 22:55 ` Michal Hocko
2013-03-26 12:01 ` Aneesh Kumar K.V
2013-03-27 19:28 ` Naoya Horiguchi
2013-04-06 0:13 ` KOSAKI Motohiro
2013-04-09 20:07 ` Naoya Horiguchi
2013-04-09 21:27 ` KOSAKI Motohiro
2013-04-09 22:43 ` Naoya Horiguchi
2013-04-10 1:56 ` KOSAKI Motohiro
2013-04-10 2:24 ` Naoya Horiguchi
2013-03-22 20:23 ` [PATCH 10/10] prepare to remove /proc/sys/vm/hugepages_treat_as_movable Naoya Horiguchi
2013-03-25 15:12 ` Michal Hocko
2013-04-06 0:15 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130327135250.GI16579@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=dhillf@gmail.com \
--cc=hughd@google.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).