From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>, Hugh Dickins <hughd@google.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Andi Kleen <andi@firstfloor.org>, Hillf Danton <dhillf@gmail.com>,
linux-kernel@vger.kernel.org, kosaki.motohiro@gmail.com
Subject: Re: [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page()
Date: Fri, 05 Apr 2013 17:11:40 -0400 [thread overview]
Message-ID: <515F3E0C.6080206@gmail.com> (raw)
In-Reply-To: <20130327130018.GH16579@dhcp22.suse.cz>
(3/27/13 9:00 AM), Michal Hocko wrote:
> On Tue 26-03-13 16:35:35, Naoya Horiguchi wrote:
> [...]
>> The differences is that migrate_huge_page() has one hugepage as an argument,
>> and migrate_pages() has a pagelist with multiple hugepages.
>> I already told this before and I'm not sure it's enough to answer the question,
>> so I explain another point about why this patch do like it.
>
> OK, I am blind. It is
> + list_move(&hpage->lru, &pagelist);
> + ret = migrate_pages(&pagelist, new_page, MPOL_MF_MOVE_ALL,
> + MIGRATE_SYNC, MR_MEMORY_FAILURE);
>
> which moves it from active_list and so you have to put it back.
>
>> I think that we must do putback_*pages() for source pages whether migration
>> succeeds or not.
>> But when we call migrate_pages() with a pagelist,
>> the caller can't access to the successfully migrated source pages
>> after migrate_pages() returns, because they are no longer on the pagelist.
>> So putback of the successfully migrated source pages should be done *in*
>> unmap_and_move() and/or unmap_and_move_huge_page().
>
> If the migration succeeds then the page becomes unused and free after
> its last reference drops. So I do not see any reason to put it back to
> active list and free it right afterwards.
> On the other hand unmap_and_move does the same thing (although page
> reference counting is a bit more complicated in that case) so it would
> be good to keep in sync with regular pages case.
Even if pages are isolated from lists, there are several page count increasing
path. So, putback_pages() close a race when page count != 1.
I'm not sure, but I guess follow_hugepage() can make the same race.
next prev parent reply other threads:[~2013-04-05 21:11 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 20:23 [PATCH v2 0/10] extend hugepage migration Naoya Horiguchi
2013-03-22 20:23 ` [PATCH 01/10] migrate: add migrate_entry_wait_huge() Naoya Horiguchi
2013-03-23 15:55 ` Rik van Riel
2013-03-25 10:13 ` Michal Hocko
2013-03-26 4:25 ` Naoya Horiguchi
2013-04-05 20:33 ` KOSAKI Motohiro
2013-04-08 20:00 ` Naoya Horiguchi
2013-04-05 20:33 ` KOSAKI Motohiro
2013-03-22 20:23 ` [PATCH 02/10] migrate: make core migration code aware of hugepage Naoya Horiguchi
2013-03-25 10:57 ` Michal Hocko
2013-03-26 4:33 ` Naoya Horiguchi
2013-03-26 8:49 ` Michal Hocko
2013-04-05 20:41 ` KOSAKI Motohiro
2013-03-22 20:23 ` [PATCH 03/10] soft-offline: use migrate_pages() instead of migrate_huge_page() Naoya Horiguchi
2013-03-25 12:31 ` Michal Hocko
2013-03-26 4:34 ` Naoya Horiguchi
2013-03-26 9:49 ` Michal Hocko
2013-03-26 20:35 ` Naoya Horiguchi
2013-03-27 13:00 ` Michal Hocko
2013-04-05 21:11 ` KOSAKI Motohiro [this message]
2013-03-26 11:29 ` Aneesh Kumar K.V
2013-03-27 13:52 ` Michal Hocko
2013-03-27 19:19 ` Naoya Horiguchi
2013-03-28 8:53 ` Michal Hocko
2013-03-29 5:26 ` Aneesh Kumar K.V
2013-03-29 9:36 ` Michal Hocko
2013-04-01 5:13 ` Aneesh Kumar K.V
2013-04-02 9:45 ` Michal Hocko
2013-03-22 20:23 ` [PATCH 04/10] migrate: clean up migrate_huge_page() Naoya Horiguchi
2013-04-05 21:13 ` KOSAKI Motohiro
2013-03-22 20:23 ` [PATCH 05/10] migrate: add hugepage migration code to migrate_pages() Naoya Horiguchi
2013-03-25 13:04 ` Michal Hocko
2013-03-26 5:13 ` Naoya Horiguchi
2013-03-26 8:55 ` Michal Hocko
2013-04-05 21:17 ` KOSAKI Motohiro
2013-04-08 20:21 ` Naoya Horiguchi
2013-03-22 20:23 ` [PATCH 06/10] migrate: add hugepage migration code to move_pages() Naoya Horiguchi
2013-03-25 13:36 ` Michal Hocko
2013-03-26 7:06 ` Naoya Horiguchi
2013-03-26 10:02 ` Michal Hocko
2013-03-26 20:37 ` Naoya Horiguchi
2013-03-22 20:23 ` [PATCH 07/10] mbind: add hugepage migration code to mbind() Naoya Horiguchi
2013-03-25 13:49 ` Michal Hocko
2013-04-05 22:23 ` KOSAKI Motohiro
2013-04-06 7:04 ` Michal Hocko
2013-04-05 22:18 ` KOSAKI Motohiro
2013-04-08 20:25 ` Naoya Horiguchi
2013-03-22 20:23 ` [PATCH 08/10] migrate: remove VM_HUGETLB from vma flag check in vma_migratable() Naoya Horiguchi
2013-03-22 20:23 ` [PATCH 09/10] memory-hotplug: enable memory hotplug to handle hugepage Naoya Horiguchi
2013-03-25 15:09 ` Michal Hocko
2013-03-26 18:23 ` Naoya Horiguchi
2013-03-27 14:19 ` Michal Hocko
2013-03-27 21:29 ` Naoya Horiguchi
2013-03-27 21:58 ` Naoya Horiguchi
2013-03-27 22:55 ` Michal Hocko
2013-03-26 12:01 ` Aneesh Kumar K.V
2013-03-27 19:28 ` Naoya Horiguchi
2013-04-06 0:13 ` KOSAKI Motohiro
2013-04-09 20:07 ` Naoya Horiguchi
2013-04-09 21:27 ` KOSAKI Motohiro
2013-04-09 22:43 ` Naoya Horiguchi
2013-04-10 1:56 ` KOSAKI Motohiro
2013-04-10 2:24 ` Naoya Horiguchi
2013-03-22 20:23 ` [PATCH 10/10] prepare to remove /proc/sys/vm/hugepages_treat_as_movable Naoya Horiguchi
2013-03-25 15:12 ` Michal Hocko
2013-04-06 0:15 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=515F3E0C.6080206@gmail.com \
--to=kosaki.motohiro@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=dhillf@gmail.com \
--cc=hughd@google.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=mhocko@suse.cz \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).