linux-next: build warnings after merge of the regmap tree

linux-next: build warnings after merge of the regmap tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2380 bytes --]

Hi Mark,

After merging the regmap tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:

In file included from drivers/base/regmap/regmap.c:24:0:
drivers/base/regmap/internal.h: In function 'regcache_get_val_addr':
drivers/base/regmap/internal.h:196:2: warning: return discards 'const' qualifier from pointer target type [enabled by default]
In file included from drivers/base/regmap/regcache.c:20:0:
drivers/base/regmap/internal.h: In function 'regcache_get_val_addr':
drivers/base/regmap/internal.h:196:2: warning: return discards 'const' qualifier from pointer target type [enabled by default]
In file included from drivers/base/regmap/regcache-rbtree.c:19:0:
drivers/base/regmap/internal.h: In function 'regcache_get_val_addr':
drivers/base/regmap/internal.h:196:2: warning: return discards 'const' qualifier from pointer target type [enabled by default]
In file included from drivers/base/regmap/regcache-lzo.c:17:0:
drivers/base/regmap/internal.h: In function 'regcache_get_val_addr':
drivers/base/regmap/internal.h:196:2: warning: return discards 'const' qualifier from pointer target type [enabled by default]
In file included from drivers/base/regmap/regcache-flat.c:17:0:
drivers/base/regmap/internal.h: In function 'regcache_get_val_addr':
drivers/base/regmap/internal.h:196:2: warning: return discards 'const' qualifier from pointer target type [enabled by default]
In file included from drivers/base/regmap/regmap-debugfs.c:19:0:
drivers/base/regmap/internal.h: In function 'regcache_get_val_addr':
drivers/base/regmap/internal.h:196:2: warning: return discards 'const' qualifier from pointer target type [enabled by default]
In file included from drivers/base/regmap/regmap-spi.c:18:0:
drivers/base/regmap/internal.h: In function 'regcache_get_val_addr':
drivers/base/regmap/internal.h:196:2: warning: return discards 'const' qualifier from pointer target type [enabled by default]
In file included from drivers/base/regmap/regmap-irq.c:22:0:
drivers/base/regmap/internal.h: In function 'regcache_get_val_addr':
drivers/base/regmap/internal.h:196:2: warning: return discards 'const' qualifier from pointer target type [enabled by default]

Introduced by commit 45c6a3e449ea ("regmap: cache: Provide a get address
of value operation").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warnings after merge of the regmap tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

On Wed, Mar 27, 2013 at 03:47:37PM +1100, Stephen Rothwell wrote:

> Introduced by commit 45c6a3e449ea ("regmap: cache: Provide a get address
> of value operation").

Don't know when you grabbed the tree but that's not what's there now.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warnings after merge of the regmap tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 840 bytes --]

On Wed, 27 Mar 2013 10:24:57 +0000 Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
>
> On Wed, Mar 27, 2013 at 03:47:37PM +1100, Stephen Rothwell wrote:
> 
> > Introduced by commit 45c6a3e449ea ("regmap: cache: Provide a get address
> > of value operation").
> 
> Don't know when you grabbed the tree but that's not what's there now.

Just before 10:30 am my time (UTC+1100) - so about 11 hours ago.  I just
refetched and the regmap tree
(git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git#for-next)
is still the same as what I fetched this morning (top commit is
b32667515168 "Merge remote-tracking branch 'regmap/topic/range' into
regmap-next").  Probably just the mirroring delays.

Anyway, good to know it is fixed.  Thanks.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warnings after merge of the regmap tree

[Charles Keepax]

On Fri, Jul 17, 2015 at 04:29:55PM +0100, Nariman Poushin wrote:
> On Fri, Jul 17, 2015 at 11:34:50AM +0100, Mark Brown wrote:
> > On Fri, Jul 17, 2015 at 10:44:36AM +0100, Nariman Poushin wrote:
> > 
> > > What is the best course of action here? I am more than happy to help with
> > > whatever is needed but unsure of the etiquette here and also not sure
> > > what I can do.
> > 
> > > Clearly there are some clients that need updating but they were not
> > > present in the regmap tree, so is the correct thing to do to merge
> > > in the mfd and sound-asoc tree and provide a fixup commit?
> > 
> > > Just let me know and I am happy to do whatever is deemed correct.
> > 
> > Please send patches fixing the problems you have introduced.
> 
> I have sent the patches to fix the build errors you found Stephen.
> Just wanted to let you guys know I will be on vacation for 1 week,
> so if there are any issues they might not be addressed until then.
> 
> Thanks
> Nariman

If you include myself and Richard Fitzgerald
(rf@opensource.wolfsonmicro.com) one of us will pick things up if
there are any issues.

Thanks,
Charles

Re: linux-next: build warnings after merge of the regmap tree

[Nariman Poushin]

On Fri, Jul 17, 2015 at 11:34:50AM +0100, Mark Brown wrote:
> On Fri, Jul 17, 2015 at 10:44:36AM +0100, Nariman Poushin wrote:
> 
> > What is the best course of action here? I am more than happy to help with
> > whatever is needed but unsure of the etiquette here and also not sure
> > what I can do.
> 
> > Clearly there are some clients that need updating but they were not
> > present in the regmap tree, so is the correct thing to do to merge
> > in the mfd and sound-asoc tree and provide a fixup commit?
> 
> > Just let me know and I am happy to do whatever is deemed correct.
> 
> Please send patches fixing the problems you have introduced.

I have sent the patches to fix the build errors you found Stephen.
Just wanted to let you guys know I will be on vacation for 1 week,
so if there are any issues they might not be addressed until then.

Thanks
Nariman

Re: linux-next: build warnings after merge of the regmap tree

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

On Fri, Jul 17, 2015 at 10:44:36AM +0100, Nariman Poushin wrote:

> What is the best course of action here? I am more than happy to help with
> whatever is needed but unsure of the etiquette here and also not sure
> what I can do.

> Clearly there are some clients that need updating but they were not
> present in the regmap tree, so is the correct thing to do to merge
> in the mfd and sound-asoc tree and provide a fixup commit?

> Just let me know and I am happy to do whatever is deemed correct.

Please send patches fixing the problems you have introduced.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: linux-next: build warnings after merge of the regmap tree

[Nariman Poushin]

On Fri, Jul 17, 2015 at 02:39:34PM +1000, Stephen Rothwell wrote:
> Hi Mark,
> 
> After merging the regmap tree, today's linux-next build (powerpc
> allyesconfig) produced these warnings:
> 
> sound/soc/codecs/wm5110.c: In function 'wm5110_hp_pre_enable':
> sound/soc/codecs/wm5110.c:294:9: warning: passing argument 2 of 'regmap_multi_reg_write' from incompatible pointer type
>   return regmap_multi_reg_write(arizona->regmap, wseq, nregs);
>          ^
> In file included from sound/soc/codecs/wm5110.c:19:0:
> include/linux/regmap.h:427:5: note: expected 'const struct reg_sequence *' but argument is of type 'const struct reg_default *'
>  int regmap_multi_reg_write(struct regmap *map, const struct reg_sequence *regs,
>      ^
> sound/soc/codecs/wm5110.c: In function 'wm5110_clear_pga_volume':
> sound/soc/codecs/wm5110.c:362:8: warning: passing argument 2 of 'regmap_multi_reg_write_bypassed' from incompatible pointer type
>   ret = regmap_multi_reg_write_bypassed(arizona->regmap, &clear_pga, 1);
>         ^
> In file included from sound/soc/codecs/wm5110.c:19:0:
> include/linux/regmap.h:429:5: note: expected 'const struct reg_sequence *' but argument is of type 'struct reg_default *'
>  int regmap_multi_reg_write_bypassed(struct regmap *map,
>      ^
> drivers/mfd/wm5110-tables.c: In function 'wm5110_patch':
> drivers/mfd/wm5110-tables.c:279:10: warning: passing argument 2 of 'regmap_register_patch' from incompatible pointer type
>    return regmap_register_patch(arizona->regmap,
>           ^
> In file included from include/linux/mfd/arizona/core.h:17:0,
>                  from drivers/mfd/wm5110-tables.c:15:
> include/linux/regmap.h:469:5: note: expected 'const struct reg_sequence *' but argument is of type 'const struct reg_default *'
>  int regmap_register_patch(struct regmap *map, const struct reg_sequence *regs,
>      ^
> drivers/mfd/wm8998-tables.c: In function 'wm8998_patch':
> drivers/mfd/wm8998-tables.c:48:9: warning: passing argument 2 of 'regmap_register_patch' from incompatible pointer type
>   return regmap_register_patch(arizona->regmap,
>          ^
> In file included from include/linux/mfd/arizona/core.h:17:0,
>                  from drivers/mfd/wm8998-tables.c:15:
> include/linux/regmap.h:469:5: note: expected 'const struct reg_sequence *' but argument is of type 'const struct reg_default *'
>  int regmap_register_patch(struct regmap *map, const struct reg_sequence *regs,
>      ^
> 
> Introduced by commit
> 
>   8019ff6cfc04 ("regmap: Use reg_sequence for multi_reg_write / register_patch")
> 
> interacting with commit
> 
>   561629755a21 ("mfd: arizona: Add support for WM8998 and WM1814")
> 
> from the mfd tree and commits
> 
>   d1acd31883d7 ("ASoC: wm5110: Add special DRE on/off handling for the headphone path")
>   81207880cef2 ("mfd: wm5110: Add register patch for rev E and above")
> 
> from the sound-asoc tree.
> 
> I may make up a merge fix for these on Monday ... I love API changes :-(

Hi Stephen, Mark,

What is the best course of action here? I am more than happy to help with
whatever is needed but unsure of the etiquette here and also not sure
what I can do.

Clearly there are some clients that need updating but they were not
present in the regmap tree, so is the correct thing to do to merge
in the mfd and sound-asoc tree and provide a fixup commit?

Just let me know and I am happy to do whatever is deemed correct.

Thanks
Nariman 

> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au

linux-next: build warnings after merge of the regmap tree

[Stephen Rothwell]

Hi Mark,

After merging the regmap tree, today's linux-next build (powerpc
allyesconfig) produced these warnings:

sound/soc/codecs/wm5110.c: In function 'wm5110_hp_pre_enable':
sound/soc/codecs/wm5110.c:294:9: warning: passing argument 2 of 'regmap_multi_reg_write' from incompatible pointer type
  return regmap_multi_reg_write(arizona->regmap, wseq, nregs);
         ^
In file included from sound/soc/codecs/wm5110.c:19:0:
include/linux/regmap.h:427:5: note: expected 'const struct reg_sequence *' but argument is of type 'const struct reg_default *'
 int regmap_multi_reg_write(struct regmap *map, const struct reg_sequence *regs,
     ^
sound/soc/codecs/wm5110.c: In function 'wm5110_clear_pga_volume':
sound/soc/codecs/wm5110.c:362:8: warning: passing argument 2 of 'regmap_multi_reg_write_bypassed' from incompatible pointer type
  ret = regmap_multi_reg_write_bypassed(arizona->regmap, &clear_pga, 1);
        ^
In file included from sound/soc/codecs/wm5110.c:19:0:
include/linux/regmap.h:429:5: note: expected 'const struct reg_sequence *' but argument is of type 'struct reg_default *'
 int regmap_multi_reg_write_bypassed(struct regmap *map,
     ^
drivers/mfd/wm5110-tables.c: In function 'wm5110_patch':
drivers/mfd/wm5110-tables.c:279:10: warning: passing argument 2 of 'regmap_register_patch' from incompatible pointer type
   return regmap_register_patch(arizona->regmap,
          ^
In file included from include/linux/mfd/arizona/core.h:17:0,
                 from drivers/mfd/wm5110-tables.c:15:
include/linux/regmap.h:469:5: note: expected 'const struct reg_sequence *' but argument is of type 'const struct reg_default *'
 int regmap_register_patch(struct regmap *map, const struct reg_sequence *regs,
     ^
drivers/mfd/wm8998-tables.c: In function 'wm8998_patch':
drivers/mfd/wm8998-tables.c:48:9: warning: passing argument 2 of 'regmap_register_patch' from incompatible pointer type
  return regmap_register_patch(arizona->regmap,
         ^
In file included from include/linux/mfd/arizona/core.h:17:0,
                 from drivers/mfd/wm8998-tables.c:15:
include/linux/regmap.h:469:5: note: expected 'const struct reg_sequence *' but argument is of type 'const struct reg_default *'
 int regmap_register_patch(struct regmap *map, const struct reg_sequence *regs,
     ^

Introduced by commit

  8019ff6cfc04 ("regmap: Use reg_sequence for multi_reg_write / register_patch")

interacting with commit

  561629755a21 ("mfd: arizona: Add support for WM8998 and WM1814")

from the mfd tree and commits

  d1acd31883d7 ("ASoC: wm5110: Add special DRE on/off handling for the headphone path")
  81207880cef2 ("mfd: wm5110: Add register patch for rev E and above")

from the sound-asoc tree.

I may make up a merge fix for these on Monday ... I love API changes :-(
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

Re: linux-next: build warnings after merge of the regmap tree

[Mark Brown]

On Tue, Aug 09, 2011 at 01:21:11PM +1000, Stephen Rothwell wrote:

> After merging the regmap tree, today's linux-next build (x86_64
> allmodconfig) produced these warning:

Well, if you will go and test with minority architectures with strange
choices for standard types :)

Should be fixed in -next tomorrow.

linux-next: build warnings after merge of the regmap tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

Hi Mark,

After merging the regmap tree, today's linux-next build (x86_64
allmodconfig) produced these warning:

drivers/base/regmap/regmap-debugfs.c: In function 'regmap_map_read_file':
drivers/base/regmap/regmap-debugfs.c:71:6: warning: field precision should have type 'int', but argument 4 has type 'size_t'
drivers/base/regmap/regmap-debugfs.c:78:7: warning: field precision should have type 'int', but argument 4 has type 'size_t'

Introduced by commit 31244e396fa9 ("regmap: Provide register map dump via
debugfs").

In file included from include/trace/ftrace.h:296:0,
                 from include/trace/define_trace.h:96,
                 from include/trace/events/regmap.h:112,
                 from drivers/base/regmap/regmap.c:19:
include/trace/events/regmap.h: In function 'ftrace_raw_output_regmap_block':
include/trace/events/regmap.h:58:1: warning: format '%d' expects type 'int', but argument 5 has type 'size_t'

Introduced by commit fb2736bbaee0 ("regmap: Add basic tracepoints").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]