* [patch] agp: info leak in agpioc_info_wrap()
@ 2013-04-13 9:16 Dan Carpenter
2013-05-31 12:26 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-04-13 9:16 UTC (permalink / raw)
To: David Airlie; +Cc: linux-kernel, kernel-janitors
On 64 bit systems the agp_info struct has a hole between ->agp_mode and
->aper_base. We need to clear it to avoid leaking stack information to
userspace.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/char/agp/frontend.c b/drivers/char/agp/frontend.c
index 2e04433..3fbce33 100644
--- a/drivers/char/agp/frontend.c
+++ b/drivers/char/agp/frontend.c
@@ -729,6 +729,7 @@ static int agpioc_info_wrap(struct agp_file_private *priv, void __user *arg)
agp_copy_info(agp_bridge, &kerninfo);
+ memset(&userinfo, 0, sizeof(userinfo));
userinfo.version.major = kerninfo.version.major;
userinfo.version.minor = kerninfo.version.minor;
userinfo.bridge_id = kerninfo.device->vendor |
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] agp: info leak in agpioc_info_wrap()
2013-04-13 9:16 [patch] agp: info leak in agpioc_info_wrap() Dan Carpenter
@ 2013-05-31 12:26 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2013-05-31 12:26 UTC (permalink / raw)
To: David Airlie; +Cc: linux-kernel, kernel-janitors
Ping?
regards,
dan carpenter
On Sat, Apr 13, 2013 at 12:16:11PM +0300, Dan Carpenter wrote:
> On 64 bit systems the agp_info struct has a hole between ->agp_mode and
> ->aper_base. We need to clear it to avoid leaking stack information to
> userspace.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/char/agp/frontend.c b/drivers/char/agp/frontend.c
> index 2e04433..3fbce33 100644
> --- a/drivers/char/agp/frontend.c
> +++ b/drivers/char/agp/frontend.c
> @@ -729,6 +729,7 @@ static int agpioc_info_wrap(struct agp_file_private *priv, void __user *arg)
>
> agp_copy_info(agp_bridge, &kerninfo);
>
> + memset(&userinfo, 0, sizeof(userinfo));
> userinfo.version.major = kerninfo.version.major;
> userinfo.version.minor = kerninfo.version.minor;
> userinfo.bridge_id = kerninfo.device->vendor |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-31 12:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-13 9:16 [patch] agp: info leak in agpioc_info_wrap() Dan Carpenter
2013-05-31 12:26 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).