* [PATCH] I2C: Fix i2c fail problem when a process is terminated by a signal on octeon in 3.8
@ 2013-04-18 7:40 송은봉
2013-04-19 18:30 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: 송은봉 @ 2013-04-18 7:40 UTC (permalink / raw)
To: wsa, linux-i2c; +Cc: linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1501 bytes --]
I rewrite my patch because the patch before i sent have many white space.
Thanks!
---
I've been debugging the abnormal operation of i2c on octeon.
If a process is terminated by signal in the middle of i2c operation,
next i2c read operation which is done by another process was failed.
So i changed to ignore signal in the middle of i2c operation.
After that the problem was not reproduced.
Signed-off-by: Eunbong Song <eunb.song@samsung.com>
---
drivers/i2c/busses/i2c-octeon.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-octeon.c b/drivers/i2c/busses/i2c-octeon.c
index 935585e..b2e3259 100644
--- a/drivers/i2c/busses/i2c-octeon.c
+++ b/drivers/i2c/busses/i2c-octeon.c
@@ -183,7 +183,7 @@ static irqreturn_t octeon_i2c_isr(int irq, void *dev_id)
struct octeon_i2c *i2c = dev_id;
octeon_i2c_int_disable(i2c);
- wake_up_interruptible(&i2c->queue);
+ wake_up(&i2c->queue);
return IRQ_HANDLED;
}
@@ -206,9 +206,9 @@ static int octeon_i2c_wait(struct octeon_i2c *i2c)
octeon_i2c_int_enable(i2c);
- result = wait_event_interruptible_timeout(i2c->queue,
- octeon_i2c_test_iflg(i2c),
- i2c->adap.timeout);
+ result = wait_event_timeout(i2c->queue,
+ octeon_i2c_test_iflg(i2c),
+ i2c->adap.timeout);
octeon_i2c_int_disable(i2c);
--
1.7.0.4
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] I2C: Fix i2c fail problem when a process is terminated by a signal on octeon in 3.8
2013-04-18 7:40 [PATCH] I2C: Fix i2c fail problem when a process is terminated by a signal on octeon in 3.8 송은봉
@ 2013-04-19 18:30 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2013-04-19 18:30 UTC (permalink / raw)
To: 송은봉; +Cc: linux-i2c, linux-kernel
On Thu, Apr 18, 2013 at 07:40:16AM +0000, 송은봉 wrote:
>
> I rewrite my patch because the patch before i sent have many white space.
> Thanks!
This should have been below the "---" after the sigend-off.
> ---
> I've been debugging the abnormal operation of i2c on octeon.
> If a process is terminated by signal in the middle of i2c operation,
> next i2c read operation which is done by another process was failed.
> So i changed to ignore signal in the middle of i2c operation.
> After that the problem was not reproduced.
>
> Signed-off-by: Eunbong Song <eunb.song@samsung.com>
Applied to for-next, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-19 18:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-18 7:40 [PATCH] I2C: Fix i2c fail problem when a process is terminated by a signal on octeon in 3.8 송은봉
2013-04-19 18:30 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).