From: Lee Jones <lee.jones@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Linus WALLEIJ <linus.walleij@stericsson.com>,
Russell King <linux@arm.linux.org.uk>,
Chris Ball <cjb@laptop.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH] mmc: mmci: Allow MMCI to request channels with information acquired from DT
Date: Tue, 30 Apr 2013 14:12:15 +0100 [thread overview]
Message-ID: <20130430131215.GA25256@gmail.com> (raw)
In-Reply-To: <CACRpkdY+WtjnJGhVOCk3OZW+Z1maO0ru+Fc2wPR7OzWe+RMuJg@mail.gmail.com>
On Tue, 30 Apr 2013, Linus Walleij wrote:
> On Wed, Apr 24, 2013 at 12:58 PM, Lee Jones <lee.jones@linaro.org> wrote:
>
> > Currently, if DMA information isn't passed from platform data, then DMA
> > will not be used. This patch allows DMA information obtained though Device
> > Tree to be used as well.
> >
> > Cc: Russell King <linux@arm.linux.org.uk>
> > Cc: Chris Ball <cjb@laptop.org>
> > Cc: linux-mmc@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> (...)
>
> I tried to test this patch, but:
> CC drivers/mmc/host/mmci.o
> /drivers/mmc/host/mmci.c: In function 'mmci_dma_setup':
> /drivers/mmc/host/mmci.c:307:51: error: 'dev' undeclared (first use in
> this function)
> /drivers/mmc/host/mmci.c:307:51: note: each undeclared identifier is
> reported only once for each function it appears in
> make[5]: *** [drivers/mmc/host/mmci.o] Error 1
> make[4]: *** [drivers/mmc/host] Error 2
> make[3]: *** [drivers/mmc] Error 2
>
> Due to:
>
> > @@ -304,10 +304,8 @@ static void mmci_dma_setup(struct mmci_host *host)
> > const char *rxname, *txname;
> > dma_cap_mask_t mask;
> >
> > - if (!plat || !plat->dma_filter) {
> > - dev_info(mmc_dev(host->mmc), "no DMA platform data\n");
> > - return;
> > - }
> > + host->dma_rx_channel = dma_request_slave_channel(dev, "rx");
> > + host->dma_tx_channel = dma_request_slave_channel(dev, "tx");
>
> There is no "dev" here.
You've missed v2 again dude.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-04-30 13:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 10:58 [PATCH] mmc: mmci: Allow MMCI to request channels with information acquired from DT Lee Jones
2013-04-24 15:55 ` [PATCH v2] " Lee Jones
2013-05-23 19:00 ` Linus Walleij
2013-04-30 13:01 ` [PATCH] " Linus Walleij
2013-04-30 13:12 ` Lee Jones [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-04-17 13:32 Lee Jones
2013-04-17 13:50 ` Arnd Bergmann
2013-04-17 15:04 ` Lee Jones
2013-04-17 15:31 ` Arnd Bergmann
2013-04-18 8:02 ` Lee Jones
2013-04-18 8:15 ` Russell King - ARM Linux
2013-04-18 9:25 ` Arnd Bergmann
2013-04-18 9:30 ` Russell King - ARM Linux
2013-04-18 8:21 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130430131215.GA25256@gmail.com \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).