* [PATCH] block: don't call kobj_map() with 0 @range
[not found] ` <20130605031520.GP14916@htj.dyndns.org>
@ 2013-06-06 1:20 ` Tejun Heo
0 siblings, 0 replies; only message in thread
From: Tejun Heo @ 2013-06-06 1:20 UTC (permalink / raw)
To: Jens Axboe; +Cc: hunger, Emese Revfy, PaX Team, linux-kernel
When fully dynamic devt allocation is used, gendisk->minors is zero.
In such cases, add_disk() calls blk_register_region() with 0 @range
expecting it to do nothing; however, blk_register_region() is a thin
wrapper around kobj_map(), which doesn't expect 0 @range input and
goes through an underflow while calculating the number of mapping
entries to allocate. Fortunately, it has limit check built-in and
this doesn't lead to anything disastrous - it just wastes 255 *
sizeof(struct probe) bytes.
When gendisk->minors is zero, the kobj_map isn't used at all and both
blk_[un]register_region() are expected to be noops. Add conditionals
to blk_[un]register_region() so that nothing happens when @range is
zero.
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: PaX Team <pageexec@freemail.hu>
Cc: stable@vger.kernel.org
---
block/genhd.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/block/genhd.c b/block/genhd.c
index 20625ee..3a4a1ed 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -467,21 +467,24 @@ static char *bdevt_str(dev_t devt, char *buf)
/*
* Register device numbers dev..(dev+range-1)
- * range must be nonzero
+ * Noop if @range is zero.
* The hash chain is sorted on range, so that subranges can override.
*/
void blk_register_region(dev_t devt, unsigned long range, struct module *module,
struct kobject *(*probe)(dev_t, int *, void *),
int (*lock)(dev_t, void *), void *data)
{
- kobj_map(bdev_map, devt, range, module, probe, lock, data);
+ if (range)
+ kobj_map(bdev_map, devt, range, module, probe, lock, data);
}
EXPORT_SYMBOL(blk_register_region);
+/* undo blk_register_region(), noop if @range is zero */
void blk_unregister_region(dev_t devt, unsigned long range)
{
- kobj_unmap(bdev_map, devt, range);
+ if (range)
+ kobj_unmap(bdev_map, devt, range);
}
EXPORT_SYMBOL(blk_unregister_region);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-06-06 1:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <51AE6E08.84.10D1DE36@pageexec.freemail.hu>
[not found] ` <20130605031520.GP14916@htj.dyndns.org>
2013-06-06 1:20 ` [PATCH] block: don't call kobj_map() with 0 @range Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).