* [PATCH] perf,x86: fix broken PEBS-LL support on SNB-EP/IVB-EP
@ 2013-06-07 21:22 Stephane Eranian
2013-06-18 9:09 ` Peter Zijlstra
2013-06-19 18:38 ` [tip:perf/core] perf/x86: Fix broken PEBS-LL support on SNB-EP/ IVB-EP tip-bot for Stephane Eranian
0 siblings, 2 replies; 3+ messages in thread
From: Stephane Eranian @ 2013-06-07 21:22 UTC (permalink / raw)
To: linux-kernel; +Cc: peterz, mingo, dzickus, ak, jolsa
This patch fixes broken support of PEBS-LL on SNB-EP/IVB-EP.
For some reason, the LDLAT extra reg definition for snb_ep
showed up as duplicate in the snb table.
This patch moves the definition of LDLAT back into the
snb_ep table.
Thanks to Don Zickus for tracking this one down.
Signed-off-by: Stephane Eranian <eranian@google.com>
---
diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c
index f60d41f..a9e2207 100644
--- a/arch/x86/kernel/cpu/perf_event_intel.c
+++ b/arch/x86/kernel/cpu/perf_event_intel.c
@@ -165,13 +165,13 @@ static struct extra_reg intel_snb_extra_regs[] __read_mostly = {
INTEL_EVENT_EXTRA_REG(0xb7, MSR_OFFCORE_RSP_0, 0x3f807f8fffull, RSP_0),
INTEL_EVENT_EXTRA_REG(0xbb, MSR_OFFCORE_RSP_1, 0x3f807f8fffull, RSP_1),
INTEL_UEVENT_PEBS_LDLAT_EXTRA_REG(0x01cd),
- INTEL_UEVENT_PEBS_LDLAT_EXTRA_REG(0x01cd),
EVENT_EXTRA_END
};
static struct extra_reg intel_snbep_extra_regs[] __read_mostly = {
INTEL_EVENT_EXTRA_REG(0xb7, MSR_OFFCORE_RSP_0, 0x3fffff8fffull, RSP_0),
INTEL_EVENT_EXTRA_REG(0xbb, MSR_OFFCORE_RSP_1, 0x3fffff8fffull, RSP_1),
+ INTEL_UEVENT_PEBS_LDLAT_EXTRA_REG(0x01cd),
EVENT_EXTRA_END
};
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf,x86: fix broken PEBS-LL support on SNB-EP/IVB-EP
2013-06-07 21:22 [PATCH] perf,x86: fix broken PEBS-LL support on SNB-EP/IVB-EP Stephane Eranian
@ 2013-06-18 9:09 ` Peter Zijlstra
2013-06-19 18:38 ` [tip:perf/core] perf/x86: Fix broken PEBS-LL support on SNB-EP/ IVB-EP tip-bot for Stephane Eranian
1 sibling, 0 replies; 3+ messages in thread
From: Peter Zijlstra @ 2013-06-18 9:09 UTC (permalink / raw)
To: Stephane Eranian; +Cc: linux-kernel, mingo, dzickus, ak, jolsa
On Fri, Jun 07, 2013 at 11:22:10PM +0200, Stephane Eranian wrote:
>
> This patch fixes broken support of PEBS-LL on SNB-EP/IVB-EP.
> For some reason, the LDLAT extra reg definition for snb_ep
> showed up as duplicate in the snb table.
>
> This patch moves the definition of LDLAT back into the
> snb_ep table.
>
> Thanks to Don Zickus for tracking this one down.
>
> Signed-off-by: Stephane Eranian <eranian@google.com>
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:perf/core] perf/x86: Fix broken PEBS-LL support on SNB-EP/ IVB-EP
2013-06-07 21:22 [PATCH] perf,x86: fix broken PEBS-LL support on SNB-EP/IVB-EP Stephane Eranian
2013-06-18 9:09 ` Peter Zijlstra
@ 2013-06-19 18:38 ` tip-bot for Stephane Eranian
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Stephane Eranian @ 2013-06-19 18:38 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, eranian, hpa, mingo, peterz, tglx
Commit-ID: f1a527899ef0a8a241eb3bea619eb2e29d797f44
Gitweb: http://git.kernel.org/tip/f1a527899ef0a8a241eb3bea619eb2e29d797f44
Author: Stephane Eranian <eranian@google.com>
AuthorDate: Fri, 7 Jun 2013 23:22:10 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 19 Jun 2013 12:44:16 +0200
perf/x86: Fix broken PEBS-LL support on SNB-EP/IVB-EP
This patch fixes broken support of PEBS-LL on SNB-EP/IVB-EP.
For some reason, the LDLAT extra reg definition for snb_ep
showed up as duplicate in the snb table.
This patch moves the definition of LDLAT back into the
snb_ep table.
Thanks to Don Zickus for tracking this one down.
Signed-off-by: Stephane Eranian <eranian@google.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20130607212210.GA11849@quad
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/kernel/cpu/perf_event_intel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c
index f60d41f..a9e2207 100644
--- a/arch/x86/kernel/cpu/perf_event_intel.c
+++ b/arch/x86/kernel/cpu/perf_event_intel.c
@@ -165,13 +165,13 @@ static struct extra_reg intel_snb_extra_regs[] __read_mostly = {
INTEL_EVENT_EXTRA_REG(0xb7, MSR_OFFCORE_RSP_0, 0x3f807f8fffull, RSP_0),
INTEL_EVENT_EXTRA_REG(0xbb, MSR_OFFCORE_RSP_1, 0x3f807f8fffull, RSP_1),
INTEL_UEVENT_PEBS_LDLAT_EXTRA_REG(0x01cd),
- INTEL_UEVENT_PEBS_LDLAT_EXTRA_REG(0x01cd),
EVENT_EXTRA_END
};
static struct extra_reg intel_snbep_extra_regs[] __read_mostly = {
INTEL_EVENT_EXTRA_REG(0xb7, MSR_OFFCORE_RSP_0, 0x3fffff8fffull, RSP_0),
INTEL_EVENT_EXTRA_REG(0xbb, MSR_OFFCORE_RSP_1, 0x3fffff8fffull, RSP_1),
+ INTEL_UEVENT_PEBS_LDLAT_EXTRA_REG(0x01cd),
EVENT_EXTRA_END
};
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-19 18:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-07 21:22 [PATCH] perf,x86: fix broken PEBS-LL support on SNB-EP/IVB-EP Stephane Eranian
2013-06-18 9:09 ` Peter Zijlstra
2013-06-19 18:38 ` [tip:perf/core] perf/x86: Fix broken PEBS-LL support on SNB-EP/ IVB-EP tip-bot for Stephane Eranian
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).