* Re: [PATCH] MIPS: Fix OCTEON BUG() warnings a different way.
[not found] <1371679468-29479-1-git-send-email-ddaney.cavm@gmail.com>
@ 2013-06-20 14:26 ` Ralf Baechle
0 siblings, 0 replies; only message in thread
From: Ralf Baechle @ 2013-06-20 14:26 UTC (permalink / raw)
To: David Daney; +Cc: linux-mips, David Daney, linux-kernel
On Wed, Jun 19, 2013 at 03:04:28PM -0700, David Daney wrote:
> Signed-off-by: David Daney <david.daney@cavium.com>
I replaced my fix with your fix but left he direct inclusion of
<linux/bug.h>.
Let as homework for a later point: make BUG() invoke unreachable() if
CONFIG_BUG is diabled, something like that. This will improve code
generation for GCC 4.5+ but for older compilers unreachable() is
defined as do { } while (1) so will emit extra code.
Thanks,
Ralf
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2013-06-20 14:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1371679468-29479-1-git-send-email-ddaney.cavm@gmail.com>
2013-06-20 14:26 ` [PATCH] MIPS: Fix OCTEON BUG() warnings a different way Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).