* [PATCH] usb: host: xhci-plat: release mem region while removing module
@ 2013-06-21 8:29 George Cherian
2013-06-24 14:22 ` Felipe Balbi
0 siblings, 1 reply; 3+ messages in thread
From: George Cherian @ 2013-06-21 8:29 UTC (permalink / raw)
To: linux-usb
Cc: balbi, linux-omap, linux-kernel, gregkh, sarah.a.sharp, George Cherian
Do a release_mem_region of the hcd resource. Without this the
subsequent insertion of module fails in request_mem_region.
Signed-off-by: George Cherian <george.cherian@ti.com>
---
drivers/usb/host/xhci-plat.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index df90fe5..93ad67e 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -179,6 +179,7 @@ static int xhci_plat_remove(struct platform_device *dev)
usb_remove_hcd(hcd);
iounmap(hcd->regs);
+ release_mem_region(hcd->rsrc_start, hcd->rsrc_len);
usb_put_hcd(hcd);
kfree(xhci);
--
1.8.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: host: xhci-plat: release mem region while removing module
2013-06-21 8:29 [PATCH] usb: host: xhci-plat: release mem region while removing module George Cherian
@ 2013-06-24 14:22 ` Felipe Balbi
2013-06-25 18:23 ` Sarah Sharp
0 siblings, 1 reply; 3+ messages in thread
From: Felipe Balbi @ 2013-06-24 14:22 UTC (permalink / raw)
To: George Cherian
Cc: linux-usb, balbi, linux-omap, linux-kernel, gregkh, sarah.a.sharp
[-- Attachment #1: Type: text/plain, Size: 469 bytes --]
On Fri, Jun 21, 2013 at 01:59:08PM +0530, George Cherian wrote:
> Do a release_mem_region of the hcd resource. Without this the
> subsequent insertion of module fails in request_mem_region.
>
> Signed-off-by: George Cherian <george.cherian@ti.com>
very nice catch.
Acked-by: Felipe Balbi <balbi@ti.com>
You need to resend with:
Cc: <stable@vger.kernel.org> # v3.4+
Not sure if Sarah wants to take care of the stable tagging, though.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: host: xhci-plat: release mem region while removing module
2013-06-24 14:22 ` Felipe Balbi
@ 2013-06-25 18:23 ` Sarah Sharp
0 siblings, 0 replies; 3+ messages in thread
From: Sarah Sharp @ 2013-06-25 18:23 UTC (permalink / raw)
To: Felipe Balbi; +Cc: George Cherian, linux-usb, linux-omap, linux-kernel, gregkh
On Mon, Jun 24, 2013 at 05:22:24PM +0300, Felipe Balbi wrote:
> On Fri, Jun 21, 2013 at 01:59:08PM +0530, George Cherian wrote:
> > Do a release_mem_region of the hcd resource. Without this the
> > subsequent insertion of module fails in request_mem_region.
> >
> > Signed-off-by: George Cherian <george.cherian@ti.com>
>
> very nice catch.
>
> Acked-by: Felipe Balbi <balbi@ti.com>
>
> You need to resend with:
>
> Cc: <stable@vger.kernel.org> # v3.4+
>
> Not sure if Sarah wants to take care of the stable tagging, though.
I'll take care of the stable tagging.
Sarah Sharp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-25 18:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-21 8:29 [PATCH] usb: host: xhci-plat: release mem region while removing module George Cherian
2013-06-24 14:22 ` Felipe Balbi
2013-06-25 18:23 ` Sarah Sharp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).