* [PATCH] misc/bmp085: Enable building as a module
@ 2013-06-24 14:10 Ben Hutchings
2013-06-25 7:27 ` Eric Andersson
0 siblings, 1 reply; 4+ messages in thread
From: Ben Hutchings @ 2013-06-24 14:10 UTC (permalink / raw)
To: Arnd Bergmann, Greg Kroah-Hartman; +Cc: Eric Andersson, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 707 bytes --]
Commit 985087dbcb02 'misc: add support for bmp18x chips to the bmp085
driver' changed the BMP085 config symbol to a boolean. I see no
reason why the shared code cannot be built as a module, so change it
back to tristate.
Cc: Eric Andersson <eric.andersson@unixphere.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
drivers/misc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index c002d86..7a68184 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -451,7 +451,7 @@ config ARM_CHARLCD
still useful.
config BMP085
- bool
+ tristate
depends on SYSFS
config BMP085_I2C
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] misc/bmp085: Enable building as a module
2013-06-24 14:10 [PATCH] misc/bmp085: Enable building as a module Ben Hutchings
@ 2013-06-25 7:27 ` Eric Andersson
2013-06-25 12:16 ` Ben Hutchings
0 siblings, 1 reply; 4+ messages in thread
From: Eric Andersson @ 2013-06-25 7:27 UTC (permalink / raw)
To: Ben Hutchings; +Cc: Arnd Bergmann, Greg Kroah-Hartman, linux-kernel
On 15:10 Mon 24 Jun , Ben Hutchings wrote:
> Commit 985087dbcb02 'misc: add support for bmp18x chips to the bmp085
> driver' changed the BMP085 config symbol to a boolean. I see no
> reason why the shared code cannot be built as a module, so change it
> back to tristate.
>
> Cc: Eric Andersson <eric.andersson@unixphere.com>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> drivers/misc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index c002d86..7a68184 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -451,7 +451,7 @@ config ARM_CHARLCD
> still useful.
>
> config BMP085
> - bool
> + tristate
> depends on SYSFS
>
> config BMP085_I2C
>
There is no reason for building the common code stand-alone. The BMP085
config option is only selectable via the BMP085_I2C/_SPI options.
See the select-statement for those options:
config BMP085_I2C
tristate "BMP085 digital pressure sensor on I2C"
select BMP085
...
--
Best regards,
Eric
http://www.unixphere.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] misc/bmp085: Enable building as a module
2013-06-25 7:27 ` Eric Andersson
@ 2013-06-25 12:16 ` Ben Hutchings
2013-06-26 11:08 ` Eric Andersson
0 siblings, 1 reply; 4+ messages in thread
From: Ben Hutchings @ 2013-06-25 12:16 UTC (permalink / raw)
To: Eric Andersson; +Cc: Arnd Bergmann, Greg Kroah-Hartman, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1371 bytes --]
On Tue, 2013-06-25 at 09:27 +0200, Eric Andersson wrote:
> On 15:10 Mon 24 Jun , Ben Hutchings wrote:
> > Commit 985087dbcb02 'misc: add support for bmp18x chips to the bmp085
> > driver' changed the BMP085 config symbol to a boolean. I see no
> > reason why the shared code cannot be built as a module, so change it
> > back to tristate.
> >
> > Cc: Eric Andersson <eric.andersson@unixphere.com>
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > ---
> > drivers/misc/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> > index c002d86..7a68184 100644
> > --- a/drivers/misc/Kconfig
> > +++ b/drivers/misc/Kconfig
> > @@ -451,7 +451,7 @@ config ARM_CHARLCD
> > still useful.
> >
> > config BMP085
> > - bool
> > + tristate
> > depends on SYSFS
> >
> > config BMP085_I2C
> >
>
> There is no reason for building the common code stand-alone. The BMP085
> config option is only selectable via the BMP085_I2C/_SPI options.
Yes, but it is then always built-in.
Ben.
> See the select-statement for those options:
>
> config BMP085_I2C
> tristate "BMP085 digital pressure sensor on I2C"
> select BMP085
> ...
>
--
Ben Hutchings
Life is like a sewer:
what you get out of it depends on what you put into it.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] misc/bmp085: Enable building as a module
2013-06-25 12:16 ` Ben Hutchings
@ 2013-06-26 11:08 ` Eric Andersson
0 siblings, 0 replies; 4+ messages in thread
From: Eric Andersson @ 2013-06-26 11:08 UTC (permalink / raw)
To: Ben Hutchings; +Cc: Arnd Bergmann, Greg Kroah-Hartman, linux-kernel
On 13:16 Tue 25 Jun , Ben Hutchings wrote:
> On Tue, 2013-06-25 at 09:27 +0200, Eric Andersson wrote:
> > On 15:10 Mon 24 Jun , Ben Hutchings wrote:
> > > Commit 985087dbcb02 'misc: add support for bmp18x chips to the bmp085
> > > driver' changed the BMP085 config symbol to a boolean. I see no
> > > reason why the shared code cannot be built as a module, so change it
> > > back to tristate.
> > >
> > > Cc: Eric Andersson <eric.andersson@unixphere.com>
> > > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > > ---
> > > drivers/misc/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> > > index c002d86..7a68184 100644
> > > --- a/drivers/misc/Kconfig
> > > +++ b/drivers/misc/Kconfig
> > > @@ -451,7 +451,7 @@ config ARM_CHARLCD
> > > still useful.
> > >
> > > config BMP085
> > > - bool
> > > + tristate
> > > depends on SYSFS
> > >
> > > config BMP085_I2C
> > >
> >
> > There is no reason for building the common code stand-alone. The BMP085
> > config option is only selectable via the BMP085_I2C/_SPI options.
>
> Yes, but it is then always built-in.
Good point. This change is fine by me.
--
Best regards,
Eric
http://www.unixphere.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-26 11:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-24 14:10 [PATCH] misc/bmp085: Enable building as a module Ben Hutchings
2013-06-25 7:27 ` Eric Andersson
2013-06-25 12:16 ` Ben Hutchings
2013-06-26 11:08 ` Eric Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).