From: Andrew Morton <akpm@linux-foundation.org>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: linux-mm@kvack.org, Mel Gorman <mgorman@suse.de>,
Hugh Dickins <hughd@google.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Andi Kleen <andi@firstfloor.org>, Hillf Danton <dhillf@gmail.com>,
Michal Hocko <mhocko@suse.cz>, Rik van Riel <riel@redhat.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Wanpeng Li <liwanp@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org,
Naoya Horiguchi <nao.horiguchi@gmail.com>
Subject: Re: [PATCH v5 0/9] extend hugepage migration
Date: Wed, 14 Aug 2013 16:40:52 -0700 [thread overview]
Message-ID: <20130814164052.2ccdd5bdf7ab56deeba88e68@linux-foundation.org> (raw)
In-Reply-To: <1376025702-14818-1-git-send-email-n-horiguchi@ah.jp.nec.com>
On Fri, 9 Aug 2013 01:21:33 -0400 Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> wrote:
> Here is the 5th version of hugepage migration patchset.
> Changes in this version are as follows:
> - removed putback_active_hugepages() as a cleanup (1/9)
> - added code to check movability of a given hugepage (8/9)
> - set GFP MOVABLE flag depending on the movability of hugepage (9/9).
>
> I feel that 8/9 and 9/9 contain some new things, so need reviews on them.
>
> TODOs: (likely to be done after this work)
> - split page table lock for pmd/pud based hugepage (maybe applicable to thp)
> - improve alloc_migrate_target (especially in node choice)
> - using page walker in check_range
This is a pretty large and complex patchset. I skimmed the patches
(and have one trivial comment) then queued them up for a bit of
testing. I've asked Mel if he can find time to review the changes
(please).
btw, it would be helpful if this [patch 0/n] had a decent overview of
the patch series - what are the objectives, how were they achieved,
what value they have to our users, testing results, etc.
mm-prepare-to-remove-proc-sys-vm-hugepages_treat_as_movable.patch had a
conflict with
http://ozlabs.org/~akpm/mmots/broken-out/mm-hugetlb-move-up-the-code-which-check-availability-of-free-huge-page.patch
which I resolved in the obvious manner. Please check that from a
runtime perspective.
next prev parent reply other threads:[~2013-08-14 23:40 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 5:21 [PATCH v5 0/9] extend hugepage migration Naoya Horiguchi
2013-08-09 5:21 ` [PATCH 1/9] migrate: make core migration code aware of hugepage Naoya Horiguchi
2013-09-10 13:51 ` Mel Gorman
2013-09-10 19:18 ` Naoya Horiguchi
2013-08-09 5:21 ` [PATCH 2/9] soft-offline: use migrate_pages() instead of migrate_huge_page() Naoya Horiguchi
2013-08-09 5:21 ` [PATCH 3/9] migrate: add hugepage migration code to migrate_pages() Naoya Horiguchi
2013-08-14 23:41 ` Andrew Morton
2013-08-15 1:15 ` Naoya Horiguchi
2013-09-10 14:33 ` Mel Gorman
2013-09-10 19:45 ` Naoya Horiguchi
2013-08-09 5:21 ` [PATCH 4/9] migrate: add hugepage migration code to move_pages() Naoya Horiguchi
2013-09-28 17:26 ` Borislav Petkov
2013-09-30 15:01 ` Naoya Horiguchi
2013-09-30 16:04 ` Borislav Petkov
2013-09-30 16:08 ` Naoya Horiguchi
2013-11-12 11:56 ` Borislav Petkov
2013-11-14 15:47 ` [PATCH] mm/migrate.c: take returned value of isolate_huge_page()(Re: [PATCH 4/9] migrate: add hugepage migration code to move_pages()) Naoya Horiguchi
2013-11-14 23:11 ` David Rientjes
2013-11-15 15:03 ` [PATCH] mm/migrate.c: take returned value ofisolate_huge_page()(Re: [PATCH 4/9] migrate: add hugepage migration code tomove_pages()) Naoya Horiguchi
2013-11-15 23:01 ` David Rientjes
2013-08-09 5:21 ` [PATCH 5/9] mbind: add hugepage migration code to mbind() Naoya Horiguchi
2013-09-10 14:41 ` Mel Gorman
2013-09-10 21:53 ` Naoya Horiguchi
2013-09-10 22:47 ` Andi Kleen
2013-08-09 5:21 ` [PATCH 6/9] migrate: remove VM_HUGETLB from vma flag check in vma_migratable() Naoya Horiguchi
2013-08-09 5:21 ` [PATCH 7/9] memory-hotplug: enable memory hotplug to handle hugepage Naoya Horiguchi
2013-08-09 5:21 ` [PATCH 8/9] migrate: check movability of hugepage in unmap_and_move_huge_page() Naoya Horiguchi
2013-08-11 17:51 ` Aneesh Kumar K.V
2013-08-09 5:21 ` [PATCH 9/9] prepare to remove /proc/sys/vm/hugepages_treat_as_movable Naoya Horiguchi
2013-08-11 17:43 ` Aneesh Kumar K.V
2013-08-12 18:10 ` Naoya Horiguchi
2013-09-10 14:48 ` Mel Gorman
2013-08-14 23:40 ` Andrew Morton [this message]
2013-08-15 6:23 ` [PATCH v5 0/9] extend hugepage migration Naoya Horiguchi
2013-08-15 19:39 ` Andrew Morton
2013-08-15 19:48 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130814164052.2ccdd5bdf7ab56deeba88e68@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=dhillf@gmail.com \
--cc=hughd@google.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=nao.horiguchi@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).