Re: [PATCH 4/9] migrate: add hugepage migration code to move_pages()

From: Borislav Petkov <bp@alien8.de>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, Mel Gorman <mgorman@suse.de>,
	Hugh Dickins <hughd@google.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Andi Kleen <andi@firstfloor.org>, Hillf Danton <dhillf@gmail.com>,
	Michal Hocko <mhocko@suse.cz>, Rik van Riel <riel@redhat.com>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	Wanpeng Li <liwanp@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org,
	Naoya Horiguchi <nao.horiguchi@gmail.com>
Subject: Re: [PATCH 4/9] migrate: add hugepage migration code to move_pages()
Date: Tue, 12 Nov 2013 12:56:33 +0100	[thread overview]
Message-ID: <20131112115633.GA16700@pd.tnic> (raw)
In-Reply-To: <1380557324-v44mpchd-mutt-n-horiguchi@ah.jp.nec.com>

[-- Attachment #1: Type: text/plain, Size: 1893 bytes --]

On Mon, Sep 30, 2013 at 12:08:44PM -0400, Naoya Horiguchi wrote:
> On Mon, Sep 30, 2013 at 06:04:50PM +0200, Borislav Petkov wrote:
> > On Mon, Sep 30, 2013 at 11:01:03AM -0400, Naoya Horiguchi wrote:
> > > Thanks for reporting. The patch should fix this.
> > > 
> > > Naoya Horiguchi
> > > ---
> > > From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> > > Date: Mon, 30 Sep 2013 10:22:26 -0400
> > > Subject: [PATCH] mm/migrate.c: take returned value of isolate_huge_page()
> > > 
> > > Introduces a cosmetic substitution of the returned value of isolate_huge_page()
> > > to suppress a build warning when !CONFIG_HUGETLBFS. No behavioral change.
> > > 
> > > Reported-by: Borislav Petkov <bp@alien8.de>
> > > Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> > 
> > Thanks for this. Unfortunately, I cannot trigger it anymore. :\ Maybe it
> > is because I pulled latest git and this was triggering only on a older
> > repo state, hmmm.
> > 
> > The patch looks obviously correct though so you could send it up or hold
> > on to it until someone else reports it.
> > 
> > Anyway, sorry for the trouble.
> 
> OK, no problem :)

Hey Naoya,

I can trigger this issue again.

Kernel is latest Linus: v3.12-4849-g10d0c9705e80

Compiler is: gcc (Debian 4.8.1-10) 4.8.1, config is attached.

And yes, the patch you sent me previously is still good and fixes the
warning so feel free to add my Tested-by: tag.

In file included from mm/migrate.c:35:0:
mm/migrate.c: In function ‘do_move_page_to_node_array’:
include/linux/hugetlb.h:140:33: warning: statement with no effect [-Wunused-value]
 #define isolate_huge_page(p, l) false
                                 ^
mm/migrate.c:1181:4: note: in expansion of macro ‘isolate_huge_page’
    isolate_huge_page(page, &pagelist);
    ^

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--

[-- Attachment #2: config.gz --]
[-- Type: application/octet-stream, Size: 20043 bytes --]