linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] [media] uvcvideo: quirk PROBE_DEF for Dell SP2008WFP monitor.
       [not found] <cover.1377781889.git.joseph.salisbury@canonical.com>
@ 2013-08-29 15:17 ` Joseph Salisbury
  2013-08-30  0:41   ` Laurent Pinchart
  0 siblings, 1 reply; 6+ messages in thread
From: Joseph Salisbury @ 2013-08-29 15:17 UTC (permalink / raw)
  To: linux-kernel; +Cc: laurent.pinchart, m.chehab, linux-media, stable

BugLink: http://bugs.launchpad.net/bugs/1217957

Add quirk for Dell SP2008WFP monitor: 05a9:2641

Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
Tested-by: Christopher Townsend <christopher.townsend@canonical.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com> 
Cc: linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
---
 drivers/media/usb/uvc/uvc_driver.c |    9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index ed123f4..8c1826c 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -2174,6 +2174,15 @@ static struct usb_device_id uvc_ids[] = {
 	  .bInterfaceSubClass	= 1,
 	  .bInterfaceProtocol	= 0,
 	  .driver_info 		= UVC_QUIRK_PROBE_DEF },
+	/* Dell SP2008WFP Monitor */
+	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
+				| USB_DEVICE_ID_MATCH_INT_INFO,
+	  .idVendor		= 0x05a9,
+	  .idProduct		= 0x2641,
+	  .bInterfaceClass	= USB_CLASS_VIDEO,
+	  .bInterfaceSubClass	= 1,
+	  .bInterfaceProtocol	= 0,
+	  .driver_info 		= UVC_QUIRK_PROBE_DEF },
 	/* Dell Alienware X51 */
 	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
 				| USB_DEVICE_ID_MATCH_INT_INFO,
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] [media] uvcvideo: quirk PROBE_DEF for Dell SP2008WFP monitor.
  2013-08-29 15:17 ` [PATCH 1/1] [media] uvcvideo: quirk PROBE_DEF for Dell SP2008WFP monitor Joseph Salisbury
@ 2013-08-30  0:41   ` Laurent Pinchart
  2013-08-30  4:00     ` Greg KH
  0 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2013-08-30  0:41 UTC (permalink / raw)
  To: Joseph Salisbury; +Cc: linux-kernel, m.chehab, linux-media, stable

Hi Joseph,

Thank you for the patch.

On Thursday 29 August 2013 11:17:41 Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1217957
> 
> Add quirk for Dell SP2008WFP monitor: 05a9:2641
> 
> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
> Tested-by: Christopher Townsend <christopher.townsend@canonical.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
> Cc: linux-media@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: stable@vger.kernel.org

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I've applied it to my tree. Given that we're too close to the v3.12 merge 
window I will push it for v3.13.

> ---
>  drivers/media/usb/uvc/uvc_driver.c |    9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/media/usb/uvc/uvc_driver.c
> b/drivers/media/usb/uvc/uvc_driver.c index ed123f4..8c1826c 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2174,6 +2174,15 @@ static struct usb_device_id uvc_ids[] = {
>  	  .bInterfaceSubClass	= 1,
>  	  .bInterfaceProtocol	= 0,
>  	  .driver_info 		= UVC_QUIRK_PROBE_DEF },
> +	/* Dell SP2008WFP Monitor */
> +	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
> +				| USB_DEVICE_ID_MATCH_INT_INFO,
> +	  .idVendor		= 0x05a9,
> +	  .idProduct		= 0x2641,
> +	  .bInterfaceClass	= USB_CLASS_VIDEO,
> +	  .bInterfaceSubClass	= 1,
> +	  .bInterfaceProtocol	= 0,
> +	  .driver_info 		= UVC_QUIRK_PROBE_DEF },
>  	/* Dell Alienware X51 */
>  	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
> 
>  				| USB_DEVICE_ID_MATCH_INT_INFO,
-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] [media] uvcvideo: quirk PROBE_DEF for Dell SP2008WFP monitor.
  2013-08-30  0:41   ` Laurent Pinchart
@ 2013-08-30  4:00     ` Greg KH
  2013-08-30 10:28       ` Laurent Pinchart
  0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2013-08-30  4:00 UTC (permalink / raw)
  To: Laurent Pinchart
  Cc: Joseph Salisbury, linux-kernel, m.chehab, linux-media, stable

On Fri, Aug 30, 2013 at 02:41:17AM +0200, Laurent Pinchart wrote:
> Hi Joseph,
> 
> Thank you for the patch.
> 
> On Thursday 29 August 2013 11:17:41 Joseph Salisbury wrote:
> > BugLink: http://bugs.launchpad.net/bugs/1217957
> > 
> > Add quirk for Dell SP2008WFP monitor: 05a9:2641
> > 
> > Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
> > Tested-by: Christopher Townsend <christopher.townsend@canonical.com>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
> > Cc: linux-media@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Cc: stable@vger.kernel.org
> 
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> I've applied it to my tree. Given that we're too close to the v3.12 merge 
> window I will push it for v3.13.

A quirk has to wait that long?  That's not ok, they should go in much
sooner than that...

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] [media] uvcvideo: quirk PROBE_DEF for Dell SP2008WFP monitor.
  2013-08-30  4:00     ` Greg KH
@ 2013-08-30 10:28       ` Laurent Pinchart
  2013-08-30 16:39         ` Greg KH
  0 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2013-08-30 10:28 UTC (permalink / raw)
  To: Greg KH; +Cc: Joseph Salisbury, linux-kernel, m.chehab, linux-media, stable

Hi Greg,

On Thursday 29 August 2013 21:00:21 Greg KH wrote:
> On Fri, Aug 30, 2013 at 02:41:17AM +0200, Laurent Pinchart wrote:
> > On Thursday 29 August 2013 11:17:41 Joseph Salisbury wrote:
> > > BugLink: http://bugs.launchpad.net/bugs/1217957
> > > 
> > > Add quirk for Dell SP2008WFP monitor: 05a9:2641
> > > 
> > > Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
> > > Tested-by: Christopher Townsend <christopher.townsend@canonical.com>
> > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
> > > Cc: linux-media@vger.kernel.org
> > > Cc: linux-kernel@vger.kernel.org
> > > Cc: stable@vger.kernel.org
> > 
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > 
> > I've applied it to my tree. Given that we're too close to the v3.12 merge
> > window I will push it for v3.13.
> 
> A quirk has to wait that long?  That's not ok, they should go in much
> sooner than that...

Can such a patch get merged during the -rc phase ? If so I will push it to 
v3.12.

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] [media] uvcvideo: quirk PROBE_DEF for Dell SP2008WFP monitor.
  2013-08-30 10:28       ` Laurent Pinchart
@ 2013-08-30 16:39         ` Greg KH
  2013-08-30 16:45           ` Laurent Pinchart
  0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2013-08-30 16:39 UTC (permalink / raw)
  To: Laurent Pinchart
  Cc: Joseph Salisbury, linux-kernel, m.chehab, linux-media, stable

On Fri, Aug 30, 2013 at 12:28:16PM +0200, Laurent Pinchart wrote:
> Hi Greg,
> 
> On Thursday 29 August 2013 21:00:21 Greg KH wrote:
> > On Fri, Aug 30, 2013 at 02:41:17AM +0200, Laurent Pinchart wrote:
> > > On Thursday 29 August 2013 11:17:41 Joseph Salisbury wrote:
> > > > BugLink: http://bugs.launchpad.net/bugs/1217957
> > > > 
> > > > Add quirk for Dell SP2008WFP monitor: 05a9:2641
> > > > 
> > > > Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
> > > > Tested-by: Christopher Townsend <christopher.townsend@canonical.com>
> > > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > > Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
> > > > Cc: linux-media@vger.kernel.org
> > > > Cc: linux-kernel@vger.kernel.org
> > > > Cc: stable@vger.kernel.org
> > > 
> > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > 
> > > I've applied it to my tree. Given that we're too close to the v3.12 merge
> > > window I will push it for v3.13.
> > 
> > A quirk has to wait that long?  That's not ok, they should go in much
> > sooner than that...
> 
> Can such a patch get merged during the -rc phase ? If so I will push it to 
> v3.12.

Yes it can, and it should also be merged to stable releases, as the cc:
stable shows.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] [media] uvcvideo: quirk PROBE_DEF for Dell SP2008WFP monitor.
  2013-08-30 16:39         ` Greg KH
@ 2013-08-30 16:45           ` Laurent Pinchart
  0 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2013-08-30 16:45 UTC (permalink / raw)
  To: Greg KH; +Cc: Joseph Salisbury, linux-kernel, m.chehab, linux-media, stable

Hi Greg,

On Friday 30 August 2013 09:39:58 Greg KH wrote:
> On Fri, Aug 30, 2013 at 12:28:16PM +0200, Laurent Pinchart wrote:
> > On Thursday 29 August 2013 21:00:21 Greg KH wrote:
> > > On Fri, Aug 30, 2013 at 02:41:17AM +0200, Laurent Pinchart wrote:
> > > > On Thursday 29 August 2013 11:17:41 Joseph Salisbury wrote:
> > > > > BugLink: http://bugs.launchpad.net/bugs/1217957
> > > > > 
> > > > > Add quirk for Dell SP2008WFP monitor: 05a9:2641
> > > > > 
> > > > > Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
> > > > > Tested-by: Christopher Townsend <christopher.townsend@canonical.com>
> > > > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > > > Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
> > > > > Cc: linux-media@vger.kernel.org
> > > > > Cc: linux-kernel@vger.kernel.org
> > > > > Cc: stable@vger.kernel.org
> > > > 
> > > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > > 
> > > > I've applied it to my tree. Given that we're too close to the v3.12
> > > > merge window I will push it for v3.13.
> > > 
> > > A quirk has to wait that long?  That's not ok, they should go in much
> > > sooner than that...
> > 
> > Can such a patch get merged during the -rc phase ? If so I will push it to
> > v3.12.
> 
> Yes it can,

OK, I'll send a pull request to Mauro right after the v3.12 merge window 
closes, as he's pretty busy with pending pull requests for v3.12 at the 
moment.

> and it should also be merged to stable releases, as the cc: stable shows.

Sure, that was my plan.

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-08-30 16:44 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <cover.1377781889.git.joseph.salisbury@canonical.com>
2013-08-29 15:17 ` [PATCH 1/1] [media] uvcvideo: quirk PROBE_DEF for Dell SP2008WFP monitor Joseph Salisbury
2013-08-30  0:41   ` Laurent Pinchart
2013-08-30  4:00     ` Greg KH
2013-08-30 10:28       ` Laurent Pinchart
2013-08-30 16:39         ` Greg KH
2013-08-30 16:45           ` Laurent Pinchart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).