* Re: [staging] Staging: Convert uses of compare_ether_addr to ether_addr_equal
[not found] <522395c4.hZ2B3PrpTjC+j1oP%wangshilong1991@gmail.com>
@ 2013-09-01 19:36 ` Joe Perches
2013-09-01 22:58 ` Dan Carpenter
1 sibling, 0 replies; 2+ messages in thread
From: Joe Perches @ 2013-09-01 19:36 UTC (permalink / raw)
To: Wang Shilong; +Cc: LKML, devel, Greg Kroah-Hartman
On Mon, 2013-09-02 at 03:30 +0800, Wang Shilong wrote:
> Hello, Using checkpatch.pl, i get the following warnings(errors):
Hello.
Especially for staging patches, all of these are "don't care"
types of messages.
You should change your script to check if these are existing
warnings and if so, not bother reporting them.
> WARNING: Avoid CamelCase: <pstats->bHwError>
> #124: FILE: drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:1875:
> + (!pstats->bHwError) && (!pstats->bCRC) && (!pstats->bICV));
>
> WARNING: Avoid CamelCase: <pstats->bCRC>
> #124: FILE: drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:1875:
> + (!pstats->bHwError) && (!pstats->bCRC) && (!pstats->bICV));
>
> WARNING: Avoid CamelCase: <pstats->bICV>
> #124: FILE: drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:1875:
> + (!pstats->bHwError) && (!pstats->bCRC) && (!pstats->bICV));
>
> WARNING: line over 80 characters
> #185: FILE: drivers/staging/slicoss/slicoss.c:795:
> + ether_frame->ether_dhost)) {
>
> WARNING: Avoid CamelCase: <pCurrBSS->abyBSSID>
> #207: FILE: drivers/staging/vt6655/bssdb.c:151:
> + if (ether_addr_equal(pCurrBSS->abyBSSID,
>
> WARNING: Avoid CamelCase: <pbyBSSID>
> #208: FILE: drivers/staging/vt6655/bssdb.c:152:
> + pbyBSSID)) {
>
> WARNING: Avoid CamelCase: <pMgmt->sBSSList[ii].abyBSSID>
> #217: FILE: drivers/staging/vt6655/bssdb.c:279:
> + ether_addr_equal(pMgmt->sBSSList[ii].abyBSSID,
>
> WARNING: Avoid CamelCase: <pMgmt->abyCurrBSSID>
> #218: FILE: drivers/staging/vt6655/bssdb.c:280:
> + pMgmt->abyCurrBSSID)) {
>
> WARNING: Avoid CamelCase: <pBSSList->abyBSSID>
> #227: FILE: drivers/staging/vt6655/bssdb.c:323:
> + if (ether_addr_equal(pBSSList->abyBSSID, abyBSSID)) {
>
> WARNING: Avoid CamelCase: <abyBSSID>
> #227: FILE: drivers/staging/vt6655/bssdb.c:323:
> + if (ether_addr_equal(pBSSList->abyBSSID, abyBSSID)) {
>
> WARNING: Avoid CamelCase: <abyDstAddr>
> #236: FILE: drivers/staging/vt6655/bssdb.c:738:
> + if (ether_addr_equal(abyDstAddr,
>
> WARNING: line over 80 characters
> #237: FILE: drivers/staging/vt6655/bssdb.c:739:
> + pMgmt->sNodeDBTable[ii].abyMACAddr)) {
>
> WARNING: Avoid CamelCase: <pMgmt->sNodeDBTable[ii].abyMACAddr>
> #237: FILE: drivers/staging/vt6655/bssdb.c:739:
> + pMgmt->sNodeDBTable[ii].abyMACAddr)) {
>
> WARNING: Avoid CamelCase: <pbyRxBuffer>
> #250: FILE: drivers/staging/vt6655/dpc.c:175:
> + if (ether_addr_equal(pbyRxBuffer, pDevice->abySNAP_Bridgetunnel)) {
>
> WARNING: Avoid CamelCase: <pDevice->abySNAP_Bridgetunnel>
> #250: FILE: drivers/staging/vt6655/dpc.c:175:
> + if (ether_addr_equal(pbyRxBuffer, pDevice->abySNAP_Bridgetunnel)) {
>
> WARNING: Avoid CamelCase: <pDevice->sRxEthHeader.abySrcAddr>
> #262: FILE: drivers/staging/vt6655/dpc.c:423:
> + if (ether_addr_equal(pDevice->sRxEthHeader.abySrcAddr,
>
> WARNING: Avoid CamelCase: <pDevice->abyCurrentNetAddr>
> #263: FILE: drivers/staging/vt6655/dpc.c:424:
> + pDevice->abyCurrentNetAddr))
>
> WARNING: line over 80 characters
> #276: FILE: drivers/staging/vt6655/iwctl.c:666:
> + ether_addr_equal(pMgmt->sBSSList[ii].abyBSSID,
>
> WARNING: Avoid CamelCase: <pMgmt->abyDesireBSSID>
> #277: FILE: drivers/staging/vt6655/iwctl.c:667:
> + pMgmt->abyDesireBSSID)) {
>
> WARNING: line over 80 characters
> #286: FILE: drivers/staging/vt6655/iwctl.c:844:
> + ether_addr_equal(pMgmt->sBSSList[ii].abyBSSID,
>
> WARNING: line over 80 characters
> #287: FILE: drivers/staging/vt6655/iwctl.c:845:
> + pCurr->abyBSSID)) {
>
> WARNING: Avoid CamelCase: <pCurr->abyBSSID>
> #287: FILE: drivers/staging/vt6655/iwctl.c:845:
> + pCurr->abyBSSID)) {
>
> WARNING: Avoid CamelCase: <pTable->KeyTable[i].abyBSSID>
> #300: FILE: drivers/staging/vt6655/key.c:144:
> + ether_addr_equal(pTable->KeyTable[i].abyBSSID, pbyBSSID)) {
>
> WARNING: Avoid CamelCase: <pDevice->abyBSSID>
> #389: FILE: drivers/staging/vt6655/wpactl.c:397:
> + if (ether_addr_equal(param->addr, pDevice->abyBSSID)) {
>
> WARNING: suspect code indent for conditional statements (12, 20)
> #399: FILE: drivers/staging/vt6656/bssdb.c:127:
> if ((pCurrBSS->bActive) &&
> [...]
> + if (ether_addr_equal(pCurrBSS->abyBSSID, pbyBSSID)) {
>
> WARNING: suspect code indent for conditional statements (20, 20)
> #402: FILE: drivers/staging/vt6656/bssdb.c:129:
> + if (ether_addr_equal(pCurrBSS->abyBSSID, pbyBSSID)) {
> if (pSSID != NULL) {
>
> WARNING: suspect code indent for conditional statements (16, 16)
> #422: FILE: drivers/staging/vt6656/bssdb.c:280:
> + if (ether_addr_equal(pBSSList->abyBSSID, abyBSSID)) {
> if (pSSID->len == ((PWLAN_IE_SSID)pBSSList->abySSID)->len){
>
> WARNING: suspect code indent for conditional statements (16, 16)
> #432: FILE: drivers/staging/vt6656/bssdb.c:626:
> + if (ether_addr_equal(abyDstAddr,
> [...]
> *puNodeIndex = ii;
>
> WARNING: please, no spaces at the start of a line
> #446: FILE: drivers/staging/vt6656/dpc.c:139:
> + if (ether_addr_equal(pbyRxBuffer, pDevice->abySNAP_Bridgetunnel)) {$
>
> WARNING: please, no spaces at the start of a line
> #449: FILE: drivers/staging/vt6656/dpc.c:141:
> + } else if (ether_addr_equal(pbyRxBuffer, pDevice->abySNAP_RFC1042)) {$
>
> WARNING: suspect code indent for conditional statements (7, 9)
> #456: FILE: drivers/staging/vt6656/dpc.c:363:
> if (pMgmt->sNodeDBTable[0].bActive) {
> + if (ether_addr_equal(pMgmt->abyCurrBSSID, pMACHeader->addr2)) {
>
> WARNING: suspect code indent for conditional statements (9, 12)
> #458: FILE: drivers/staging/vt6656/dpc.c:364:
> + if (ether_addr_equal(pMgmt->abyCurrBSSID, pMACHeader->addr2)) {
> if (pMgmt->sNodeDBTable[0].uInActiveCount != 0)
>
> WARNING: braces {} are not necessary for single statement blocks
> #468: FILE: drivers/staging/vt6656/dpc.c:377:
> + if (!ether_addr_equal(pDevice->abyCurrentNetAddr, pMACHeader->addr1)) {
> return false;
> }
>
> WARNING: please, no spaces at the start of a line
> #478: FILE: drivers/staging/vt6656/dpc.c:385:
> + if (ether_addr_equal((u8 *)pDevice->sRxEthHeader.h_source,$
>
> WARNING: Avoid CamelCase: <pDevice->sRxEthHeader.h_source>
> #478: FILE: drivers/staging/vt6656/dpc.c:385:
> + if (ether_addr_equal((u8 *)pDevice->sRxEthHeader.h_source,
>
> WARNING: line over 80 characters
> #493: FILE: drivers/staging/vt6656/iwctl.c:660:
> + ether_addr_equal(pMgmt->sBSSList[ii].abyBSSID,
>
> WARNING: line over 80 characters
> #494: FILE: drivers/staging/vt6656/iwctl.c:661:
> + pMgmt->abyDesireBSSID)) {
>
> WARNING: line over 80 characters
> #504: FILE: drivers/staging/vt6656/iwctl.c:843:
> + ether_addr_equal(pMgmt->sBSSList[ii].abyBSSID,
>
> WARNING: line over 80 characters
> #505: FILE: drivers/staging/vt6656/iwctl.c:844:
> + pCurr->abyBSSID)) {
>
> total: 0 errors, 39 warnings, 400 lines checked
>
> patch has style problems, please review.
>
> If any of these errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
> Thanks, Wang
>
> Notice: this is an automatically generated by shell script
> Any problems please contact: wangshilong1991@gmail.com
>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [staging] Staging: Convert uses of compare_ether_addr to ether_addr_equal
[not found] <522395c4.hZ2B3PrpTjC+j1oP%wangshilong1991@gmail.com>
2013-09-01 19:36 ` [staging] Staging: Convert uses of compare_ether_addr to ether_addr_equal Joe Perches
@ 2013-09-01 22:58 ` Dan Carpenter
1 sibling, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2013-09-01 22:58 UTC (permalink / raw)
To: Wang Shilong; +Cc: Joe Perches, devel, Greg Kroah-Hartman, Forest Bond, LKML
On Mon, Sep 02, 2013 at 03:30:12AM +0800, Wang Shilong wrote:
> Hello, Using checkpatch.pl, i get the following warnings(errors):
All of these were there in the original code.
Have your script copy the messages to your postponed messages folder and
then look over the output before mailing it.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-01 22:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <522395c4.hZ2B3PrpTjC+j1oP%wangshilong1991@gmail.com>
2013-09-01 19:36 ` [staging] Staging: Convert uses of compare_ether_addr to ether_addr_equal Joe Perches
2013-09-01 22:58 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).