* ARM: OMAP2: Make MACH_OMAP3EVM select NOP_USB_XCEIV
@ 2013-09-04 13:38 Josh Boyer
2013-09-17 23:40 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Josh Boyer @ 2013-09-04 13:38 UTC (permalink / raw)
To: Tony Lindgren, Olof Johansson
Cc: linux-arm-kernel, Russell King, linux-omap, linux-kernel
The board-omap3evm.c file unconditionally calls usb_nop_xceiv_register but
doesn't ensure this is built-in. This can lead to build failures like:
arch/arm/mach-omap2/built-in.o: In function `omap3_evm_init':
linux-3.12.0-0.rc0.git2.1.fc21.armv7hl/arch/arm/mach-omap2/board-omap3evm.c:686: undefined reference to `usb_nop_xceiv_register'
make: *** [vmlinux] Error 1
Make MACH_OMAP3EVM select NOP_USB_XCEIV to avoid this.
Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
---
arch/arm/mach-omap2/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index 3eed000..3350389 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -258,6 +258,7 @@ config MACH_OMAP3EVM
depends on ARCH_OMAP3
default y
select OMAP_PACKAGE_CBB
+ select NOP_USB_XCEIV
config MACH_OMAP3517EVM
bool "OMAP3517/ AM3517 EVM board"
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: ARM: OMAP2: Make MACH_OMAP3EVM select NOP_USB_XCEIV
2013-09-04 13:38 ARM: OMAP2: Make MACH_OMAP3EVM select NOP_USB_XCEIV Josh Boyer
@ 2013-09-17 23:40 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2013-09-17 23:40 UTC (permalink / raw)
To: Josh Boyer
Cc: Olof Johansson, linux-arm-kernel, Russell King, linux-omap, linux-kernel
* Josh Boyer <jwboyer@redhat.com> [130904 06:46]:
> The board-omap3evm.c file unconditionally calls usb_nop_xceiv_register but
> doesn't ensure this is built-in. This can lead to build failures like:
>
> arch/arm/mach-omap2/built-in.o: In function `omap3_evm_init':
> linux-3.12.0-0.rc0.git2.1.fc21.armv7hl/arch/arm/mach-omap2/board-omap3evm.c:686: undefined reference to `usb_nop_xceiv_register'
> make: *** [vmlinux] Error 1
>
> Make MACH_OMAP3EVM select NOP_USB_XCEIV to avoid this.
>
> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
> ---
> arch/arm/mach-omap2/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 3eed000..3350389 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -258,6 +258,7 @@ config MACH_OMAP3EVM
> depends on ARCH_OMAP3
> default y
> select OMAP_PACKAGE_CBB
> + select NOP_USB_XCEIV
>
> config MACH_OMAP3517EVM
> bool "OMAP3517/ AM3517 EVM board"
I think we should rather have the code in board-omap3evm.c
to be ifdef CONFIG_NOP_USB_XCEIV as it's a selectable option.
Regards,
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-17 23:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-04 13:38 ARM: OMAP2: Make MACH_OMAP3EVM select NOP_USB_XCEIV Josh Boyer
2013-09-17 23:40 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).