* [PATCH] ASoC: blackfin: Add missing break statement to bf6xx
@ 2013-09-13 23:20 Valentin Ilie
2013-09-16 23:47 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Valentin Ilie @ 2013-09-13 23:20 UTC (permalink / raw)
To: perex, tiwai, lgirdwood, broonie
Cc: uclinux-dist-devel, alsa-devel, linux-kernel, Valentin Ilie
SNDRV_PCM_FORMAT_S8 isn't supposed to fall through to SNDRV_PCM_FORMAT_S16_LE
Signed-off-by: Valentin Ilie <valentin.ilie@gmail.com>
---
sound/soc/blackfin/bf6xx-i2s.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/blackfin/bf6xx-i2s.c b/sound/soc/blackfin/bf6xx-i2s.c
index c02405c..5810a06 100644
--- a/sound/soc/blackfin/bf6xx-i2s.c
+++ b/sound/soc/blackfin/bf6xx-i2s.c
@@ -88,6 +88,7 @@ static int bfin_i2s_hw_params(struct snd_pcm_substream *substream,
case SNDRV_PCM_FORMAT_S8:
param.spctl |= 0x70;
sport->wdsize = 1;
+ break;
case SNDRV_PCM_FORMAT_S16_LE:
param.spctl |= 0xf0;
sport->wdsize = 2;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: blackfin: Add missing break statement to bf6xx
2013-09-13 23:20 [PATCH] ASoC: blackfin: Add missing break statement to bf6xx Valentin Ilie
@ 2013-09-16 23:47 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-09-16 23:47 UTC (permalink / raw)
To: Valentin Ilie
Cc: perex, tiwai, lgirdwood, uclinux-dist-devel, alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 227 bytes --]
On Sat, Sep 14, 2013 at 02:20:37AM +0300, Valentin Ilie wrote:
> SNDRV_PCM_FORMAT_S8 isn't supposed to fall through to SNDRV_PCM_FORMAT_S16_LE
>
> Signed-off-by: Valentin Ilie <valentin.ilie@gmail.com>
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-16 23:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-13 23:20 [PATCH] ASoC: blackfin: Add missing break statement to bf6xx Valentin Ilie
2013-09-16 23:47 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).