linux-next: build failure after merge of the final tree (char-misc tree related)

linux-next: build failure after merge of the final tree (char-misc tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 9164 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/misc/mic/card/mic_x100.c: In function 'mic_init':
drivers/misc/mic/card/mic_x100.c:215:9: error: implicit declaration of function 'cpu_data' [-Werror=implicit-function-declaration]
  struct cpuinfo_x86 *c = &cpu_data(0);
         ^
drivers/misc/mic/card/mic_x100.c:215:26: error: lvalue required as unary '&' operand
  struct cpuinfo_x86 *c = &cpu_data(0);
                          ^
drivers/misc/mic/card/mic_x100.c:217:9: error: dereferencing pointer to incomplete type
  if (!(c->x86 == 11 && c->x86_model == 1)) {
         ^
drivers/misc/mic/card/mic_x100.c:217:25: error: dereferencing pointer to incomplete type
  if (!(c->x86 == 11 && c->x86_model == 1)) {
                         ^
In file included from drivers/misc/mic/host/mic_device.h:27:0,
                 from drivers/misc/mic/host/mic_boot.c:26:
drivers/misc/mic/host/mic_intr.h:134:58: warning: 'struct pci_dev' declared inside parameter list [enabled by default]
 int mic_setup_interrupts(struct mic_device *mdev, struct pci_dev *pdev);
                                                          ^
drivers/misc/mic/host/mic_intr.h:134:58: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
drivers/misc/mic/host/mic_intr.h:135:58: warning: 'struct pci_dev' declared inside parameter list [enabled by default]
 void mic_free_interrupts(struct mic_device *mdev, struct pci_dev *pdev);
                                                          ^
In file included from drivers/misc/mic/host/mic_boot.c:26:0:
drivers/misc/mic/host/mic_device.h: In function 'mic_mmio_read':
drivers/misc/mic/host/mic_device.h:164:2: error: implicit declaration of function 'ioread32' [-Werror=implicit-function-declaration]
  return ioread32(mw->va + offset);
  ^
drivers/misc/mic/host/mic_device.h: In function 'mic_mmio_write':
drivers/misc/mic/host/mic_device.h:178:2: error: implicit declaration of function 'iowrite32' [-Werror=implicit-function-declaration]
  iowrite32(val, mw->va + offset);
  ^
In file included from arch/powerpc/include/asm/io.h:37:0,
                 from arch/powerpc/include/asm/dma.h:21,
                 from arch/powerpc/include/asm/scatterlist.h:12,
                 from include/linux/scatterlist.h:9,
                 from include/linux/virtio.h:6,
                 from include/linux/virtio_config.h:6,
                 from drivers/misc/mic/host/mic_virtio.h:24,
                 from drivers/misc/mic/host/mic_boot.c:28:
include/asm-generic/iomap.h: At top level:
include/asm-generic/iomap.h:31:21: error: conflicting types for 'ioread32'
 extern unsigned int ioread32(void __iomem *);
                     ^
In file included from drivers/misc/mic/host/mic_boot.c:26:0:
drivers/misc/mic/host/mic_device.h:164:9: note: previous implicit declaration of 'ioread32' was here
  return ioread32(mw->va + offset);
         ^
In file included from arch/powerpc/include/asm/io.h:37:0,
                 from arch/powerpc/include/asm/dma.h:21,
                 from arch/powerpc/include/asm/scatterlist.h:12,
                 from include/linux/scatterlist.h:9,
                 from include/linux/virtio.h:6,
                 from include/linux/virtio_config.h:6,
                 from drivers/misc/mic/host/mic_virtio.h:24,
                 from drivers/misc/mic/host/mic_boot.c:28:
include/asm-generic/iomap.h:37:13: warning: conflicting types for 'iowrite32' [enabled by default]
 extern void iowrite32(u32, void __iomem *);
             ^
In file included from drivers/misc/mic/host/mic_boot.c:26:0:
drivers/misc/mic/host/mic_device.h:178:2: note: previous implicit declaration of 'iowrite32' was here
  iowrite32(val, mw->va + offset);
  ^
drivers/misc/mic/host/mic_x100.c: In function 'mic_x100_load_ramdisk':
drivers/misc/mic/host/mic_x100.c:402:49: error: dereferencing pointer to incomplete type
  iowrite32(cpu_to_le32(mdev->bootaddr << 1), &bp->hdr.ramdisk_image);
                                                 ^
drivers/misc/mic/host/mic_x100.c:403:38: error: dereferencing pointer to incomplete type
  iowrite32(cpu_to_le32(fw->size), &bp->hdr.ramdisk_size);
                                      ^
drivers/misc/mic/host/mic_debugfs.c: In function 'mic_log_buf_show':
drivers/misc/mic/host/mic_debugfs.c:55:51: error: '__START_KERNEL_map' undeclared (first use in this function)
  aper_offset = (unsigned long)mdev->log_buf_len - __START_KERNEL_map;
                                                   ^
drivers/misc/mic/host/mic_debugfs.c:55:51: note: each undeclared identifier is reported only once for each function it appears in
In file included from drivers/misc/mic/host/mic_device.h:27:0,
                 from drivers/misc/mic/host/mic_fops.c:25:
drivers/misc/mic/host/mic_intr.h:134:58: warning: 'struct pci_dev' declared inside parameter list [enabled by default]
 int mic_setup_interrupts(struct mic_device *mdev, struct pci_dev *pdev);
                                                          ^
drivers/misc/mic/host/mic_intr.h:134:58: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
drivers/misc/mic/host/mic_intr.h:135:58: warning: 'struct pci_dev' declared inside parameter list [enabled by default]
 void mic_free_interrupts(struct mic_device *mdev, struct pci_dev *pdev);
                                                          ^
In file included from drivers/misc/mic/host/mic_fops.c:25:0:
drivers/misc/mic/host/mic_device.h: In function 'mic_mmio_read':
drivers/misc/mic/host/mic_device.h:164:2: error: implicit declaration of function 'ioread32' [-Werror=implicit-function-declaration]
  return ioread32(mw->va + offset);
  ^
drivers/misc/mic/host/mic_device.h: In function 'mic_mmio_write':
drivers/misc/mic/host/mic_device.h:178:2: error: implicit declaration of function 'iowrite32' [-Werror=implicit-function-declaration]
  iowrite32(val, mw->va + offset);
  ^
make[5]: *** [drivers/misc/mic/host/mic_debugfs.o] Error 1
In file included from arch/powerpc/include/asm/io.h:37:0,
                 from arch/powerpc/include/asm/dma.h:21,
                 from arch/powerpc/include/asm/scatterlist.h:12,
                 from include/linux/scatterlist.h:9,
                 from include/linux/virtio.h:6,
                 from include/linux/virtio_config.h:6,
                 from drivers/misc/mic/host/mic_virtio.h:24,
                 from drivers/misc/mic/host/mic_fops.c:27:
include/asm-generic/iomap.h: At top level:
include/asm-generic/iomap.h:31:21: error: conflicting types for 'ioread32'
 extern unsigned int ioread32(void __iomem *);
                     ^
In file included from drivers/misc/mic/host/mic_fops.c:25:0:
drivers/misc/mic/host/mic_device.h:164:9: note: previous implicit declaration of 'ioread32' was here
  return ioread32(mw->va + offset);
         ^
In file included from arch/powerpc/include/asm/io.h:37:0,
                 from arch/powerpc/include/asm/dma.h:21,
                 from arch/powerpc/include/asm/scatterlist.h:12,
                 from include/linux/scatterlist.h:9,
                 from include/linux/virtio.h:6,
                 from include/linux/virtio_config.h:6,
                 from drivers/misc/mic/host/mic_virtio.h:24,
                 from drivers/misc/mic/host/mic_fops.c:27:
include/asm-generic/iomap.h:37:13: warning: conflicting types for 'iowrite32' [enabled by default]
 extern void iowrite32(u32, void __iomem *);
             ^
In file included from drivers/misc/mic/host/mic_fops.c:25:0:
drivers/misc/mic/host/mic_device.h:178:2: note: previous implicit declaration of 'iowrite32' was here
  iowrite32(val, mw->va + offset);
  ^

I assume all that is the result of commit aa27badd8972 ("Intel MIC Card
Driver for X100 family") from the char-misc tree.

I have disabled that driver for today (that commit did not revert
cleanly):

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 27 Sep 2013 18:38:55 +1000
Subject: [PATCH] disable broken Intel MIC Card Driver for X100 family for now

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/misc/mic/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/misc/mic/Kconfig b/drivers/misc/mic/Kconfig
index d453768..aa9805a 100644
--- a/drivers/misc/mic/Kconfig
+++ b/drivers/misc/mic/Kconfig
@@ -5,6 +5,7 @@ config INTEL_MIC_HOST
 	depends on 64BIT && PCI
 	select VHOST_RING
 	default N
+	depends on BROKEN
 	help
 	  This enables Host Driver support for the Intel Many Integrated
 	  Core (MIC) family of PCIe form factor coprocessor devices that
@@ -26,6 +27,7 @@ config INTEL_MIC_CARD
 	depends on 64BIT
 	select VIRTIO
 	default N
+	depends on BROKEN
 	help
 	  This enables card driver support for the Intel Many Integrated
 	  Core (MIC) device family. The card driver communicates shutdown/
-- 
1.8.4.rc3

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build failure after merge of the final tree (char-misc tree related)

[Greg KH]

On Fri, Sep 27, 2013 at 06:48:04PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/misc/mic/card/mic_x100.c: In function 'mic_init':
> drivers/misc/mic/card/mic_x100.c:215:9: error: implicit declaration of function 'cpu_data' [-Werror=implicit-function-declaration]
>   struct cpuinfo_x86 *c = &cpu_data(0);
>          ^

<snip>

Should now be fixed, thanks.

greg k-h

linux-next: build failure after merge of the final tree (char-misc tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1688 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/iio/adc/men_z188_adc.c: In function 'z188_iio_read_raw':
drivers/iio/adc/men_z188_adc.c:61:3: error: implicit declaration of function 'readw' [-Werror=implicit-function-declaration]
   tmp = readw(adc->base + chan->channel * 4);
   ^
drivers/iio/adc/men_z188_adc.c: In function 'men_z188_config_channels':
drivers/iio/adc/men_z188_adc.c:91:2: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
  ctl = readl(addr + Z188_CTRL_REG);
  ^
drivers/iio/adc/men_z188_adc.c:93:2: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration]
  writel(ctl, addr + Z188_CTRL_REG);
  ^
drivers/iio/adc/men_z188_adc.c: In function 'men_z188_probe':
drivers/iio/adc/men_z188_adc.c:126:2: error: implicit declaration of function 'ioremap' [-Werror=implicit-function-declaration]
  adc->base = ioremap(mem->start, resource_size(mem));
  ^
drivers/iio/adc/men_z188_adc.c:126:12: warning: assignment makes pointer from integer without a cast [enabled by default]
  adc->base = ioremap(mem->start, resource_size(mem));
            ^
drivers/iio/adc/men_z188_adc.c: In function 'men_z188_remove':
drivers/iio/adc/men_z188_adc.c:148:2: error: implicit declaration of function 'iounmap' [-Werror=implicit-function-declaration]
  iounmap(adc->base);
  ^

Caused by commit 74aeac4da66f ("iio: adc: Add MEN 16z188 ADC driver")
from the char-misc tree.  Need to include linux/io.h, I think.

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

linux-next: build failure after merge of the final tree (char-misc tree related)

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 915 bytes --]

Hi all,

After merging the final tree, today's linux-next build (arm defconfig)
failed like this:

drivers/mcb/mcb-pci.c: At top level:
drivers/mcb/mcb-pci.c:110:1: warning: data definition has no type or storage class [enabled by default]
drivers/mcb/mcb-pci.c:110:1: error: type defaults to 'int' in declaration of 'module_pci_driver' [-Werror=implicit-int]
drivers/mcb/mcb-pci.c:110:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/mcb/mcb-pci.c:103:26: warning: 'mcb_pci_driver' defined but not used [-Wunused-variable]

Caused by commit b71bb8639891 ("mcb: Add PCI carrier for MEN Chameleon
Bus") from the char-misc tree.  module_pci_driver is defined in
linux/pci.h only if CONFIG_PCI is defined (which is not true for this
build).

I have reverted that commit for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]