* [PATCH] drivers: staging: bcm: Removed a developer debug statement.
@ 2013-10-23 19:11 Chuong Ngo
2013-10-23 22:02 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Chuong Ngo @ 2013-10-23 19:11 UTC (permalink / raw)
To: gregkh, klmckinney1, dan.carpenter; +Cc: devel, linux-kernel, Chuong Ngo
Removed a developer debug statement per the TODO list. Additionally, removed braces for the if-statement to match coding style.
Signed-off-by: Chuong Ngo <cngo.github@gmail.com>
---
drivers/staging/bcm/Bcmchar.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index f91bc1f..41554c8 100644
--- a/drivers/staging/bcm/Bcmchar.c
+++ b/drivers/staging/bcm/Bcmchar.c
@@ -49,11 +49,8 @@ static int bcm_char_release(struct inode *inode, struct file *filp)
pTarang = (struct bcm_tarang_data *)filp->private_data;
- if (pTarang == NULL) {
- BCM_DEBUG_PRINT(Adapter, DBG_TYPE_PRINTK, 0, 0,
- "ptarang is null\n");
+ if (pTarang == NULL)
return 0;
- }
Adapter = pTarang->Adapter;
--
1.8.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: staging: bcm: Removed a developer debug statement.
2013-10-23 19:11 [PATCH] drivers: staging: bcm: Removed a developer debug statement Chuong Ngo
@ 2013-10-23 22:02 ` Dan Carpenter
2013-10-29 15:50 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2013-10-23 22:02 UTC (permalink / raw)
To: Chuong Ngo; +Cc: gregkh, klmckinney1, devel, linux-kernel
On Wed, Oct 23, 2013 at 03:11:20PM -0400, Chuong Ngo wrote:
> Removed a developer debug statement per the TODO list. Additionally, removed braces for the if-statement to match coding style.
Line wrap the changelog at 72 characters. You don't really need to
mention the removed braces because that's too obvious to bother
commenting on.
My guess is that Greg will probably be willing to apply this as is so
don't worry about resending unless he requests it. (He normally seems
to let newbies get by with one line wrapping warning before he starts
making you redo it).
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: staging: bcm: Removed a developer debug statement.
2013-10-23 22:02 ` Dan Carpenter
@ 2013-10-29 15:50 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2013-10-29 15:50 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Chuong Ngo, devel, linux-kernel
On Thu, Oct 24, 2013 at 01:02:45AM +0300, Dan Carpenter wrote:
> On Wed, Oct 23, 2013 at 03:11:20PM -0400, Chuong Ngo wrote:
> > Removed a developer debug statement per the TODO list. Additionally, removed braces for the if-statement to match coding style.
>
> Line wrap the changelog at 72 characters. You don't really need to
> mention the removed braces because that's too obvious to bother
> commenting on.
>
> My guess is that Greg will probably be willing to apply this as is so
> don't worry about resending unless he requests it. (He normally seems
> to let newbies get by with one line wrapping warning before he starts
> making you redo it).
Yes, I'll fix it this time, but Chuong, please be more careful next
time.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-10-29 15:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-23 19:11 [PATCH] drivers: staging: bcm: Removed a developer debug statement Chuong Ngo
2013-10-23 22:02 ` Dan Carpenter
2013-10-29 15:50 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).