From: Jiri Olsa <jolsa@redhat.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: linux-kernel@vger.kernel.org,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Namhyung Kim <namhyung@kernel.org>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>
Subject: [PATCH] perf tools: Add missing data.h into LIB_H headers
Date: Sat, 26 Oct 2013 20:53:14 +0200 [thread overview]
Message-ID: <20131026185314.GA14973@krava.brq.redhat.com> (raw)
In-Reply-To: <52676DFC.9030402@intel.com>
On Wed, Oct 23, 2013 at 09:34:36AM +0300, Adrian Hunter wrote:
> On 15/10/13 17:27, Jiri Olsa wrote:
> > Adding perf_data_file__open interface to data object
> > to open the perf.data file for both read and write.
> >
> > Signed-off-by: Jiri Olsa <jolsa@redhat.com>
> > Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
> > Cc: Frederic Weisbecker <fweisbec@gmail.com>
> > Cc: Ingo Molnar <mingo@elte.hu>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Cc: Paul Mackerras <paulus@samba.org>
> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> > Cc: David Ahern <dsahern@gmail.com>
> > Cc: Adrian Hunter <adrian.hunter@intel.com>
> > Cc: Andi Kleen <andi@firstfloor.org>
> > ---
> > tools/perf/Makefile.perf | 1 +
> > tools/perf/builtin-record.c | 34 +------------
> > tools/perf/builtin-top.c | 9 +---
> > tools/perf/util/data.c | 120 ++++++++++++++++++++++++++++++++++++++++++++
> > tools/perf/util/data.h | 4 ++
> > tools/perf/util/session.c | 95 +++++++++++------------------------
> > tools/perf/util/session.h | 2 +-
> > 7 files changed, 158 insertions(+), 107 deletions(-)
> > create mode 100644 tools/perf/util/data.c
> >
> > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> > index c873e03..326a26e 100644
> > --- a/tools/perf/Makefile.perf
> > +++ b/tools/perf/Makefile.perf
> > @@ -365,6 +365,7 @@ LIB_OBJS += $(OUTPUT)util/vdso.o
> > LIB_OBJS += $(OUTPUT)util/stat.o
> > LIB_OBJS += $(OUTPUT)util/record.o
> > LIB_OBJS += $(OUTPUT)util/srcline.o
> > +LIB_OBJS += $(OUTPUT)util/data.o
>
> Also needs:
>
> LIB_H += util/data.h
>
oops, I knew I forgot something.. patch is attached
thanks,
jirka
---
Adding missing data.h into LIB_H headers so the build
could keep up with its changes.
Reported-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
---
tools/perf/Makefile.perf | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
index 8a9ca38..bc7cfa1 100644
--- a/tools/perf/Makefile.perf
+++ b/tools/perf/Makefile.perf
@@ -295,6 +295,7 @@ LIB_H += ui/helpline.h
LIB_H += ui/progress.h
LIB_H += ui/util.h
LIB_H += ui/ui.h
+LIB_H += util/data.h
LIB_OBJS += $(OUTPUT)util/abspath.o
LIB_OBJS += $(OUTPUT)util/alias.o
--
1.7.11.7
next prev parent reply other threads:[~2013-10-26 18:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1381847254-28809-1-git-send-email-jolsa@redhat.com>
2013-10-15 14:27 ` [PATCH 1/3] perf tools: Add data object to handle perf data file Jiri Olsa
2013-10-16 2:48 ` Namhyung Kim
2013-10-16 8:47 ` Jiri Olsa
2013-10-23 7:55 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-10-15 14:27 ` [PATCH 2/3] perf tools: Add perf_data_file__open interface to data object Jiri Olsa
2013-10-23 6:34 ` Adrian Hunter
2013-10-26 18:53 ` Jiri Olsa [this message]
2013-11-04 20:19 ` [tip:perf/core] perf tools: Add missing data.h into LIB_H headers tip-bot for Jiri Olsa
2013-10-23 7:55 ` [tip:perf/core] perf tools: Add perf_data_file__open interface to data object tip-bot for Jiri Olsa
2013-10-15 14:27 ` [PATCH 3/3] perf tools: Separating data file properties from session Jiri Olsa
2013-10-23 7:55 ` [tip:perf/core] perf session: " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131026185314.GA14973@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=andi@firstfloor.org \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).