From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
David Ahern <dsahern@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH 1/3] perf tools: Add data object to handle perf data file
Date: Wed, 16 Oct 2013 11:48:07 +0900 [thread overview]
Message-ID: <87a9ia9biw.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <1381847254-28809-2-git-send-email-jolsa@redhat.com> (Jiri Olsa's message of "Tue, 15 Oct 2013 16:27:32 +0200")
Hi Jiri,
On Tue, 15 Oct 2013 16:27:32 +0200, Jiri Olsa wrote:
> This patch is adding 'struct perf_data_file' object as
> a placeholder for all attributes regarding perf.data
> file handling. Changing perf_session__new to take it
> as an argument.
>
> The rest of the functionality will be added later to keep
> this change simple enough, because all the places using
> perf_session are changed now.
All three look good.
Btw, are you planning to support multiple per-cpu file record? As you
know I suggested perf.data.dir approach in my perf-ftrace patchset (I'll
resend a new version soonish) something like below. What do you think?
perf.data.dir/
|-- perf-cpu0.data
|-- perf-cpu1.data
|-- perf-cpu2.data
`-- perf-cpu3.data
Maybe we could split sample data and other data (e.g. COMM, MMAP or some
user data?) to another file(s).
Thanks,
Namhyung
next prev parent reply other threads:[~2013-10-16 2:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1381847254-28809-1-git-send-email-jolsa@redhat.com>
2013-10-15 14:27 ` [PATCH 1/3] perf tools: Add data object to handle perf data file Jiri Olsa
2013-10-16 2:48 ` Namhyung Kim [this message]
2013-10-16 8:47 ` Jiri Olsa
2013-10-23 7:55 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-10-15 14:27 ` [PATCH 2/3] perf tools: Add perf_data_file__open interface to data object Jiri Olsa
2013-10-23 6:34 ` Adrian Hunter
2013-10-26 18:53 ` [PATCH] perf tools: Add missing data.h into LIB_H headers Jiri Olsa
2013-11-04 20:19 ` [tip:perf/core] " tip-bot for Jiri Olsa
2013-10-23 7:55 ` [tip:perf/core] perf tools: Add perf_data_file__open interface to data object tip-bot for Jiri Olsa
2013-10-15 14:27 ` [PATCH 3/3] perf tools: Separating data file properties from session Jiri Olsa
2013-10-23 7:55 ` [tip:perf/core] perf session: " tip-bot for Jiri Olsa
2013-10-07 9:31 [PATCH 0/3] perf tools: Factor perf data handling Jiri Olsa
2013-10-07 9:31 ` [PATCH 1/3] perf tools: Add data object to handle perf data file Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a9ia9biw.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=andi@firstfloor.org \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).