[PATCH 0/5] percpu_ida: Various tweaks

[PATCH 0/5] percpu_ida: Various tweaks

[Alexander Gordeev]

Hi Kent,

Here is an update of few behaviours which caught my eye.
I have not tested any, so it is up to your judgement ;)

Alexander Gordeev (5):
  percpu_ida: Fix data race on cpus_have_tags cpumask
  percpu_ida: Move waking up waiters out of atomic contexts
  percpu_ida: Optimize freeing tags when maximum cache size is 1
  percpu_ida: Sanity check initialization parameters
  percpu_ida: Allow variable maximum number of cached tags

 block/blk-mq-tag.c         |    9 +++++----
 include/linux/percpu_ida.h |    5 +++--
 lib/percpu_ida.c           |   38 ++++++++++++++++++++++++++++----------
 3 files changed, 36 insertions(+), 16 deletions(-)

-- 
1.7.7.6


-- 
Regards,
Alexander Gordeev
agordeev@redhat.com

Re: [PATCH 0/5] percpu_ida: Various tweaks

[Kent Overstreet]

On Mon, Oct 28, 2013 at 11:04:44AM +0100, Alexander Gordeev wrote:
> Hi Kent,
> 
> Here is an update of few behaviours which caught my eye.
> I have not tested any, so it is up to your judgement ;)
> 
> Alexander Gordeev (5):
>   percpu_ida: Fix data race on cpus_have_tags cpumask
>   percpu_ida: Move waking up waiters out of atomic contexts
>   percpu_ida: Optimize freeing tags when maximum cache size is 1
>   percpu_ida: Sanity check initialization parameters
>   percpu_ida: Allow variable maximum number of cached tags
> 
>  block/blk-mq-tag.c         |    9 +++++----
>  include/linux/percpu_ida.h |    5 +++--
>  lib/percpu_ida.c           |   38 ++++++++++++++++++++++++++++----------
>  3 files changed, 36 insertions(+), 16 deletions(-)

What tree is this series based on? Patch 3 is based on something not in
mainline.

Re: [PATCH 0/5] percpu_ida: Various tweaks

[Nicholas A. Bellinger]

On Mon, 2013-10-28 at 11:04 +0100, Alexander Gordeev wrote:
> Hi Kent,
> 
> Here is an update of few behaviours which caught my eye.
> I have not tested any, so it is up to your judgement ;)
> 
> Alexander Gordeev (5):
>   percpu_ida: Fix data race on cpus_have_tags cpumask
>   percpu_ida: Move waking up waiters out of atomic contexts
>   percpu_ida: Optimize freeing tags when maximum cache size is 1
>   percpu_ida: Sanity check initialization parameters
>   percpu_ida: Allow variable maximum number of cached tags
> 
>  block/blk-mq-tag.c         |    9 +++++----
>  include/linux/percpu_ida.h |    5 +++--
>  lib/percpu_ida.c           |   38 ++++++++++++++++++++++++++++----------
>  3 files changed, 36 insertions(+), 16 deletions(-)
> 

Hi Alexander,

So this series is atop Shaohua's conversion blk-mq patch to use
percpu_ida, right..?

I'll wait for Kent's feedback on these, and end-up dropping the
blk-mq-tag part from Patch #5 for the moment..

--nab

Re: [PATCH 0/5] percpu_ida: Various tweaks

[Alexander Gordeev]

On Mon, Oct 28, 2013 at 02:23:52PM -0700, Kent Overstreet wrote:
> What tree is this series based on? Patch 3 is based on something not in
> mainline.

This is against the Jens's tree:
git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git

Sorry for missing to note right away.

-- 
Regards,
Alexander Gordeev
agordeev@redhat.com

Re: [PATCH 0/5] percpu_ida: Various tweaks

[Alexander Gordeev]

On Mon, Oct 28, 2013 at 02:29:06PM -0700, Nicholas A. Bellinger wrote:

Hi Nicholas,

> So this series is atop Shaohua's conversion blk-mq patch to use
> percpu_ida, right..?

Yep.

> I'll wait for Kent's feedback on these, and end-up dropping the
> blk-mq-tag part from Patch #5 for the moment..

Yeah, looking forward to try AHCI with percpu_ida.

> --nab

-- 
Regards,
Alexander Gordeev
agordeev@redhat.com

Re: [PATCH 0/5] percpu_ida: Various tweaks

[Alexander Gordeev]

On Mon, Oct 28, 2013 at 02:29:06PM -0700, Nicholas A. Bellinger wrote:
> I'll wait for Kent's feedback on these, and end-up dropping the
> blk-mq-tag part from Patch #5 for the moment..

Hi Nicholas,

I am bit uncertain regarding the process concerning your and Jens trees.
Are you planning to pull Shaohua's percpu_ida conversion?

Thanks!

> --nab

-- 
Regards,
Alexander Gordeev
agordeev@redhat.com

Re: [PATCH 0/5] percpu_ida: Various tweaks

[Jens Axboe]

On Mon, Nov 11 2013, Alexander Gordeev wrote:
> On Mon, Oct 28, 2013 at 02:29:06PM -0700, Nicholas A. Bellinger wrote:
> > I'll wait for Kent's feedback on these, and end-up dropping the
> > blk-mq-tag part from Patch #5 for the moment..
> 
> Hi Nicholas,
> 
> I am bit uncertain regarding the process concerning your and Jens trees.
> Are you planning to pull Shaohua's percpu_ida conversion?

The submitted blk-mq bits have the conversion, the old tagging is no
longer active/maintained. So any work on this going forward will have to
be based on the percpu ida conversion.

-- 
Jens Axboe

Re: [PATCH 0/5] percpu_ida: Various tweaks

[Nicholas A. Bellinger]

On Mon, 2013-11-11 at 12:39 -0700, Jens Axboe wrote:
> On Mon, Nov 11 2013, Alexander Gordeev wrote:
> > On Mon, Oct 28, 2013 at 02:29:06PM -0700, Nicholas A. Bellinger wrote:
> > > I'll wait for Kent's feedback on these, and end-up dropping the
> > > blk-mq-tag part from Patch #5 for the moment..
> > 
> > Hi Nicholas,
> > 
> > I am bit uncertain regarding the process concerning your and Jens trees.
> > Are you planning to pull Shaohua's percpu_ida conversion?
> 
> The submitted blk-mq bits have the conversion, the old tagging is no
> longer active/maintained. So any work on this going forward will have to
> be based on the percpu ida conversion.
> 

What Jen's said..

I'll be updating the scsi-mq working branch soon after blk-mq is pulled
into v3.13-rc1 code.

--nab

Re: [PATCH 0/5] percpu_ida: Various tweaks

[Jens Axboe]

On 11/11/2013, at 14.20, "Nicholas A. Bellinger" <nab@linux-iscsi.org> wrote:
> 
>> On Mon, 2013-11-11 at 12:39 -0700, Jens Axboe wrote:
>>> On Mon, Nov 11 2013, Alexander Gordeev wrote:
>>>> On Mon, Oct 28, 2013 at 02:29:06PM -0700, Nicholas A. Bellinger wrote:
>>>> I'll wait for Kent's feedback on these, and end-up dropping the
>>>> blk-mq-tag part from Patch #5 for the moment..
>>> 
>>> Hi Nicholas,
>>> 
>>> I am bit uncertain regarding the process concerning your and Jens trees.
>>> Are you planning to pull Shaohua's percpu_ida conversion?
>> 
>> The submitted blk-mq bits have the conversion, the old tagging is no
>> longer active/maintained. So any work on this going forward will have to
>> be based on the percpu ida conversion.
> 
> What Jen's said..

I'm going to start calling you Nick, if you keep misspelling my name. 

Jens

Re: [PATCH 0/5] percpu_ida: Various tweaks

[Alexander Gordeev]

On Mon, Oct 28, 2013 at 11:04:44AM +0100, Alexander Gordeev wrote:
> Here is an update of few behaviours which caught my eye.
> I have not tested any, so it is up to your judgement ;)

Hi Kent et al.

Can we go ahead with this series?

Thanks!

-- 
Regards,
Alexander Gordeev
agordeev@redhat.com

Re: [PATCH 0/5] percpu_ida: Various tweaks

[Kent Overstreet]

On Tue, Jan 14, 2014 at 12:41:53PM +0100, Alexander Gordeev wrote:
> On Mon, Oct 28, 2013 at 11:04:44AM +0100, Alexander Gordeev wrote:
> > Here is an update of few behaviours which caught my eye.
> > I have not tested any, so it is up to your judgement ;)
> 
> Hi Kent et al.
> 
> Can we go ahead with this series?

I must've seen it at some point, but I can't find this patch series anywhere.
Can you resend it to me?