* [PATCH] PCI: mvebu: staticize mvebu_pcie_align_resource
@ 2013-11-07 9:05 Jisheng Zhang
2013-11-07 9:11 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Jisheng Zhang @ 2013-11-07 9:05 UTC (permalink / raw)
To: bhelgaas, thomas.petazzoni, jason, ezequiel.garcia
Cc: linux-pci, linux-kernel, Jisheng Zhang
This patch fixes the following sparse warning:
drivers/pci/host/pci-mvebu.c:676:17: warning: symbol
'mvebu_pcie_align_resource' was not declared. Should it be static?
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
drivers/pci/host/pci-mvebu.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c
index 729d5a1..bf4ff23 100644
--- a/drivers/pci/host/pci-mvebu.c
+++ b/drivers/pci/host/pci-mvebu.c
@@ -673,11 +673,11 @@ static struct pci_bus *mvebu_pcie_scan_bus(int nr, struct pci_sys_data *sys)
return bus;
}
-resource_size_t mvebu_pcie_align_resource(struct pci_dev *dev,
- const struct resource *res,
- resource_size_t start,
- resource_size_t size,
- resource_size_t align)
+static resource_size_t mvebu_pcie_align_resource(struct pci_dev *dev,
+ const struct resource *res,
+ resource_size_t start,
+ resource_size_t size,
+ resource_size_t align)
{
if (dev->bus->number != 0)
return start;
--
1.8.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PCI: mvebu: staticize mvebu_pcie_align_resource
2013-11-07 9:05 [PATCH] PCI: mvebu: staticize mvebu_pcie_align_resource Jisheng Zhang
@ 2013-11-07 9:11 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2013-11-07 9:11 UTC (permalink / raw)
To: Jisheng Zhang; +Cc: bhelgaas, jason, ezequiel.garcia, linux-pci, linux-kernel
Dear Jisheng Zhang,
On Thu, 7 Nov 2013 17:05:55 +0800, Jisheng Zhang wrote:
> This patch fixes the following sparse warning:
> drivers/pci/host/pci-mvebu.c:676:17: warning: symbol
> 'mvebu_pcie_align_resource' was not declared. Should it be static?
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Thanks, but a similar patch was already merged:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/pci/host/pci-mvebu.c?id=f5072dfbac053200c8865c4fb15e4f020b7b5d1d
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-07 9:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-07 9:05 [PATCH] PCI: mvebu: staticize mvebu_pcie_align_resource Jisheng Zhang
2013-11-07 9:11 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).