* [PATCH] hwmon: add support for GMT G751 chip in lm75 driver
@ 2013-11-09 17:39 Arnaud Ebalard
2013-11-09 18:27 ` Guenter Roeck
0 siblings, 1 reply; 4+ messages in thread
From: Arnaud Ebalard @ 2013-11-09 17:39 UTC (permalink / raw)
To: Guenter Roeck
Cc: Jean Delvare, Rob Herring, Pawel Moll, Mark Rutland,
Stephen Warren, Ian Campbell, Rob Landley, Grant Likely,
Linus Walleij, Arnd Bergmann, devicetree, linux-doc,
linux-kernel, lm-sensors
This was tested on a NETGEAR ReadyNAS 2120 device (Marvell Armada XP
based board, via DT).
Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
---
Hi Guenter,
As a side note, I removed the hunk that was present in previous patch to
add gmt to the list of DT vendor prefixes because I noticed someone had
taken care: https://lkml.org/lkml/2013/9/12/365
For the records, here is what I get on my NAS with the attached patch:
root@thin:/sys# sensors
g762-i2c-0-3e
Adapter: mv64xxx_i2c adapter
fan1: 5461 RPM (div = 1)
g762-i2c-0-48
Adapter: mv64xxx_i2c adapter
fan1: 5461 RPM (div = 1)
g762-i2c-0-49
Adapter: mv64xxx_i2c adapter
fan1: 5461 RPM (div = 1)
g751-i2c-0-4c
Adapter: mv64xxx_i2c adapter
temp1: +30.5°C (high = +80.0°C, hyst = +75.0°C)
armada_thermal-virtual-0
Adapter: Virtual device
temp1: +34.2°C
root@thin:/sys/bus/i2c/drivers/lm75/0-004c# ls
driver modalias subsystem temp1_max uevent
hwmon name temp1_input temp1_max_hyst
root@thin:/sys/bus/i2c/drivers/lm75/0-004c# dmesg | grep lm
[ 120.960471] lm75 0-004c: hwmon3: sensor 'g751'
just by adding the following to the .dts:
g751: g751@4c {
compatible = "gmt,g751";
reg = <0x4c>;
};
Do not hesitate to tell me if I missed something.
Cheers,
a+
Documentation/devicetree/bindings/i2c/trivial-devices.txt | 1 +
drivers/hwmon/Kconfig | 1 +
drivers/hwmon/lm75.c | 3 +++
3 files changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/i2c/trivial-devices.txt b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
index ad6a738..c98e5a2 100644
--- a/Documentation/devicetree/bindings/i2c/trivial-devices.txt
+++ b/Documentation/devicetree/bindings/i2c/trivial-devices.txt
@@ -35,6 +35,7 @@ fsl,mc13892 MC13892: Power Management Integrated Circuit (PMIC) for i.MX35/51
fsl,mma8450 MMA8450Q: Xtrinsic Low-power, 3-axis Xtrinsic Accelerometer
fsl,mpr121 MPR121: Proximity Capacitive Touch Sensor Controller
fsl,sgtl5000 SGTL5000: Ultra Low-Power Audio Codec
+gmt,g751 G751: Digital Temperature Sensor and Thermal Watchdog with Two-Wire Interface
infineon,slb9635tt Infineon SLB9635 (Soft-) I2C TPM (old protocol, max 100khz)
infineon,slb9645tt Infineon SLB9645 I2C TPM (new protocol, max 400khz)
maxim,ds1050 5 Bit Programmable, Pulse-Width Modulator
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index b3ab9d4..52d548f 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -656,6 +656,7 @@ config SENSORS_LM75
- Analog Devices ADT75
- Dallas Semiconductor DS75, DS1775 and DS7505
+ - Global Mixed-mode Technology (GMT) G751
- Maxim MAX6625 and MAX6626
- Microchip MCP980x
- National Semiconductor LM75, LM75A
diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
index c03b490..7e3ef13 100644
--- a/drivers/hwmon/lm75.c
+++ b/drivers/hwmon/lm75.c
@@ -39,6 +39,7 @@ enum lm75_type { /* keep sorted in alphabetical order */
ds1775,
ds75,
ds7505,
+ g751,
lm75,
lm75a,
max6625,
@@ -208,6 +209,7 @@ lm75_probe(struct i2c_client *client, const struct i2c_device_id *id)
data->resolution = 12;
data->sample_time = HZ / 4;
break;
+ case g751:
case lm75:
case lm75a:
data->resolution = 9;
@@ -296,6 +298,7 @@ static const struct i2c_device_id lm75_ids[] = {
{ "ds1775", ds1775, },
{ "ds75", ds75, },
{ "ds7505", ds7505, },
+ { "g751", g751, },
{ "lm75", lm75, },
{ "lm75a", lm75a, },
{ "max6625", max6625, },
--
1.8.4.rc3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] hwmon: add support for GMT G751 chip in lm75 driver
2013-11-09 17:39 [PATCH] hwmon: add support for GMT G751 chip in lm75 driver Arnaud Ebalard
@ 2013-11-09 18:27 ` Guenter Roeck
2013-11-09 19:42 ` Arnaud Ebalard
2013-11-09 21:17 ` Jean Delvare
0 siblings, 2 replies; 4+ messages in thread
From: Guenter Roeck @ 2013-11-09 18:27 UTC (permalink / raw)
To: Arnaud Ebalard
Cc: Jean Delvare, Rob Herring, Pawel Moll, Mark Rutland,
Stephen Warren, Ian Campbell, Rob Landley, Grant Likely,
Linus Walleij, Arnd Bergmann, devicetree, linux-doc,
linux-kernel, lm-sensors
On Sat, Nov 09, 2013 at 06:39:14PM +0100, Arnaud Ebalard wrote:
>
> This was tested on a NETGEAR ReadyNAS 2120 device (Marvell Armada XP
> based board, via DT).
>
> Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Looks good. I'll apply it to my -next branch. Since I already sent my
pull request to Linus, this will only go in after -rc1, which I hope
should be ok (unless Jean wants to pick it up for his pull request).
> ---
> Hi Guenter,
>
> As a side note, I removed the hunk that was present in previous patch to
> add gmt to the list of DT vendor prefixes because I noticed someone had
> taken care: https://lkml.org/lkml/2013/9/12/365
>
> For the records, here is what I get on my NAS with the attached patch:
>
> root@thin:/sys# sensors
> g762-i2c-0-3e
> Adapter: mv64xxx_i2c adapter
> fan1: 5461 RPM (div = 1)
>
> g762-i2c-0-48
> Adapter: mv64xxx_i2c adapter
> fan1: 5461 RPM (div = 1)
>
> g762-i2c-0-49
> Adapter: mv64xxx_i2c adapter
> fan1: 5461 RPM (div = 1)
>
Those rpms are pretty high. Are the fans all really running that fast ?
Thanks,
Guenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hwmon: add support for GMT G751 chip in lm75 driver
2013-11-09 18:27 ` Guenter Roeck
@ 2013-11-09 19:42 ` Arnaud Ebalard
2013-11-09 21:17 ` Jean Delvare
1 sibling, 0 replies; 4+ messages in thread
From: Arnaud Ebalard @ 2013-11-09 19:42 UTC (permalink / raw)
To: Guenter Roeck
Cc: Jean Delvare, Rob Herring, Pawel Moll, Mark Rutland,
Stephen Warren, Ian Campbell, Rob Landley, Grant Likely,
Linus Walleij, Arnd Bergmann, devicetree, linux-doc,
linux-kernel, lm-sensors
Hi Guenter,
Guenter Roeck <linux@roeck-us.net> writes:
> On Sat, Nov 09, 2013 at 06:39:14PM +0100, Arnaud Ebalard wrote:
>>
>> This was tested on a NETGEAR ReadyNAS 2120 device (Marvell Armada XP
>> based board, via DT).
>>
>> Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
>
> Looks good. I'll apply it to my -next branch. Since I already sent my
> pull request to Linus, this will only go in after -rc1, which I hope
> should be ok (unless Jean wants to pick it up for his pull request).
Perfect, thanks.
>> ---
>> Hi Guenter,
>>
>> As a side note, I removed the hunk that was present in previous patch to
>> add gmt to the list of DT vendor prefixes because I noticed someone had
>> taken care: https://lkml.org/lkml/2013/9/12/365
>>
>> For the records, here is what I get on my NAS with the attached patch:
>>
>> root@thin:/sys# sensors
>> g762-i2c-0-3e
>> Adapter: mv64xxx_i2c adapter
>> fan1: 5461 RPM (div = 1)
>>
>> g762-i2c-0-48
>> Adapter: mv64xxx_i2c adapter
>> fan1: 5461 RPM (div = 1)
>>
>> g762-i2c-0-49
>> Adapter: mv64xxx_i2c adapter
>> fan1: 5461 RPM (div = 1)
>>
> Those rpms are pretty high. Are the fans all really running that fast ?
Unlike the fans on NETGEAR ReadyNAS 102 and 104 which are Protechnic
MGT9212YB-025 92mmx92mm running at 3200 RPM max, the three fans in the
RN2120 are Protechnic MGT4012XB-O20, i.e. 40mmx40mm running at 8000 RPM
max. At least, this is the max RPM value I found on their website
(Search Products on left side of http://www.protechnic-us.com/en/) for
both devices.
When pushing one a bit, here is the max rotation speed I get:
root@thin:/sys/bus/i2c/drivers/g762/0-003e# echo 9000 > fan1_target ; \
sleep 5 ; cat fan1_input
8057
which AFAICT validates current settings for G762 and fan combination.
Did I miss something?
Cheers,
a+
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hwmon: add support for GMT G751 chip in lm75 driver
2013-11-09 18:27 ` Guenter Roeck
2013-11-09 19:42 ` Arnaud Ebalard
@ 2013-11-09 21:17 ` Jean Delvare
1 sibling, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2013-11-09 21:17 UTC (permalink / raw)
To: Guenter Roeck
Cc: Arnaud Ebalard, Rob Herring, Pawel Moll, Mark Rutland,
Stephen Warren, Ian Campbell, Rob Landley, Grant Likely,
Linus Walleij, Arnd Bergmann, devicetree, linux-doc,
linux-kernel, lm-sensors
On Sat, 9 Nov 2013 10:27:07 -0800, Guenter Roeck wrote:
> On Sat, Nov 09, 2013 at 06:39:14PM +0100, Arnaud Ebalard wrote:
> >
> > This was tested on a NETGEAR ReadyNAS 2120 device (Marvell Armada XP
> > based board, via DT).
> >
> > Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
>
> Looks good. I'll apply it to my -next branch. Since I already sent my
> pull request to Linus, this will only go in after -rc1, which I hope
> should be ok (unless Jean wants to pick it up for his pull request).
No, I don't.
--
Jean Delvare
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-11-09 21:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-09 17:39 [PATCH] hwmon: add support for GMT G751 chip in lm75 driver Arnaud Ebalard
2013-11-09 18:27 ` Guenter Roeck
2013-11-09 19:42 ` Arnaud Ebalard
2013-11-09 21:17 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).