* [PATCH] rtc: rtc-at91rm9200: Corrected alarm over day/month wrap:
@ 2013-11-18 17:20 Nicolas Ferre
2013-11-18 22:37 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Ferre @ 2013-11-18 17:20 UTC (permalink / raw)
To: linus, Andrew Morton; +Cc: linux-arm-kernel, linux-kernel
From: Linus Pizunski <linus@narrativeteam.com>
Update month and day of month to the alarm month/day instead
of current day/month when setting the RTC alarm mask.
Signed-off-by: Linus Pizunski <linus@narrativeteam.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
drivers/rtc/rtc-at91rm9200.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
index 8b2cd8a5a2ff..0dc0809adbf2 100644
--- a/drivers/rtc/rtc-at91rm9200.c
+++ b/drivers/rtc/rtc-at91rm9200.c
@@ -220,6 +220,8 @@ static int at91_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm)
at91_alarm_year = tm.tm_year;
+ tm.tm_mon = alrm->time.tm_mon;
+ tm.tm_mday = alrm->time.tm_mday;
tm.tm_hour = alrm->time.tm_hour;
tm.tm_min = alrm->time.tm_min;
tm.tm_sec = alrm->time.tm_sec;
--
1.8.2.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rtc: rtc-at91rm9200: Corrected alarm over day/month wrap:
2013-11-18 17:20 [PATCH] rtc: rtc-at91rm9200: Corrected alarm over day/month wrap: Nicolas Ferre
@ 2013-11-18 22:37 ` Andrew Morton
2013-12-02 8:28 ` Nicolas Ferre
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2013-11-18 22:37 UTC (permalink / raw)
To: Nicolas Ferre; +Cc: linus, linux-arm-kernel, linux-kernel
On Mon, 18 Nov 2013 18:20:54 +0100 Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> From: Linus Pizunski <linus@narrativeteam.com>
>
> Update month and day of month to the alarm month/day instead
> of current day/month when setting the RTC alarm mask.
>
> Signed-off-by: Linus Pizunski <linus@narrativeteam.com>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
I changed this to signed-off-by, as you were on the patch delivery path.
> --- a/drivers/rtc/rtc-at91rm9200.c
> +++ b/drivers/rtc/rtc-at91rm9200.c
> @@ -220,6 +220,8 @@ static int at91_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm)
>
> at91_alarm_year = tm.tm_year;
>
> + tm.tm_mon = alrm->time.tm_mon;
> + tm.tm_mday = alrm->time.tm_mday;
> tm.tm_hour = alrm->time.tm_hour;
> tm.tm_min = alrm->time.tm_min;
> tm.tm_sec = alrm->time.tm_sec;
I queued this for 3.13. Do we think it warrants a -stable backport?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtc: rtc-at91rm9200: Corrected alarm over day/month wrap:
2013-11-18 22:37 ` Andrew Morton
@ 2013-12-02 8:28 ` Nicolas Ferre
0 siblings, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2013-12-02 8:28 UTC (permalink / raw)
To: Andrew Morton; +Cc: linus, linux-arm-kernel, linux-kernel
On 18/11/2013 23:37, Andrew Morton :
> On Mon, 18 Nov 2013 18:20:54 +0100 Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
>
>> From: Linus Pizunski <linus@narrativeteam.com>
>>
>> Update month and day of month to the alarm month/day instead
>> of current day/month when setting the RTC alarm mask.
>>
>> Signed-off-by: Linus Pizunski <linus@narrativeteam.com>
>> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>
> I changed this to signed-off-by, as you were on the patch delivery path.
>
>> --- a/drivers/rtc/rtc-at91rm9200.c
>> +++ b/drivers/rtc/rtc-at91rm9200.c
>> @@ -220,6 +220,8 @@ static int at91_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm)
>>
>> at91_alarm_year = tm.tm_year;
>>
>> + tm.tm_mon = alrm->time.tm_mon;
>> + tm.tm_mday = alrm->time.tm_mday;
>> tm.tm_hour = alrm->time.tm_hour;
>> tm.tm_min = alrm->time.tm_min;
>> tm.tm_sec = alrm->time.tm_sec;
>
> I queued this for 3.13. Do we think it warrants a -stable backport?
(I am late, but it seems this one is not sent to Linus yet...)
Well, yes, we can tag this one for "-stable". The patch applies on
nearly each kernel that I can think about (code is from 2.6.17-ish). But
this patch applies with an offset...
Best regards,
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-02 8:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-18 17:20 [PATCH] rtc: rtc-at91rm9200: Corrected alarm over day/month wrap: Nicolas Ferre
2013-11-18 22:37 ` Andrew Morton
2013-12-02 8:28 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).