* IRQF_RESUME_EARLY and errors in dpm_suspend_noirq
@ 2013-11-20 9:20 Heiko Stübner
2013-11-20 9:54 ` Laxman Dewangan
0 siblings, 1 reply; 7+ messages in thread
From: Heiko Stübner @ 2013-11-20 9:20 UTC (permalink / raw)
To: Ian Campbell, Rafael J. Wysocki, Thomas Gleixner, Len Brown,
Greg Kroah-Hartman, Pavel Machek
Cc: linux-kernel, linux-pm
Hi,
Commit 9bab0b7fbace (genirq: Add IRQF_RESUME_EARLY and resume such IRQs
earlier) split the suspend/resume of the irqs into two parts.
The early-irqs get resumed during syscore_resume, while the rest get
resumed by the regular resume_device_irqs.
I may be blind, but where get the early-irqs resumed in the error
path of dpm_suspend_noirq?
When a suspend_noirq callback returns an error, dpm_resume_noirq gets called,
which only calls resume_device_irqs while the suspend_device_irqs call in
dpm_suspend_noirq suspends all irqs. So it does not seem that the early-irqs
get resumed at all in this case.
Thanks
Heiko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: IRQF_RESUME_EARLY and errors in dpm_suspend_noirq
2013-11-20 9:20 IRQF_RESUME_EARLY and errors in dpm_suspend_noirq Heiko Stübner
@ 2013-11-20 9:54 ` Laxman Dewangan
2013-11-23 21:25 ` Heiko Stübner
2013-11-25 10:13 ` Ian Campbell
0 siblings, 2 replies; 7+ messages in thread
From: Laxman Dewangan @ 2013-11-20 9:54 UTC (permalink / raw)
To: Heiko Stübner
Cc: Ian Campbell, Rafael J. Wysocki, Thomas Gleixner, Len Brown,
Greg Kroah-Hartman, Pavel Machek, linux-kernel, linux-pm
On Wednesday 20 November 2013 02:50 PM, Heiko Stübner wrote:
> Hi,
>
> Commit 9bab0b7fbace (genirq: Add IRQF_RESUME_EARLY and resume such IRQs
> earlier) split the suspend/resume of the irqs into two parts.
>
> The early-irqs get resumed during syscore_resume, while the rest get
> resumed by the regular resume_device_irqs.
>
> I may be blind, but where get the early-irqs resumed in the error
> path of dpm_suspend_noirq?
>
> When a suspend_noirq callback returns an error, dpm_resume_noirq gets called,
> which only calls resume_device_irqs while the suspend_device_irqs call in
> dpm_suspend_noirq suspends all irqs. So it does not seem that the early-irqs
> get resumed at all in this case.
>
I also faced same issue in our suspend failure path and posted fix
sometime ago as
https://lkml.org/lkml/2013/8/13/373
It is still under review.
You can try this patch if it resolve the issue.
Thanks,
Laxman
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: IRQF_RESUME_EARLY and errors in dpm_suspend_noirq
2013-11-20 9:54 ` Laxman Dewangan
@ 2013-11-23 21:25 ` Heiko Stübner
2013-11-24 10:41 ` Pavel Machek
2013-11-24 11:20 ` Pavel Machek
2013-11-25 10:13 ` Ian Campbell
1 sibling, 2 replies; 7+ messages in thread
From: Heiko Stübner @ 2013-11-23 21:25 UTC (permalink / raw)
To: Laxman Dewangan
Cc: Ian Campbell, Rafael J. Wysocki, Thomas Gleixner, Len Brown,
Greg Kroah-Hartman, Pavel Machek, linux-kernel, linux-pm
Hi Laxman,
Am Mittwoch, 20. November 2013, 10:54:10 schrieb Laxman Dewangan:
> > I may be blind, but where get the early-irqs resumed in the error
> > path of dpm_suspend_noirq?
> >
> > When a suspend_noirq callback returns an error, dpm_resume_noirq gets
> > called, which only calls resume_device_irqs while the
> > suspend_device_irqs call in dpm_suspend_noirq suspends all irqs. So it
> > does not seem that the early-irqs get resumed at all in this case.
>
> I also faced same issue in our suspend failure path and posted fix
> sometime ago as
> https://lkml.org/lkml/2013/8/13/373
>
> It is still under review.
>From the thread on lkml.org it looks like it got no reaction at all - maybe
was just overlooked. So maybe it would be good to re-send it.
As it is not visible on lkml.org, did you also include stable@kernel.org, as
the issue started in 2011?
> You can try this patch if it resolve the issue.
Your patch looks a lot more sophisticated than my current band-aid fix :-) by
using the fact that irqs won't get resumed twice on their own.
So if you repost your patch you could add an
Acked-by: Heiko Stuebner <heiko@sntech.de>
Heiko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: IRQF_RESUME_EARLY and errors in dpm_suspend_noirq
2013-11-23 21:25 ` Heiko Stübner
@ 2013-11-24 10:41 ` Pavel Machek
2013-11-24 11:20 ` Pavel Machek
1 sibling, 0 replies; 7+ messages in thread
From: Pavel Machek @ 2013-11-24 10:41 UTC (permalink / raw)
To: Heiko Stübner
Cc: Laxman Dewangan, Ian Campbell, Rafael J. Wysocki,
Thomas Gleixner, Len Brown, Greg Kroah-Hartman, linux-kernel,
linux-pm
On Sat 2013-11-23 22:25:48, Heiko Stübner wrote:
> Hi Laxman,
>
> Am Mittwoch, 20. November 2013, 10:54:10 schrieb Laxman Dewangan:
> > > I may be blind, but where get the early-irqs resumed in the error
> > > path of dpm_suspend_noirq?
> > >
> > > When a suspend_noirq callback returns an error, dpm_resume_noirq gets
> > > called, which only calls resume_device_irqs while the
> > > suspend_device_irqs call in dpm_suspend_noirq suspends all irqs. So it
> > > does not seem that the early-irqs get resumed at all in this case.
> >
> > I also faced same issue in our suspend failure path and posted fix
> > sometime ago as
> > https://lkml.org/lkml/2013/8/13/373
> >
> > It is still under review.
If it helps, you can add my
Reviewed-by: Pavel Machek <pavel@ucw.cz>
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: IRQF_RESUME_EARLY and errors in dpm_suspend_noirq
2013-11-23 21:25 ` Heiko Stübner
2013-11-24 10:41 ` Pavel Machek
@ 2013-11-24 11:20 ` Pavel Machek
1 sibling, 0 replies; 7+ messages in thread
From: Pavel Machek @ 2013-11-24 11:20 UTC (permalink / raw)
To: Heiko Stübner, rjw
Cc: Laxman Dewangan, Ian Campbell, Rafael J. Wysocki,
Thomas Gleixner, Len Brown, Greg Kroah-Hartman, linux-kernel,
linux-pm
Hi!
(Oops, it seems that this thread uses Rafael's old address, and that
it bounces, added address from maintainers to cc.)
Pavel
On Sat 2013-11-23 22:25:48, Heiko Stübner wrote:
> Hi Laxman,
>
> Am Mittwoch, 20. November 2013, 10:54:10 schrieb Laxman Dewangan:
> > > I may be blind, but where get the early-irqs resumed in the error
> > > path of dpm_suspend_noirq?
> > >
> > > When a suspend_noirq callback returns an error, dpm_resume_noirq gets
> > > called, which only calls resume_device_irqs while the
> > > suspend_device_irqs call in dpm_suspend_noirq suspends all irqs. So it
> > > does not seem that the early-irqs get resumed at all in this case.
> >
> > I also faced same issue in our suspend failure path and posted fix
> > sometime ago as
> > https://lkml.org/lkml/2013/8/13/373
> >
> > It is still under review.
>
> From the thread on lkml.org it looks like it got no reaction at all - maybe
> was just overlooked. So maybe it would be good to re-send it.
>
> As it is not visible on lkml.org, did you also include stable@kernel.org, as
> the issue started in 2011?
>
> > You can try this patch if it resolve the issue.
>
> Your patch looks a lot more sophisticated than my current band-aid fix :-) by
> using the fact that irqs won't get resumed twice on their own.
>
> So if you repost your patch you could add an
>
> Acked-by: Heiko Stuebner <heiko@sntech.de>
>
>
> Heiko
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: IRQF_RESUME_EARLY and errors in dpm_suspend_noirq
2013-11-20 9:54 ` Laxman Dewangan
2013-11-23 21:25 ` Heiko Stübner
@ 2013-11-25 10:13 ` Ian Campbell
2013-11-25 14:12 ` Laxman Dewangan
1 sibling, 1 reply; 7+ messages in thread
From: Ian Campbell @ 2013-11-25 10:13 UTC (permalink / raw)
To: Laxman Dewangan
Cc: Heiko Stübner, Rafael J. Wysocki, Thomas Gleixner,
Len Brown, Greg Kroah-Hartman, Pavel Machek, linux-kernel,
linux-pm
On Wed, 2013-11-20 at 15:24 +0530, Laxman Dewangan wrote:
> On Wednesday 20 November 2013 02:50 PM, Heiko Stübner wrote:
> > Hi,
> >
> > Commit 9bab0b7fbace (genirq: Add IRQF_RESUME_EARLY and resume such IRQs
> > earlier) split the suspend/resume of the irqs into two parts.
> >
> > The early-irqs get resumed during syscore_resume, while the rest get
> > resumed by the regular resume_device_irqs.
> >
> > I may be blind, but where get the early-irqs resumed in the error
> > path of dpm_suspend_noirq?
> >
> > When a suspend_noirq callback returns an error, dpm_resume_noirq gets called,
> > which only calls resume_device_irqs while the suspend_device_irqs call in
> > dpm_suspend_noirq suspends all irqs. So it does not seem that the early-irqs
> > get resumed at all in this case.
> >
> I also faced same issue in our suspend failure path and posted fix
> sometime ago as
> https://lkml.org/lkml/2013/8/13/373
>
> It is still under review.
IME zero comments since August is not "under review", it is "has slipped
through the cracks" ;-)
I would suggest you resend it.
Ian.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: IRQF_RESUME_EARLY and errors in dpm_suspend_noirq
2013-11-25 10:13 ` Ian Campbell
@ 2013-11-25 14:12 ` Laxman Dewangan
0 siblings, 0 replies; 7+ messages in thread
From: Laxman Dewangan @ 2013-11-25 14:12 UTC (permalink / raw)
To: Ian Campbell
Cc: Heiko Stübner, Rafael J. Wysocki, Thomas Gleixner,
Len Brown, Greg Kroah-Hartman, Pavel Machek, linux-kernel,
linux-pm
On Monday 25 November 2013 03:43 PM, Ian Campbell wrote:
> On Wed, 2013-11-20 at 15:24 +0530, Laxman Dewangan wrote:
>> On Wednesday 20 November 2013 02:50 PM, Heiko Stübner wrote:
>>> Hi,
>>>
>>> Commit 9bab0b7fbace (genirq: Add IRQF_RESUME_EARLY and resume such IRQs
>>> earlier) split the suspend/resume of the irqs into two parts.
>>>
>>> The early-irqs get resumed during syscore_resume, while the rest get
>>> resumed by the regular resume_device_irqs.
>>>
>>> I may be blind, but where get the early-irqs resumed in the error
>>> path of dpm_suspend_noirq?
>>>
>>> When a suspend_noirq callback returns an error, dpm_resume_noirq gets called,
>>> which only calls resume_device_irqs while the suspend_device_irqs call in
>>> dpm_suspend_noirq suspends all irqs. So it does not seem that the early-irqs
>>> get resumed at all in this case.
>>>
>> I also faced same issue in our suspend failure path and posted fix
>> sometime ago as
>> https://lkml.org/lkml/2013/8/13/373
>>
>> It is still under review.
> IME zero comments since August is not "under review", it is "has slipped
> through the cracks" ;-)
>
> I would suggest you resend it.
>
Thanks all of you for review/ack/validating it.
I resend it today. Hope at this time it will be on tree.
Howevere, I have not added stable on cc.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-11-25 14:14 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-20 9:20 IRQF_RESUME_EARLY and errors in dpm_suspend_noirq Heiko Stübner
2013-11-20 9:54 ` Laxman Dewangan
2013-11-23 21:25 ` Heiko Stübner
2013-11-24 10:41 ` Pavel Machek
2013-11-24 11:20 ` Pavel Machek
2013-11-25 10:13 ` Ian Campbell
2013-11-25 14:12 ` Laxman Dewangan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).