* [PATCH] acpi: Add BayTrail SoC GPIO and LPSS ACPI IDs
@ 2013-11-25 22:15 Paul Drews
2013-11-25 22:59 ` Rafael J. Wysocki
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Paul Drews @ 2013-11-25 22:15 UTC (permalink / raw)
To: lenb, rjw, linus.walleij, linux-acpi, linux-kernel; +Cc: Paul Drews
This adds the new ACPI ID (INT33FC) for the BayTrail GPIO
banks as seen on a BayTrail M System-On-Chip platform. This
ACPI ID is used by the BayTrail GPIO (pinctrl) driver to
manage the Low Power Subsystem (LPSS).
Signed-off-by: Paul Drews <paul.drews@intel.com>
---
drivers/acpi/acpi_lpss.c | 1 +
drivers/pinctrl/pinctrl-baytrail.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
index 6745fe1..e603905 100644
--- a/drivers/acpi/acpi_lpss.c
+++ b/drivers/acpi/acpi_lpss.c
@@ -162,6 +162,7 @@ static const struct acpi_device_id acpi_lpss_device_ids[] = {
{ "80860F14", (unsigned long)&byt_sdio_dev_desc },
{ "80860F41", (unsigned long)&byt_i2c_dev_desc },
{ "INT33B2", },
+ { "INT33FC", },
{ "INT3430", (unsigned long)&lpt_dev_desc },
{ "INT3431", (unsigned long)&lpt_dev_desc },
diff --git a/drivers/pinctrl/pinctrl-baytrail.c b/drivers/pinctrl/pinctrl-baytrail.c
index 2832576..114f5ef 100644
--- a/drivers/pinctrl/pinctrl-baytrail.c
+++ b/drivers/pinctrl/pinctrl-baytrail.c
@@ -512,6 +512,7 @@ static const struct dev_pm_ops byt_gpio_pm_ops = {
static const struct acpi_device_id byt_gpio_acpi_match[] = {
{ "INT33B2", 0 },
+ { "INT33FC", 0 },
{ }
};
MODULE_DEVICE_TABLE(acpi, byt_gpio_acpi_match);
--
1.7.11.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] acpi: Add BayTrail SoC GPIO and LPSS ACPI IDs
2013-11-25 22:15 [PATCH] acpi: Add BayTrail SoC GPIO and LPSS ACPI IDs Paul Drews
@ 2013-11-25 22:59 ` Rafael J. Wysocki
2013-11-26 1:03 ` Matthew Garrett
2013-11-28 13:29 ` Rafael J. Wysocki
2 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2013-11-25 22:59 UTC (permalink / raw)
To: Paul Drews; +Cc: lenb, linus.walleij, linux-acpi, linux-kernel
On Monday, November 25, 2013 02:15:55 PM Paul Drews wrote:
> This adds the new ACPI ID (INT33FC) for the BayTrail GPIO
> banks as seen on a BayTrail M System-On-Chip platform. This
> ACPI ID is used by the BayTrail GPIO (pinctrl) driver to
> manage the Low Power Subsystem (LPSS).
>
> Signed-off-by: Paul Drews <paul.drews@intel.com>
Am I supposed to take this (in which case I need an ACK from the pinctrl
maintainer)?
Or is it supposed to go through the pinctrl subsystem? In which case feel free
to add
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> # for the ACPI part
to the patch.
Thanks!
> ---
> drivers/acpi/acpi_lpss.c | 1 +
> drivers/pinctrl/pinctrl-baytrail.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
> index 6745fe1..e603905 100644
> --- a/drivers/acpi/acpi_lpss.c
> +++ b/drivers/acpi/acpi_lpss.c
> @@ -162,6 +162,7 @@ static const struct acpi_device_id acpi_lpss_device_ids[] = {
> { "80860F14", (unsigned long)&byt_sdio_dev_desc },
> { "80860F41", (unsigned long)&byt_i2c_dev_desc },
> { "INT33B2", },
> + { "INT33FC", },
>
> { "INT3430", (unsigned long)&lpt_dev_desc },
> { "INT3431", (unsigned long)&lpt_dev_desc },
> diff --git a/drivers/pinctrl/pinctrl-baytrail.c b/drivers/pinctrl/pinctrl-baytrail.c
> index 2832576..114f5ef 100644
> --- a/drivers/pinctrl/pinctrl-baytrail.c
> +++ b/drivers/pinctrl/pinctrl-baytrail.c
> @@ -512,6 +512,7 @@ static const struct dev_pm_ops byt_gpio_pm_ops = {
>
> static const struct acpi_device_id byt_gpio_acpi_match[] = {
> { "INT33B2", 0 },
> + { "INT33FC", 0 },
> { }
> };
> MODULE_DEVICE_TABLE(acpi, byt_gpio_acpi_match);
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] acpi: Add BayTrail SoC GPIO and LPSS ACPI IDs
2013-11-25 22:15 [PATCH] acpi: Add BayTrail SoC GPIO and LPSS ACPI IDs Paul Drews
2013-11-25 22:59 ` Rafael J. Wysocki
@ 2013-11-26 1:03 ` Matthew Garrett
2013-11-28 13:29 ` Rafael J. Wysocki
2 siblings, 0 replies; 6+ messages in thread
From: Matthew Garrett @ 2013-11-26 1:03 UTC (permalink / raw)
To: Paul Drews; +Cc: lenb, rjw, linus.walleij, linux-acpi, linux-kernel
On Mon, Nov 25, 2013 at 02:15:55PM -0800, Paul Drews wrote:
> This adds the new ACPI ID (INT33FC) for the BayTrail GPIO
> banks as seen on a BayTrail M System-On-Chip platform. This
> ACPI ID is used by the BayTrail GPIO (pinctrl) driver to
> manage the Low Power Subsystem (LPSS).
Not that we can do anything about this now, but if they have the same
programming model why isn't there a CID that covers them?
--
Matthew Garrett | mjg59@srcf.ucam.org
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] acpi: Add BayTrail SoC GPIO and LPSS ACPI IDs
2013-11-25 22:15 [PATCH] acpi: Add BayTrail SoC GPIO and LPSS ACPI IDs Paul Drews
2013-11-25 22:59 ` Rafael J. Wysocki
2013-11-26 1:03 ` Matthew Garrett
@ 2013-11-28 13:29 ` Rafael J. Wysocki
2013-11-29 12:16 ` Linus Walleij
2 siblings, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2013-11-28 13:29 UTC (permalink / raw)
To: Paul Drews, linus.walleij; +Cc: lenb, linux-acpi, linux-kernel
On Monday, November 25, 2013 02:15:55 PM Paul Drews wrote:
> This adds the new ACPI ID (INT33FC) for the BayTrail GPIO
> banks as seen on a BayTrail M System-On-Chip platform. This
> ACPI ID is used by the BayTrail GPIO (pinctrl) driver to
> manage the Low Power Subsystem (LPSS).
>
> Signed-off-by: Paul Drews <paul.drews@intel.com>
Linus, any objections to this? If not, I'll take it for 3.14.
Thanks,
Rafael
> ---
> drivers/acpi/acpi_lpss.c | 1 +
> drivers/pinctrl/pinctrl-baytrail.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c
> index 6745fe1..e603905 100644
> --- a/drivers/acpi/acpi_lpss.c
> +++ b/drivers/acpi/acpi_lpss.c
> @@ -162,6 +162,7 @@ static const struct acpi_device_id acpi_lpss_device_ids[] = {
> { "80860F14", (unsigned long)&byt_sdio_dev_desc },
> { "80860F41", (unsigned long)&byt_i2c_dev_desc },
> { "INT33B2", },
> + { "INT33FC", },
>
> { "INT3430", (unsigned long)&lpt_dev_desc },
> { "INT3431", (unsigned long)&lpt_dev_desc },
> diff --git a/drivers/pinctrl/pinctrl-baytrail.c b/drivers/pinctrl/pinctrl-baytrail.c
> index 2832576..114f5ef 100644
> --- a/drivers/pinctrl/pinctrl-baytrail.c
> +++ b/drivers/pinctrl/pinctrl-baytrail.c
> @@ -512,6 +512,7 @@ static const struct dev_pm_ops byt_gpio_pm_ops = {
>
> static const struct acpi_device_id byt_gpio_acpi_match[] = {
> { "INT33B2", 0 },
> + { "INT33FC", 0 },
> { }
> };
> MODULE_DEVICE_TABLE(acpi, byt_gpio_acpi_match);
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] acpi: Add BayTrail SoC GPIO and LPSS ACPI IDs
2013-11-28 13:29 ` Rafael J. Wysocki
@ 2013-11-29 12:16 ` Linus Walleij
2013-11-29 15:26 ` Rafael J. Wysocki
0 siblings, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2013-11-29 12:16 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Paul Drews, Len Brown, ACPI Devel Maling List, linux-kernel
On Thu, Nov 28, 2013 at 2:29 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> On Monday, November 25, 2013 02:15:55 PM Paul Drews wrote:
>> This adds the new ACPI ID (INT33FC) for the BayTrail GPIO
>> banks as seen on a BayTrail M System-On-Chip platform. This
>> ACPI ID is used by the BayTrail GPIO (pinctrl) driver to
>> manage the Low Power Subsystem (LPSS).
>>
>> Signed-off-by: Paul Drews <paul.drews@intel.com>
>
> Linus, any objections to this? If not, I'll take it for 3.14.
Go ahead,
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] acpi: Add BayTrail SoC GPIO and LPSS ACPI IDs
2013-11-29 12:16 ` Linus Walleij
@ 2013-11-29 15:26 ` Rafael J. Wysocki
0 siblings, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2013-11-29 15:26 UTC (permalink / raw)
To: Linus Walleij; +Cc: Paul Drews, Len Brown, ACPI Devel Maling List, linux-kernel
On Friday, November 29, 2013 01:16:31 PM Linus Walleij wrote:
> On Thu, Nov 28, 2013 at 2:29 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > On Monday, November 25, 2013 02:15:55 PM Paul Drews wrote:
> >> This adds the new ACPI ID (INT33FC) for the BayTrail GPIO
> >> banks as seen on a BayTrail M System-On-Chip platform. This
> >> ACPI ID is used by the BayTrail GPIO (pinctrl) driver to
> >> manage the Low Power Subsystem (LPSS).
> >>
> >> Signed-off-by: Paul Drews <paul.drews@intel.com>
> >
> > Linus, any objections to this? If not, I'll take it for 3.14.
>
> Go ahead,
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-11-29 15:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-25 22:15 [PATCH] acpi: Add BayTrail SoC GPIO and LPSS ACPI IDs Paul Drews
2013-11-25 22:59 ` Rafael J. Wysocki
2013-11-26 1:03 ` Matthew Garrett
2013-11-28 13:29 ` Rafael J. Wysocki
2013-11-29 12:16 ` Linus Walleij
2013-11-29 15:26 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).