* [PATCH] dma: mv_xor: remove mv_desc_get_dest_addr()
@ 2013-11-25 19:39 Jason Cooper
2013-11-25 19:46 ` Jason Cooper
2013-11-28 5:57 ` Vinod Koul
0 siblings, 2 replies; 13+ messages in thread
From: Jason Cooper @ 2013-11-25 19:39 UTC (permalink / raw)
To: Dan Williams, Vinod Koul
Cc: Jason Cooper, dmaengine, linux-kernel, linux-arm-kernel
The following commit:
54f8d501e842 dmaengine: remove DMA unmap from drivers
removed the last caller to mv_desc_get_dest_addr(), creating the
warning:
drivers/dma/mv_xor.c:57:12: warning: 'mv_desc_get_dest_addr' defined
but not used [-Wunused-function]
Remove it.
Signed-off-by: Jason Cooper <jason@lakedaemon.net>
---
drivers/dma/mv_xor.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c
index 7807f0ef4e20..23bcc9158cbc 100644
--- a/drivers/dma/mv_xor.c
+++ b/drivers/dma/mv_xor.c
@@ -54,12 +54,6 @@ static void mv_desc_init(struct mv_xor_desc_slot *desc, unsigned long flags)
hw_desc->desc_command = (1 << 31);
}
-static u32 mv_desc_get_dest_addr(struct mv_xor_desc_slot *desc)
-{
- struct mv_xor_desc *hw_desc = desc->hw_desc;
- return hw_desc->phy_dest_addr;
-}
-
static void mv_desc_set_byte_count(struct mv_xor_desc_slot *desc,
u32 byte_count)
{
--
1.8.4.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH] dma: mv_xor: remove mv_desc_get_dest_addr()
2013-11-25 19:39 [PATCH] dma: mv_xor: remove mv_desc_get_dest_addr() Jason Cooper
@ 2013-11-25 19:46 ` Jason Cooper
2013-11-27 19:45 ` Olof Johansson
2013-11-28 5:57 ` Vinod Koul
1 sibling, 1 reply; 13+ messages in thread
From: Jason Cooper @ 2013-11-25 19:46 UTC (permalink / raw)
To: Dan Williams, Vinod Koul; +Cc: dmaengine, linux-arm-kernel, linux-kernel
On Mon, Nov 25, 2013 at 07:39:25PM +0000, Jason Cooper wrote:
> The following commit:
>
> 54f8d501e842 dmaengine: remove DMA unmap from drivers
>
> removed the last caller to mv_desc_get_dest_addr(), creating the
> warning:
>
> drivers/dma/mv_xor.c:57:12: warning: 'mv_desc_get_dest_addr' defined
> but not used [-Wunused-function]
>
> Remove it.
>
> Signed-off-by: Jason Cooper <jason@lakedaemon.net>
> ---
> drivers/dma/mv_xor.c | 6 ------
> 1 file changed, 6 deletions(-)
Gah! I sent too fast. I meant to mention that I have this in my
mvebu/fixes branch, which gets merged into -next each night. (The
warning was bugging me :) )
Just let me know when you take it and I'll drop it from my branches.
thx,
Jason.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] dma: mv_xor: remove mv_desc_get_dest_addr()
2013-11-25 19:46 ` Jason Cooper
@ 2013-11-27 19:45 ` Olof Johansson
2013-11-27 23:58 ` Jason Cooper
0 siblings, 1 reply; 13+ messages in thread
From: Olof Johansson @ 2013-11-27 19:45 UTC (permalink / raw)
To: Jason Cooper
Cc: Dan Williams, Vinod Koul, dmaengine, linux-arm-kernel, linux-kernel
On Mon, Nov 25, 2013 at 11:46 AM, Jason Cooper <jason@lakedaemon.net> wrote:
> On Mon, Nov 25, 2013 at 07:39:25PM +0000, Jason Cooper wrote:
>> The following commit:
>>
>> 54f8d501e842 dmaengine: remove DMA unmap from drivers
>>
>> removed the last caller to mv_desc_get_dest_addr(), creating the
>> warning:
>>
>> drivers/dma/mv_xor.c:57:12: warning: 'mv_desc_get_dest_addr' defined
>> but not used [-Wunused-function]
>>
>> Remove it.
>>
>> Signed-off-by: Jason Cooper <jason@lakedaemon.net>
>> ---
>> drivers/dma/mv_xor.c | 6 ------
>> 1 file changed, 6 deletions(-)
>
> Gah! I sent too fast. I meant to mention that I have this in my
> mvebu/fixes branch, which gets merged into -next each night. (The
> warning was bugging me :) )
>
> Just let me know when you take it and I'll drop it from my branches.
Hmm. Please don't add patches for other subsystems into your -next
tree, since then there is no indication for those of us who follow
-next that the patch is not yet merged by the appropriate maintainer.
-Olof
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] dma: mv_xor: remove mv_desc_get_dest_addr()
2013-11-27 19:45 ` Olof Johansson
@ 2013-11-27 23:58 ` Jason Cooper
0 siblings, 0 replies; 13+ messages in thread
From: Jason Cooper @ 2013-11-27 23:58 UTC (permalink / raw)
To: Olof Johansson
Cc: Dan Williams, Vinod Koul, dmaengine, linux-arm-kernel, linux-kernel
On Wed, Nov 27, 2013 at 11:45:24AM -0800, Olof Johansson wrote:
> On Mon, Nov 25, 2013 at 11:46 AM, Jason Cooper <jason@lakedaemon.net> wrote:
> > On Mon, Nov 25, 2013 at 07:39:25PM +0000, Jason Cooper wrote:
> >> The following commit:
> >>
> >> 54f8d501e842 dmaengine: remove DMA unmap from drivers
> >>
> >> removed the last caller to mv_desc_get_dest_addr(), creating the
> >> warning:
> >>
> >> drivers/dma/mv_xor.c:57:12: warning: 'mv_desc_get_dest_addr' defined
> >> but not used [-Wunused-function]
> >>
> >> Remove it.
> >>
> >> Signed-off-by: Jason Cooper <jason@lakedaemon.net>
> >> ---
> >> drivers/dma/mv_xor.c | 6 ------
> >> 1 file changed, 6 deletions(-)
> >
> > Gah! I sent too fast. I meant to mention that I have this in my
> > mvebu/fixes branch, which gets merged into -next each night. (The
> > warning was bugging me :) )
> >
> > Just let me know when you take it and I'll drop it from my branches.
>
> Hmm. Please don't add patches for other subsystems into your -next
> tree, since then there is no indication for those of us who follow
> -next that the patch is not yet merged by the appropriate maintainer.
Ack. Dropped. Sorry for the confusion and thanks for setting me
straight.
thx,
Jason.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] dma: mv_xor: remove mv_desc_get_dest_addr()
2013-11-25 19:39 [PATCH] dma: mv_xor: remove mv_desc_get_dest_addr() Jason Cooper
2013-11-25 19:46 ` Jason Cooper
@ 2013-11-28 5:57 ` Vinod Koul
2013-12-09 23:50 ` Russell King - ARM Linux
1 sibling, 1 reply; 13+ messages in thread
From: Vinod Koul @ 2013-11-28 5:57 UTC (permalink / raw)
To: Jason Cooper, Dan Williams
Cc: Dan Williams, dmaengine, linux-kernel, linux-arm-kernel
+ Dan
On Mon, Nov 25, 2013 at 07:39:25PM +0000, Jason Cooper wrote:
> The following commit:
>
> 54f8d501e842 dmaengine: remove DMA unmap from drivers
>
> removed the last caller to mv_desc_get_dest_addr(), creating the
> warning:
>
> drivers/dma/mv_xor.c:57:12: warning: 'mv_desc_get_dest_addr' defined
> but not used [-Wunused-function]
>
> Remove it.
>
> Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Acked-by: Vinod Koul <vinod.koul@intel.com>
This should go thru Dan's tree
> ---
> drivers/dma/mv_xor.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/dma/mv_xor.c b/drivers/dma/mv_xor.c
> index 7807f0ef4e20..23bcc9158cbc 100644
> --- a/drivers/dma/mv_xor.c
> +++ b/drivers/dma/mv_xor.c
> @@ -54,12 +54,6 @@ static void mv_desc_init(struct mv_xor_desc_slot *desc, unsigned long flags)
> hw_desc->desc_command = (1 << 31);
> }
>
> -static u32 mv_desc_get_dest_addr(struct mv_xor_desc_slot *desc)
> -{
> - struct mv_xor_desc *hw_desc = desc->hw_desc;
> - return hw_desc->phy_dest_addr;
> -}
> -
> static void mv_desc_set_byte_count(struct mv_xor_desc_slot *desc,
> u32 byte_count)
> {
> --
> 1.8.4.4
>
--
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] dma: mv_xor: remove mv_desc_get_dest_addr()
2013-11-28 5:57 ` Vinod Koul
@ 2013-12-09 23:50 ` Russell King - ARM Linux
2013-12-10 10:13 ` Vinod Koul
0 siblings, 1 reply; 13+ messages in thread
From: Russell King - ARM Linux @ 2013-12-09 23:50 UTC (permalink / raw)
To: Vinod Koul
Cc: Jason Cooper, Dan Williams, dmaengine, linux-kernel, linux-arm-kernel
On Thu, Nov 28, 2013 at 11:27:06AM +0530, Vinod Koul wrote:
> + Dan
>
> On Mon, Nov 25, 2013 at 07:39:25PM +0000, Jason Cooper wrote:
> > The following commit:
> >
> > 54f8d501e842 dmaengine: remove DMA unmap from drivers
> >
> > removed the last caller to mv_desc_get_dest_addr(), creating the
> > warning:
> >
> > drivers/dma/mv_xor.c:57:12: warning: 'mv_desc_get_dest_addr' defined
> > but not used [-Wunused-function]
> >
> > Remove it.
> >
> > Signed-off-by: Jason Cooper <jason@lakedaemon.net>
> Acked-by: Vinod Koul <vinod.koul@intel.com>
>
> This should go thru Dan's tree
So what's happening with this patch? I don't see it in -rc yet.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] dma: mv_xor: remove mv_desc_get_dest_addr()
2013-12-09 23:50 ` Russell King - ARM Linux
@ 2013-12-10 10:13 ` Vinod Koul
2013-12-10 11:14 ` Russell King - ARM Linux
0 siblings, 1 reply; 13+ messages in thread
From: Vinod Koul @ 2013-12-10 10:13 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: Jason Cooper, Dan Williams, dmaengine, linux-kernel, linux-arm-kernel
On Mon, Dec 09, 2013 at 11:50:35PM +0000, Russell King - ARM Linux wrote:
> On Thu, Nov 28, 2013 at 11:27:06AM +0530, Vinod Koul wrote:
> > + Dan
> >
> > On Mon, Nov 25, 2013 at 07:39:25PM +0000, Jason Cooper wrote:
> > > The following commit:
> > >
> > > 54f8d501e842 dmaengine: remove DMA unmap from drivers
> > >
> > > removed the last caller to mv_desc_get_dest_addr(), creating the
> > > warning:
> > >
> > > drivers/dma/mv_xor.c:57:12: warning: 'mv_desc_get_dest_addr' defined
> > > but not used [-Wunused-function]
> > >
> > > Remove it.
> > >
> > > Signed-off-by: Jason Cooper <jason@lakedaemon.net>
> > Acked-by: Vinod Koul <vinod.koul@intel.com>
> >
> > This should go thru Dan's tree
>
> So what's happening with this patch? I don't see it in -rc yet.
Dan has applied this to his next. So this should show us in next rc1
--
~Vinod
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] dma: mv_xor: remove mv_desc_get_dest_addr()
2013-12-10 10:13 ` Vinod Koul
@ 2013-12-10 11:14 ` Russell King - ARM Linux
2013-12-11 9:10 ` Dan Williams
0 siblings, 1 reply; 13+ messages in thread
From: Russell King - ARM Linux @ 2013-12-10 11:14 UTC (permalink / raw)
To: Vinod Koul
Cc: Jason Cooper, Dan Williams, dmaengine, linux-kernel, linux-arm-kernel
On Tue, Dec 10, 2013 at 03:43:31PM +0530, Vinod Koul wrote:
> On Mon, Dec 09, 2013 at 11:50:35PM +0000, Russell King - ARM Linux wrote:
> > On Thu, Nov 28, 2013 at 11:27:06AM +0530, Vinod Koul wrote:
> > > + Dan
> > >
> > > On Mon, Nov 25, 2013 at 07:39:25PM +0000, Jason Cooper wrote:
> > > > The following commit:
> > > >
> > > > 54f8d501e842 dmaengine: remove DMA unmap from drivers
> > > >
> > > > removed the last caller to mv_desc_get_dest_addr(), creating the
> > > > warning:
> > > >
> > > > drivers/dma/mv_xor.c:57:12: warning: 'mv_desc_get_dest_addr' defined
> > > > but not used [-Wunused-function]
> > > >
> > > > Remove it.
> > > >
> > > > Signed-off-by: Jason Cooper <jason@lakedaemon.net>
> > > Acked-by: Vinod Koul <vinod.koul@intel.com>
> > >
> > > This should go thru Dan's tree
> >
> > So what's happening with this patch? I don't see it in -rc yet.
> Dan has applied this to his next. So this should show us in next rc1
Wrong answer. This is a compile regression introduced in the last merge
window, it should be going into an -rc kernel.
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] dma: mv_xor: remove mv_desc_get_dest_addr()
2013-12-10 11:14 ` Russell King - ARM Linux
@ 2013-12-11 9:10 ` Dan Williams
2013-12-13 7:00 ` Dan Williams
0 siblings, 1 reply; 13+ messages in thread
From: Dan Williams @ 2013-12-11 9:10 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: Vinod Koul, Jason Cooper, dmaengine, linux-kernel, linux-arm-kernel
On Tue, Dec 10, 2013 at 3:14 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Tue, Dec 10, 2013 at 03:43:31PM +0530, Vinod Koul wrote:
>> On Mon, Dec 09, 2013 at 11:50:35PM +0000, Russell King - ARM Linux wrote:
>> > On Thu, Nov 28, 2013 at 11:27:06AM +0530, Vinod Koul wrote:
>> > > + Dan
>> > >
>> > > On Mon, Nov 25, 2013 at 07:39:25PM +0000, Jason Cooper wrote:
>> > > > The following commit:
>> > > >
>> > > > 54f8d501e842 dmaengine: remove DMA unmap from drivers
>> > > >
>> > > > removed the last caller to mv_desc_get_dest_addr(), creating the
>> > > > warning:
>> > > >
>> > > > drivers/dma/mv_xor.c:57:12: warning: 'mv_desc_get_dest_addr' defined
>> > > > but not used [-Wunused-function]
>> > > >
>> > > > Remove it.
>> > > >
>> > > > Signed-off-by: Jason Cooper <jason@lakedaemon.net>
>> > > Acked-by: Vinod Koul <vinod.koul@intel.com>
>> > >
>> > > This should go thru Dan's tree
>> >
>> > So what's happening with this patch? I don't see it in -rc yet.
>> Dan has applied this to his next. So this should show us in next rc1
>
> Wrong answer. This is a compile regression introduced in the last merge
> window, it should be going into an -rc kernel.
Vinod, if your fixes branch is ready I'll take it along with the rest
of the regression fixes to Linus.
--
Dan
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] dma: mv_xor: remove mv_desc_get_dest_addr()
2013-12-11 9:10 ` Dan Williams
@ 2013-12-13 7:00 ` Dan Williams
2013-12-18 15:40 ` Vinod Koul
0 siblings, 1 reply; 13+ messages in thread
From: Dan Williams @ 2013-12-13 7:00 UTC (permalink / raw)
To: Russell King - ARM Linux
Cc: Vinod Koul, Jason Cooper, dmaengine, linux-kernel, linux-arm-kernel
On Wed, Dec 11, 2013 at 1:10 AM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Tue, Dec 10, 2013 at 3:14 AM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
>> On Tue, Dec 10, 2013 at 03:43:31PM +0530, Vinod Koul wrote:
>>> On Mon, Dec 09, 2013 at 11:50:35PM +0000, Russell King - ARM Linux wrote:
>>> > On Thu, Nov 28, 2013 at 11:27:06AM +0530, Vinod Koul wrote:
>>> > > + Dan
>>> > >
>>> > > On Mon, Nov 25, 2013 at 07:39:25PM +0000, Jason Cooper wrote:
>>> > > > The following commit:
>>> > > >
>>> > > > 54f8d501e842 dmaengine: remove DMA unmap from drivers
>>> > > >
>>> > > > removed the last caller to mv_desc_get_dest_addr(), creating the
>>> > > > warning:
>>> > > >
>>> > > > drivers/dma/mv_xor.c:57:12: warning: 'mv_desc_get_dest_addr' defined
>>> > > > but not used [-Wunused-function]
>>> > > >
>>> > > > Remove it.
>>> > > >
>>> > > > Signed-off-by: Jason Cooper <jason@lakedaemon.net>
>>> > > Acked-by: Vinod Koul <vinod.koul@intel.com>
>>> > >
>>> > > This should go thru Dan's tree
>>> >
>>> > So what's happening with this patch? I don't see it in -rc yet.
>>> Dan has applied this to his next. So this should show us in next rc1
>>
>> Wrong answer. This is a compile regression introduced in the last merge
>> window, it should be going into an -rc kernel.
>
> Vinod, if your fixes branch is ready I'll take it along with the rest
> of the regression fixes to Linus.
Ok, I see you sent dma-slave/fixes up, I'll follow up with the rest:
Dan Williams (5):
dma: fix build warnings in ppc4xx
dma: fix fsldma build warnings
dmatest: fix build warning on mips
dma: fix build warnings in txx9
dmaengine: fix enable for high order unmap pools
Ezequiel Garcia (1):
dma: mv_xor: Use dmaengine_unmap_data for the self-tests
Jason Cooper (1):
dma: mv_xor: remove mv_desc_get_dest_addr()
Olof Johansson (1):
dmaengine: at_hdmac: remove unused function
Russell King (1):
dmaengine: mv_xor: fix oops when channels fail to initialise
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] dma: mv_xor: remove mv_desc_get_dest_addr()
2013-12-13 7:00 ` Dan Williams
@ 2013-12-18 15:40 ` Vinod Koul
2013-12-18 16:55 ` Dan Williams
0 siblings, 1 reply; 13+ messages in thread
From: Vinod Koul @ 2013-12-18 15:40 UTC (permalink / raw)
To: Dan Williams
Cc: Russell King - ARM Linux, Jason Cooper, dmaengine, linux-kernel,
linux-arm-kernel
On Thu, Dec 12, 2013 at 11:00:05PM -0800, Dan Williams wrote:
> On Wed, Dec 11, 2013 at 1:10 AM, Dan Williams <dan.j.williams@intel.com> wrote:
> > On Tue, Dec 10, 2013 at 3:14 AM, Russell King - ARM Linux
> > <linux@arm.linux.org.uk> wrote:
> >> On Tue, Dec 10, 2013 at 03:43:31PM +0530, Vinod Koul wrote:
> >>> On Mon, Dec 09, 2013 at 11:50:35PM +0000, Russell King - ARM Linux wrote:
> >>> > On Thu, Nov 28, 2013 at 11:27:06AM +0530, Vinod Koul wrote:
> >>> > > + Dan
> >>> > >
> >>> > > On Mon, Nov 25, 2013 at 07:39:25PM +0000, Jason Cooper wrote:
> >>> > > > The following commit:
> >>> > > >
> >>> > > > 54f8d501e842 dmaengine: remove DMA unmap from drivers
> >>> > > >
> >>> > > > removed the last caller to mv_desc_get_dest_addr(), creating the
> >>> > > > warning:
> >>> > > >
> >>> > > > drivers/dma/mv_xor.c:57:12: warning: 'mv_desc_get_dest_addr' defined
> >>> > > > but not used [-Wunused-function]
> >>> > > >
> >>> > > > Remove it.
> >>> > > >
> >>> > > > Signed-off-by: Jason Cooper <jason@lakedaemon.net>
> >>> > > Acked-by: Vinod Koul <vinod.koul@intel.com>
> >>> > >
> >>> > > This should go thru Dan's tree
> >>> >
> >>> > So what's happening with this patch? I don't see it in -rc yet.
> >>> Dan has applied this to his next. So this should show us in next rc1
> >>
> >> Wrong answer. This is a compile regression introduced in the last merge
> >> window, it should be going into an -rc kernel.
> >
> > Vinod, if your fixes branch is ready I'll take it along with the rest
> > of the regression fixes to Linus.
Sorry I wasnt well last week, so I just managed to send the PULL on friday
morning. Wasnt sure if Linus will cut rc on friday or later, so sent it!
>
> Ok, I see you sent dma-slave/fixes up, I'll follow up with the rest:
Okay, did you manage to send it? If not I may have few (i think at least 1 more)
--
~Vinod
>
> Dan Williams (5):
> dma: fix build warnings in ppc4xx
> dma: fix fsldma build warnings
> dmatest: fix build warning on mips
> dma: fix build warnings in txx9
> dmaengine: fix enable for high order unmap pools
>
> Ezequiel Garcia (1):
> dma: mv_xor: Use dmaengine_unmap_data for the self-tests
>
> Jason Cooper (1):
> dma: mv_xor: remove mv_desc_get_dest_addr()
>
> Olof Johansson (1):
> dmaengine: at_hdmac: remove unused function
>
> Russell King (1):
> dmaengine: mv_xor: fix oops when channels fail to initialise
--
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] dma: mv_xor: remove mv_desc_get_dest_addr()
2013-12-18 16:55 ` Dan Williams
@ 2013-12-18 16:33 ` Vinod Koul
0 siblings, 0 replies; 13+ messages in thread
From: Vinod Koul @ 2013-12-18 16:33 UTC (permalink / raw)
To: Dan Williams
Cc: Russell King - ARM Linux, Jason Cooper, dmaengine, linux-kernel,
linux-arm-kernel
On Wed, Dec 18, 2013 at 08:55:23AM -0800, Dan Williams wrote:
> >> > Vinod, if your fixes branch is ready I'll take it along with the rest
> >> > of the regression fixes to Linus.
> > Sorry I wasnt well last week, so I just managed to send the PULL on friday
> > morning. Wasnt sure if Linus will cut rc on friday or later, so sent it!
>
> Ok, glad you are feeling better.
Thanks
>
> >>
> >> Ok, I see you sent dma-slave/fixes up, I'll follow up with the rest:
> > Okay, did you manage to send it? If not I may have few (i think at least 1 more)
> >
>
> Patchwork id(s)? I want to send it it today.
3266451, I have acked it!
--
~Vinod
--
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] dma: mv_xor: remove mv_desc_get_dest_addr()
2013-12-18 15:40 ` Vinod Koul
@ 2013-12-18 16:55 ` Dan Williams
2013-12-18 16:33 ` Vinod Koul
0 siblings, 1 reply; 13+ messages in thread
From: Dan Williams @ 2013-12-18 16:55 UTC (permalink / raw)
To: Vinod Koul
Cc: Russell King - ARM Linux, Jason Cooper, dmaengine, linux-kernel,
linux-arm-kernel
On Wed, Dec 18, 2013 at 7:40 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Thu, Dec 12, 2013 at 11:00:05PM -0800, Dan Williams wrote:
>> On Wed, Dec 11, 2013 at 1:10 AM, Dan Williams <dan.j.williams@intel.com> wrote:
>> > On Tue, Dec 10, 2013 at 3:14 AM, Russell King - ARM Linux
>> > <linux@arm.linux.org.uk> wrote:
>> >> On Tue, Dec 10, 2013 at 03:43:31PM +0530, Vinod Koul wrote:
>> >>> On Mon, Dec 09, 2013 at 11:50:35PM +0000, Russell King - ARM Linux wrote:
>> >>> > On Thu, Nov 28, 2013 at 11:27:06AM +0530, Vinod Koul wrote:
>> >>> > > + Dan
>> >>> > >
>> >>> > > On Mon, Nov 25, 2013 at 07:39:25PM +0000, Jason Cooper wrote:
>> >>> > > > The following commit:
>> >>> > > >
>> >>> > > > 54f8d501e842 dmaengine: remove DMA unmap from drivers
>> >>> > > >
>> >>> > > > removed the last caller to mv_desc_get_dest_addr(), creating the
>> >>> > > > warning:
>> >>> > > >
>> >>> > > > drivers/dma/mv_xor.c:57:12: warning: 'mv_desc_get_dest_addr' defined
>> >>> > > > but not used [-Wunused-function]
>> >>> > > >
>> >>> > > > Remove it.
>> >>> > > >
>> >>> > > > Signed-off-by: Jason Cooper <jason@lakedaemon.net>
>> >>> > > Acked-by: Vinod Koul <vinod.koul@intel.com>
>> >>> > >
>> >>> > > This should go thru Dan's tree
>> >>> >
>> >>> > So what's happening with this patch? I don't see it in -rc yet.
>> >>> Dan has applied this to his next. So this should show us in next rc1
>> >>
>> >> Wrong answer. This is a compile regression introduced in the last merge
>> >> window, it should be going into an -rc kernel.
>> >
>> > Vinod, if your fixes branch is ready I'll take it along with the rest
>> > of the regression fixes to Linus.
> Sorry I wasnt well last week, so I just managed to send the PULL on friday
> morning. Wasnt sure if Linus will cut rc on friday or later, so sent it!
Ok, glad you are feeling better.
>>
>> Ok, I see you sent dma-slave/fixes up, I'll follow up with the rest:
> Okay, did you manage to send it? If not I may have few (i think at least 1 more)
>
Patchwork id(s)? I want to send it it today.
I was busy tracking down a data corruption report with net_dma.
--
Dan
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2013-12-18 17:32 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-25 19:39 [PATCH] dma: mv_xor: remove mv_desc_get_dest_addr() Jason Cooper
2013-11-25 19:46 ` Jason Cooper
2013-11-27 19:45 ` Olof Johansson
2013-11-27 23:58 ` Jason Cooper
2013-11-28 5:57 ` Vinod Koul
2013-12-09 23:50 ` Russell King - ARM Linux
2013-12-10 10:13 ` Vinod Koul
2013-12-10 11:14 ` Russell King - ARM Linux
2013-12-11 9:10 ` Dan Williams
2013-12-13 7:00 ` Dan Williams
2013-12-18 15:40 ` Vinod Koul
2013-12-18 16:55 ` Dan Williams
2013-12-18 16:33 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).