From: Mark Rutland <mark.rutland@arm.com>
To: Marc Carino <marc.ceeeee@gmail.com>
Cc: Christian Daudt <bcm@fixthebug.org>,
Arnd Bergmann <arnd@arndb.de>,
Florian Fainelli <f.fainelli@gmail.com>,
Matt Porter <matt.porter@linaro.org>,
Russell King <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 5/7] ARM: brcmstb: add misc. DT bindings for brcm,brcmstb-*
Date: Wed, 15 Jan 2014 17:11:55 +0000 [thread overview]
Message-ID: <20140115171155.GK25824@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <1389743333-16741-6-git-send-email-marc.ceeeee@gmail.com>
On Tue, Jan 14, 2014 at 11:48:51PM +0000, Marc Carino wrote:
> Document the bindings that the Broadcom STB platform needs
> for proper bootup.
>
> Signed-off-by: Marc Carino <marc.ceeeee@gmail.com>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> .../devicetree/bindings/arm/brcm-brcmstb.txt | 43 ++++++++++++++++++++
> 1 files changed, 43 insertions(+), 0 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/arm/brcm-brcmstb.txt
>
> diff --git a/Documentation/devicetree/bindings/arm/brcm-brcmstb.txt b/Documentation/devicetree/bindings/arm/brcm-brcmstb.txt
> new file mode 100644
> index 0000000..5f1aba7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/brcm-brcmstb.txt
> @@ -0,0 +1,43 @@
> +Broadcom STB platforms Device Tree Bindings
> +-------------------------------------------
> +Boards with Broadcom Brahma15 ARM-based BCM7xxx SoC shall have the following
> +properties.
> +
> +Required root node properties:
> +
> + - compatible = "brcm,brcmstb-<chip_id>";
I'd prefer it if variants were listed explicitly (as it makes it far
easier to grep for). Something like:
- compatible: should contain one of:
* "brcm,brcmsrb-7445"
* "brcm,brcmsrb-7446"
> +
> +Further, a node with the following compatible string shall be defined:
> +
> + - compatible: "brcm,brcmstb-gen-ctrl-v1"
It's probably better to say a brcmstb-gen-ctrl node (described below)
should be present, or you'll have two places to update the compatible
strings for each new variant...
> +
> +brcmstb-gen-ctrl
> +----------------
> +This node describes the registers needed for reset and CPU power control.
> +
> + - compatible: "brcm,brcmstb-gen-ctrl-v1"
> + - properties:
This looks odd, compatible is itself a property.
> + o reg = <rst-src-en-reg-base len
> + sw-mstr-rst-reg-base len
> + cpu-rst-cfg-reg-base len
> + cpu-pwr-zone-ctrl-reg-base len
> + stb-boot-hi-addr0-reg len>;
This would be nicer as something like follows, but with less
abberviation (unless these names are from a datasheet for the hardware).
- reg: a list of base-address size pairs:
* The first entry should cover the sw-mstr-rst registers
* The second entry should cover the cpu-rst-cfg registers
* The third entry should cover the cpu-pwr-zone registers
* The fourth entry should cover the stb-boot-hi-addr0 registers
It may make sense to use reg-names, future revisions might change
things.
> +
> +example:
> +/ {
> + model = "Broadcom STB";
> + compatible = "brcm,brcmstb-7445";
> +
> + /* snip */
> +
> + gen-ctrl {
> + compatible = "brcm,brcmstb-gen-ctrl-v1";
> + reg = <0xf0404304 0x4
> + 0xf0404308 0x4
> + 0xf03e2578 0x4
> + 0xf03e2488 0x10
> + 0xf0452000 0x20>;
Nit: please bracket each entry individually:
reg = <0xf0404304 0x4>,
<0xf0404308 0x4>,
<0xf03e2578 0x4>,
<0xf03e2488 0x10>,
<0xf0452000 0x20>;
Also, these look to be single registers in a larger register bank. Is
there any reason you can't describe the bank(s) they are in? That'll
give you more flexibility in the driver...
Thanks,
Mark
next prev parent reply other threads:[~2014-01-15 17:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 23:48 [PATCH v3 0/7] ARM: brcmstb: Add Broadcom STB SoC support Marc Carino
2014-01-14 23:48 ` [PATCH v3 1/7] ARM: brcmstb: add infrastructure for ARM-based Broadcom STB SoCs Marc Carino
2014-01-14 23:48 ` [PATCH v3 2/7] ARM: brcmstb: add debug UART for earlyprintk support Marc Carino
2014-01-14 23:48 ` [PATCH v3 3/7] ARM: do CPU-specific init for Broadcom Brahma15 cores Marc Carino
2014-01-15 17:19 ` Will Deacon
2014-01-14 23:48 ` [PATCH v3 4/7] ARM: brcmstb: add CPU binding for Broadcom Brahma15 Marc Carino
2014-01-15 16:58 ` Mark Rutland
2014-01-14 23:48 ` [PATCH v3 5/7] ARM: brcmstb: add misc. DT bindings for brcm,brcmstb-* Marc Carino
2014-01-15 17:11 ` Mark Rutland [this message]
2014-01-15 17:15 ` Arnd Bergmann
2014-01-15 17:55 ` Florian Fainelli
2014-01-14 23:48 ` [PATCH v3 6/7] ARM: brcmstb: gic: add compatible string for Broadcom Brahma15 Marc Carino
2014-01-15 17:20 ` Mark Rutland
2014-01-14 23:48 ` [PATCH v3 7/7] ARM: brcmstb: dts: add a reference DTS for Broadcom 7445 Marc Carino
2014-01-15 13:10 ` Arnd Bergmann
2014-01-15 18:22 ` Marc
2014-01-16 1:03 ` Marc C
2014-01-16 11:19 ` Arnd Bergmann
2014-01-16 13:37 ` Michal Simek
2014-01-16 13:47 ` Mark Brown
2014-01-17 17:04 ` Arnd Bergmann
2014-01-23 8:58 ` Michal Simek
2014-01-23 12:25 ` Mark Brown
2014-01-15 17:40 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140115171155.GK25824@e106331-lin.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=arnd@arndb.de \
--cc=bcm@fixthebug.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.ceeeee@gmail.com \
--cc=matt.porter@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).