* [RESEND PATCH] ARM: dts: bcm28155-ap: Fix Card Detection GPIO
@ 2014-01-07 18:53 Tim Kryger
2014-01-08 23:38 ` Christian Daudt
0 siblings, 1 reply; 7+ messages in thread
From: Tim Kryger @ 2014-01-07 18:53 UTC (permalink / raw)
To: Christian Daudt, Rob Herring, Pawel Moll, Mark Rutland,
Stephen Warren, Ian Campbell
Cc: Tim Kryger, Broadcom Kernel Feedback List, Device Tree List,
Linux Arm Kernel List, Linux Kernel Mailing List, Linaro Patches
The board schematic states that the "SD_CARD_DET_N gets pulled to GND
when card is inserted" so the polarity has been updated to active low.
Polarity is now specified with a GPIO define instead of a magic number.
Signed-off-by: Tim Kryger <tim.kryger@linaro.org>
Reviewed-by: Matt Porter <matt.porter@linaro.org>
---
arch/arm/boot/dts/bcm28155-ap.dts | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts
index 08e47c2..27dd110 100644
--- a/arch/arm/boot/dts/bcm28155-ap.dts
+++ b/arch/arm/boot/dts/bcm28155-ap.dts
@@ -13,6 +13,8 @@
/dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
+
#include "bcm11351.dtsi"
/ {
@@ -40,7 +42,7 @@
sdio4: sdio@3f1b0000 {
max-frequency = <48000000>;
- cd-gpios = <&gpio 14 0>;
+ cd-gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
status = "okay";
};
};
--
1.8.0.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH] ARM: dts: bcm28155-ap: Fix Card Detection GPIO
2014-01-07 18:53 [RESEND PATCH] ARM: dts: bcm28155-ap: Fix Card Detection GPIO Tim Kryger
@ 2014-01-08 23:38 ` Christian Daudt
2014-01-09 0:28 ` Tim Kryger
0 siblings, 1 reply; 7+ messages in thread
From: Christian Daudt @ 2014-01-08 23:38 UTC (permalink / raw)
To: Tim Kryger
Cc: Rob Herring, Pawel Moll, Mark Rutland, Stephen Warren,
Ian Campbell, Broadcom Kernel Feedback List, Device Tree List,
Linux Arm Kernel List, Linux Kernel Mailing List, Linaro Patches
On Tue, Jan 7, 2014 at 10:53 AM, Tim Kryger <tim.kryger@linaro.org> wrote:
> The board schematic states that the "SD_CARD_DET_N gets pulled to GND
> when card is inserted" so the polarity has been updated to active low.
>
> Polarity is now specified with a GPIO define instead of a magic number.
>
> Signed-off-by: Tim Kryger <tim.kryger@linaro.org>
> Reviewed-by: Matt Porter <matt.porter@linaro.org>
> ---
> arch/arm/boot/dts/bcm28155-ap.dts | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts
> index 08e47c2..27dd110 100644
> --- a/arch/arm/boot/dts/bcm28155-ap.dts
> +++ b/arch/arm/boot/dts/bcm28155-ap.dts
> @@ -13,6 +13,8 @@
>
> /dts-v1/;
>
> +#include <dt-bindings/gpio/gpio.h>
> +
> #include "bcm11351.dtsi"
>
> / {
> @@ -40,7 +42,7 @@
>
> sdio4: sdio@3f1b0000 {
> max-frequency = <48000000>;
> - cd-gpios = <&gpio 14 0>;
> + cd-gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
> status = "okay";
> };
> };
> --
> 1.8.0.1
>
Tim,
Does bcm11351-brt not also suffer from the same bug? If it does can
you pls update the patch to also fix it?
Thanks,
csd
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH] ARM: dts: bcm28155-ap: Fix Card Detection GPIO
2014-01-08 23:38 ` Christian Daudt
@ 2014-01-09 0:28 ` Tim Kryger
2014-01-09 0:54 ` Christian Daudt
0 siblings, 1 reply; 7+ messages in thread
From: Tim Kryger @ 2014-01-09 0:28 UTC (permalink / raw)
To: Christian Daudt
Cc: Rob Herring, Pawel Moll, Mark Rutland, Stephen Warren,
Ian Campbell, Broadcom Kernel Feedback List, Device Tree List,
Linux Arm Kernel List, Linux Kernel Mailing List, Linaro Patches
On Wed, Jan 8, 2014 at 3:38 PM, Christian Daudt <bcm@fixthebug.org> wrote:
> On Tue, Jan 7, 2014 at 10:53 AM, Tim Kryger <tim.kryger@linaro.org> wrote:
>> The board schematic states that the "SD_CARD_DET_N gets pulled to GND
>> when card is inserted" so the polarity has been updated to active low.
>>
>> Polarity is now specified with a GPIO define instead of a magic number.
>>
>> Signed-off-by: Tim Kryger <tim.kryger@linaro.org>
>> Reviewed-by: Matt Porter <matt.porter@linaro.org>
>> ---
>> arch/arm/boot/dts/bcm28155-ap.dts | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts
>> index 08e47c2..27dd110 100644
>> --- a/arch/arm/boot/dts/bcm28155-ap.dts
>> +++ b/arch/arm/boot/dts/bcm28155-ap.dts
>> @@ -13,6 +13,8 @@
>>
>> /dts-v1/;
>>
>> +#include <dt-bindings/gpio/gpio.h>
>> +
>> #include "bcm11351.dtsi"
>>
>> / {
>> @@ -40,7 +42,7 @@
>>
>> sdio4: sdio@3f1b0000 {
>> max-frequency = <48000000>;
>> - cd-gpios = <&gpio 14 0>;
>> + cd-gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
>> status = "okay";
>> };
>> };
>> --
>> 1.8.0.1
>>
> Tim,
> Does bcm11351-brt not also suffer from the same bug? If it does can
> you pls update the patch to also fix it?
>
> Thanks,
> csd
The BRT and AP boards are similar so it may have the same problem but
I don't have a BRT and wouldn't be able to test any changes to its DTS
file.
-Tim
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH] ARM: dts: bcm28155-ap: Fix Card Detection GPIO
2014-01-09 0:28 ` Tim Kryger
@ 2014-01-09 0:54 ` Christian Daudt
2014-01-24 18:48 ` Tim Kryger
0 siblings, 1 reply; 7+ messages in thread
From: Christian Daudt @ 2014-01-09 0:54 UTC (permalink / raw)
To: Tim Kryger
Cc: Rob Herring, Pawel Moll, Mark Rutland, Stephen Warren,
Ian Campbell, Broadcom Kernel Feedback List, Device Tree List,
Linux Arm Kernel List, Linux Kernel Mailing List, Linaro Patches
On Wed, Jan 8, 2014 at 4:28 PM, Tim Kryger <tim.kryger@linaro.org> wrote:
> On Wed, Jan 8, 2014 at 3:38 PM, Christian Daudt <bcm@fixthebug.org> wrote:
>> On Tue, Jan 7, 2014 at 10:53 AM, Tim Kryger <tim.kryger@linaro.org> wrote:
>>> The board schematic states that the "SD_CARD_DET_N gets pulled to GND
>>> when card is inserted" so the polarity has been updated to active low.
>>>
>>> Polarity is now specified with a GPIO define instead of a magic number.
>>>
>>> Signed-off-by: Tim Kryger <tim.kryger@linaro.org>
>>> Reviewed-by: Matt Porter <matt.porter@linaro.org>
>>> ---
>>> arch/arm/boot/dts/bcm28155-ap.dts | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts
>>> index 08e47c2..27dd110 100644
>>> --- a/arch/arm/boot/dts/bcm28155-ap.dts
>>> +++ b/arch/arm/boot/dts/bcm28155-ap.dts
>>> @@ -13,6 +13,8 @@
>>>
>>> /dts-v1/;
>>>
>>> +#include <dt-bindings/gpio/gpio.h>
>>> +
>>> #include "bcm11351.dtsi"
>>>
>>> / {
>>> @@ -40,7 +42,7 @@
>>>
>>> sdio4: sdio@3f1b0000 {
>>> max-frequency = <48000000>;
>>> - cd-gpios = <&gpio 14 0>;
>>> + cd-gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
>>> status = "okay";
>>> };
>>> };
>>> --
>>> 1.8.0.1
>>>
>> Tim,
>> Does bcm11351-brt not also suffer from the same bug? If it does can
>> you pls update the patch to also fix it?
>>
>> Thanks,
>> csd
>
> The BRT and AP boards are similar so it may have the same problem but
> I don't have a BRT and wouldn't be able to test any changes to its DTS
> file.
>
> -Tim
[sorry for the resend for those that get it twice]
Agreed - it's time that dts file go away. In this case:
Acked-by: Christian Daudt <bcm@fixthebug.org>
Olof - can you pls pull in this patch. This is the bugfix that was
discussed in irc earlier today.
thanks,
csd
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH] ARM: dts: bcm28155-ap: Fix Card Detection GPIO
2014-01-09 0:54 ` Christian Daudt
@ 2014-01-24 18:48 ` Tim Kryger
2014-01-31 23:11 ` Olof Johansson
0 siblings, 1 reply; 7+ messages in thread
From: Tim Kryger @ 2014-01-24 18:48 UTC (permalink / raw)
To: Christian Daudt
Cc: Rob Herring, Pawel Moll, Mark Rutland, Stephen Warren,
Ian Campbell, Broadcom Kernel Feedback List, Device Tree List,
Linux Arm Kernel List, Linux Kernel Mailing List, Linaro Patches,
Olof Johansson, Kevin Hilman
On Wed, Jan 8, 2014 at 4:54 PM, Christian Daudt <bcm@fixthebug.org> wrote:
> On Wed, Jan 8, 2014 at 4:28 PM, Tim Kryger <tim.kryger@linaro.org> wrote:
>> On Wed, Jan 8, 2014 at 3:38 PM, Christian Daudt <bcm@fixthebug.org> wrote:
>>> On Tue, Jan 7, 2014 at 10:53 AM, Tim Kryger <tim.kryger@linaro.org> wrote:
>>>> The board schematic states that the "SD_CARD_DET_N gets pulled to GND
>>>> when card is inserted" so the polarity has been updated to active low.
>>>>
>>>> Polarity is now specified with a GPIO define instead of a magic number.
>>>>
>>>> Signed-off-by: Tim Kryger <tim.kryger@linaro.org>
>>>> Reviewed-by: Matt Porter <matt.porter@linaro.org>
>>>> ---
>>>> arch/arm/boot/dts/bcm28155-ap.dts | 4 +++-
>>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts
>>>> index 08e47c2..27dd110 100644
>>>> --- a/arch/arm/boot/dts/bcm28155-ap.dts
>>>> +++ b/arch/arm/boot/dts/bcm28155-ap.dts
>>>> @@ -13,6 +13,8 @@
>>>>
>>>> /dts-v1/;
>>>>
>>>> +#include <dt-bindings/gpio/gpio.h>
>>>> +
>>>> #include "bcm11351.dtsi"
>>>>
>>>> / {
>>>> @@ -40,7 +42,7 @@
>>>>
>>>> sdio4: sdio@3f1b0000 {
>>>> max-frequency = <48000000>;
>>>> - cd-gpios = <&gpio 14 0>;
>>>> + cd-gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
>>>> status = "okay";
>>>> };
>>>> };
>>>> --
>>>> 1.8.0.1
>>>>
>>> Tim,
>>> Does bcm11351-brt not also suffer from the same bug? If it does can
>>> you pls update the patch to also fix it?
>>>
>>> Thanks,
>>> csd
>>
>> The BRT and AP boards are similar so it may have the same problem but
>> I don't have a BRT and wouldn't be able to test any changes to its DTS
>> file.
>>
>> -Tim
>
> [sorry for the resend for those that get it twice]
> Agreed - it's time that dts file go away. In this case:
> Acked-by: Christian Daudt <bcm@fixthebug.org>
>
> Olof - can you pls pull in this patch. This is the bugfix that was
> discussed in irc earlier today.
>
> thanks,
> csd
Christian,
I'm not sure Olof saw your reply. Olof and Kevin are now on CC.
Thanks,
Tim Kryger
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH] ARM: dts: bcm28155-ap: Fix Card Detection GPIO
2014-01-24 18:48 ` Tim Kryger
@ 2014-01-31 23:11 ` Olof Johansson
0 siblings, 0 replies; 7+ messages in thread
From: Olof Johansson @ 2014-01-31 23:11 UTC (permalink / raw)
To: Tim Kryger
Cc: Christian Daudt, Rob Herring, Pawel Moll, Mark Rutland,
Stephen Warren, Ian Campbell, Broadcom Kernel Feedback List,
Device Tree List, Linux Arm Kernel List,
Linux Kernel Mailing List, Linaro Patches, Kevin Hilman
On Fri, Jan 24, 2014 at 10:48:40AM -0800, Tim Kryger wrote:
> On Wed, Jan 8, 2014 at 4:54 PM, Christian Daudt <bcm@fixthebug.org> wrote:
> > On Wed, Jan 8, 2014 at 4:28 PM, Tim Kryger <tim.kryger@linaro.org> wrote:
> >> On Wed, Jan 8, 2014 at 3:38 PM, Christian Daudt <bcm@fixthebug.org> wrote:
> >>> On Tue, Jan 7, 2014 at 10:53 AM, Tim Kryger <tim.kryger@linaro.org> wrote:
> >>>> The board schematic states that the "SD_CARD_DET_N gets pulled to GND
> >>>> when card is inserted" so the polarity has been updated to active low.
> >>>>
> >>>> Polarity is now specified with a GPIO define instead of a magic number.
> >>>>
> >>>> Signed-off-by: Tim Kryger <tim.kryger@linaro.org>
> >>>> Reviewed-by: Matt Porter <matt.porter@linaro.org>
> >>>> ---
> >>>> arch/arm/boot/dts/bcm28155-ap.dts | 4 +++-
> >>>> 1 file changed, 3 insertions(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts
> >>>> index 08e47c2..27dd110 100644
> >>>> --- a/arch/arm/boot/dts/bcm28155-ap.dts
> >>>> +++ b/arch/arm/boot/dts/bcm28155-ap.dts
> >>>> @@ -13,6 +13,8 @@
> >>>>
> >>>> /dts-v1/;
> >>>>
> >>>> +#include <dt-bindings/gpio/gpio.h>
> >>>> +
> >>>> #include "bcm11351.dtsi"
> >>>>
> >>>> / {
> >>>> @@ -40,7 +42,7 @@
> >>>>
> >>>> sdio4: sdio@3f1b0000 {
> >>>> max-frequency = <48000000>;
> >>>> - cd-gpios = <&gpio 14 0>;
> >>>> + cd-gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
> >>>> status = "okay";
> >>>> };
> >>>> };
> >>>> --
> >>>> 1.8.0.1
> >>>>
> >>> Tim,
> >>> Does bcm11351-brt not also suffer from the same bug? If it does can
> >>> you pls update the patch to also fix it?
> >>>
> >>> Thanks,
> >>> csd
> >>
> >> The BRT and AP boards are similar so it may have the same problem but
> >> I don't have a BRT and wouldn't be able to test any changes to its DTS
> >> file.
> >>
> >> -Tim
> >
> > [sorry for the resend for those that get it twice]
> > Agreed - it's time that dts file go away. In this case:
> > Acked-by: Christian Daudt <bcm@fixthebug.org>
> >
> > Olof - can you pls pull in this patch. This is the bugfix that was
> > discussed in irc earlier today.
> >
> > thanks,
> > csd
>
> Christian,
>
> I'm not sure Olof saw your reply. Olof and Kevin are now on CC.
Nope, applied now. Had to touch it up a bit since we're missing some of the
patches that this was based on for 3.14, but the cd-gpios property is fixed.
-Olof
^ permalink raw reply [flat|nested] 7+ messages in thread
* [RESEND PATCH] ARM: dts: bcm28155-ap: Fix Card Detection GPIO
@ 2013-12-05 21:51 Tim Kryger
0 siblings, 0 replies; 7+ messages in thread
From: Tim Kryger @ 2013-12-05 21:51 UTC (permalink / raw)
To: Christian Daudt, Rob Herring, Pawel Moll, Mark Rutland,
Stephen Warren, Ian Campbell
Cc: Tim Kryger, Broadcom Kernel Feedback List, Device Tree List,
Linux Arm Kernel List, Linux Kernel Mailing List, Linaro Patches
The board schematic states that the "SD_CARD_DET_N gets pulled to GND
when card is inserted" so the polarity has been updated to active low.
Polarity is now specified with a GPIO define instead of a magic number.
Signed-off-by: Tim Kryger <tim.kryger@linaro.org>
Reviewed-by: Matt Porter <matt.porter@linaro.org>
---
arch/arm/boot/dts/bcm28155-ap.dts | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/bcm28155-ap.dts b/arch/arm/boot/dts/bcm28155-ap.dts
index 08e47c2..27dd110 100644
--- a/arch/arm/boot/dts/bcm28155-ap.dts
+++ b/arch/arm/boot/dts/bcm28155-ap.dts
@@ -13,6 +13,8 @@
/dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
+
#include "bcm11351.dtsi"
/ {
@@ -40,7 +42,7 @@
sdio4: sdio@3f1b0000 {
max-frequency = <48000000>;
- cd-gpios = <&gpio 14 0>;
+ cd-gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
status = "okay";
};
};
--
1.8.0.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-01-31 23:13 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-07 18:53 [RESEND PATCH] ARM: dts: bcm28155-ap: Fix Card Detection GPIO Tim Kryger
2014-01-08 23:38 ` Christian Daudt
2014-01-09 0:28 ` Tim Kryger
2014-01-09 0:54 ` Christian Daudt
2014-01-24 18:48 ` Tim Kryger
2014-01-31 23:11 ` Olof Johansson
-- strict thread matches above, loose matches on Subject: below --
2013-12-05 21:51 Tim Kryger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).