* [PATCH 1/1] ext2: Add __init macro to init_inodecache
@ 2014-02-01 8:02 Fabian Frederick
2014-02-01 17:53 ` Matthew Wilcox
2014-02-03 23:56 ` Jan Kara
0 siblings, 2 replies; 4+ messages in thread
From: Fabian Frederick @ 2014-02-01 8:02 UTC (permalink / raw)
To: linux-kernel; +Cc: jack, linux-ext4
init_inodecache is only called by __init init_ext2_fs.
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
fs/ext2/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 20d6697..73d80da 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -192,7 +192,7 @@ static void init_once(void *foo)
inode_init_once(&ei->vfs_inode);
}
-static int init_inodecache(void)
+static int __init init_inodecache(void)
{
ext2_inode_cachep = kmem_cache_create("ext2_inode_cache",
sizeof(struct ext2_inode_info),
--
1.8.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] ext2: Add __init macro to init_inodecache
2014-02-01 17:53 ` Matthew Wilcox
@ 2014-02-01 10:19 ` Fabian Frederick
0 siblings, 0 replies; 4+ messages in thread
From: Fabian Frederick @ 2014-02-01 10:19 UTC (permalink / raw)
To: Matthew Wilcox; +Cc: linux-kernel, jack, linux-ext4
On Sat, 1 Feb 2014 10:53:34 -0700
Matthew Wilcox <matthew@wil.cx> wrote:
> On Sat, Feb 01, 2014 at 04:02:02PM +0800, Fabian Frederick wrote:
> > init_inodecache is only called by __init init_ext2_fs.
>
> Looks like this is true for the majority of filesystems. Would you care
> to submit more patches? :-)
No problem ! Is it better to send separate patches like this one or one patch for all filesystems ?
>
> --
> Matthew Wilcox Intel Open Source Technology Centre
> "Bill, look, we understand that you're interested in selling us this
> operating system, but compare it to ours. We can't possibly take such
> a retrograde step."
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] ext2: Add __init macro to init_inodecache
2014-02-01 8:02 [PATCH 1/1] ext2: Add __init macro to init_inodecache Fabian Frederick
@ 2014-02-01 17:53 ` Matthew Wilcox
2014-02-01 10:19 ` Fabian Frederick
2014-02-03 23:56 ` Jan Kara
1 sibling, 1 reply; 4+ messages in thread
From: Matthew Wilcox @ 2014-02-01 17:53 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, jack, linux-ext4
On Sat, Feb 01, 2014 at 04:02:02PM +0800, Fabian Frederick wrote:
> init_inodecache is only called by __init init_ext2_fs.
Looks like this is true for the majority of filesystems. Would you care
to submit more patches? :-)
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] ext2: Add __init macro to init_inodecache
2014-02-01 8:02 [PATCH 1/1] ext2: Add __init macro to init_inodecache Fabian Frederick
2014-02-01 17:53 ` Matthew Wilcox
@ 2014-02-03 23:56 ` Jan Kara
1 sibling, 0 replies; 4+ messages in thread
From: Jan Kara @ 2014-02-03 23:56 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, jack, linux-ext4
On Sat 01-02-14 16:02:02, Fabian Frederick wrote:
> init_inodecache is only called by __init init_ext2_fs.
Thanks added to my tree.
Honza
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> fs/ext2/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index 20d6697..73d80da 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -192,7 +192,7 @@ static void init_once(void *foo)
> inode_init_once(&ei->vfs_inode);
> }
>
> -static int init_inodecache(void)
> +static int __init init_inodecache(void)
> {
> ext2_inode_cachep = kmem_cache_create("ext2_inode_cache",
> sizeof(struct ext2_inode_info),
> --
> 1.8.1.4
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-03 23:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-01 8:02 [PATCH 1/1] ext2: Add __init macro to init_inodecache Fabian Frederick
2014-02-01 17:53 ` Matthew Wilcox
2014-02-01 10:19 ` Fabian Frederick
2014-02-03 23:56 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).