* [PATCH] ACPI / video: Add HP EliteBook Revolve 810 to the blacklist
@ 2014-02-03 10:59 Mika Westerberg
2014-02-07 1:29 ` Aaron Lu
0 siblings, 1 reply; 6+ messages in thread
From: Mika Westerberg @ 2014-02-03 10:59 UTC (permalink / raw)
To: linux-acpi
Cc: Rafael J. Wysocki, Len Brown, Aaron Lu, linux-kernel, Mika Westerberg
On HP EliteBook Revolve 810 the ACPI backlight device doesn't work as
expected. For example when resuming from system sleep, it seems to lose
backlight settings.
Forcing Intel driver fixes the problem so add this machine the ACPI
video detect blacklist.
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/acpi/video_detect.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index f0447d3daf2c..a697b77b8865 100644
--- a/drivers/acpi/video_detect.c
+++ b/drivers/acpi/video_detect.c
@@ -170,6 +170,14 @@ static struct dmi_system_id video_detect_dmi_table[] = {
},
{
.callback = video_detect_force_vendor,
+ .ident = "HP EliteBook Revolve 810",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook Revolve 810 G1"),
+ },
+ },
+ {
+ .callback = video_detect_force_vendor,
.ident = "Lenovo Yoga 13",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI / video: Add HP EliteBook Revolve 810 to the blacklist
2014-02-03 10:59 [PATCH] ACPI / video: Add HP EliteBook Revolve 810 to the blacklist Mika Westerberg
@ 2014-02-07 1:29 ` Aaron Lu
2014-02-07 10:25 ` Mika Westerberg
0 siblings, 1 reply; 6+ messages in thread
From: Aaron Lu @ 2014-02-07 1:29 UTC (permalink / raw)
To: Mika Westerberg, linux-acpi; +Cc: Rafael J. Wysocki, Len Brown, linux-kernel
On 02/03/2014 06:59 PM, Mika Westerberg wrote:
> On HP EliteBook Revolve 810 the ACPI backlight device doesn't work as
> expected. For example when resuming from system sleep, it seems to lose
> backlight settings.
>
> Forcing Intel driver fixes the problem so add this machine the ACPI
> video detect blacklist.
For reference's purpose, can you please file a bug to kernel bugzilla
under the ACPI/Power-Video category and attach the acpidump and dmesg
there? Thanks.
-Aaron
>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> drivers/acpi/video_detect.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
> index f0447d3daf2c..a697b77b8865 100644
> --- a/drivers/acpi/video_detect.c
> +++ b/drivers/acpi/video_detect.c
> @@ -170,6 +170,14 @@ static struct dmi_system_id video_detect_dmi_table[] = {
> },
> {
> .callback = video_detect_force_vendor,
> + .ident = "HP EliteBook Revolve 810",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "HP EliteBook Revolve 810 G1"),
> + },
> + },
> + {
> + .callback = video_detect_force_vendor,
> .ident = "Lenovo Yoga 13",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI / video: Add HP EliteBook Revolve 810 to the blacklist
2014-02-07 1:29 ` Aaron Lu
@ 2014-02-07 10:25 ` Mika Westerberg
2014-02-12 2:31 ` Aaron Lu
0 siblings, 1 reply; 6+ messages in thread
From: Mika Westerberg @ 2014-02-07 10:25 UTC (permalink / raw)
To: Aaron Lu; +Cc: linux-acpi, Rafael J. Wysocki, Len Brown, linux-kernel
On Fri, Feb 07, 2014 at 09:29:58AM +0800, Aaron Lu wrote:
> On 02/03/2014 06:59 PM, Mika Westerberg wrote:
> > On HP EliteBook Revolve 810 the ACPI backlight device doesn't work as
> > expected. For example when resuming from system sleep, it seems to lose
> > backlight settings.
> >
> > Forcing Intel driver fixes the problem so add this machine the ACPI
> > video detect blacklist.
>
> For reference's purpose, can you please file a bug to kernel bugzilla
> under the ACPI/Power-Video category and attach the acpidump and dmesg
> there? Thanks.
Done, the bug is here:
https://bugzilla.kernel.org/show_bug.cgi?id=70231
I noticed that using only the acpi_video0 for tuning backlight works but if
I use intel_backlight directly, on resume I get values from acpi_video0
instead. I'm not really familiar how this is supposed to work, though so
please let me know if I'm missing something.
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI / video: Add HP EliteBook Revolve 810 to the blacklist
2014-02-07 10:25 ` Mika Westerberg
@ 2014-02-12 2:31 ` Aaron Lu
2014-02-12 9:34 ` Mika Westerberg
0 siblings, 1 reply; 6+ messages in thread
From: Aaron Lu @ 2014-02-12 2:31 UTC (permalink / raw)
To: Mika Westerberg; +Cc: linux-acpi, Rafael J. Wysocki, Len Brown, linux-kernel
On 02/07/2014 06:25 PM, Mika Westerberg wrote:
> On Fri, Feb 07, 2014 at 09:29:58AM +0800, Aaron Lu wrote:
>> On 02/03/2014 06:59 PM, Mika Westerberg wrote:
>>> On HP EliteBook Revolve 810 the ACPI backlight device doesn't work as
>>> expected. For example when resuming from system sleep, it seems to lose
>>> backlight settings.
>>>
>>> Forcing Intel driver fixes the problem so add this machine the ACPI
>>> video detect blacklist.
>>
>> For reference's purpose, can you please file a bug to kernel bugzilla
>> under the ACPI/Power-Video category and attach the acpidump and dmesg
>> there? Thanks.
>
> Done, the bug is here:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=70231
>
> I noticed that using only the acpi_video0 for tuning backlight works but if
> I use intel_backlight directly, on resume I get values from acpi_video0
> instead. I'm not really familiar how this is supposed to work, though so
> please let me know if I'm missing something.
Thanks for the report, as communicated on the bug page, your system is
already blacklisted for win8 by commit:
commit 2d4054d8422462cb2771fdb4eb1925df55d2b320
Author: Takashi Iwai <tiwai@suse.de> Fri Dec 20 00:09:12 2013
Committer: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Fri Dec 20 22:50:56 2013
ACPI: Blacklist Win8 OSI for some HP laptop 2013 models
And the fact that acpi_video interface works made it not appropriate to
add your system into the video_detect_dmi_table. You can just use acpi_video
interface and everything should work fine.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI / video: Add HP EliteBook Revolve 810 to the blacklist
2014-02-12 2:31 ` Aaron Lu
@ 2014-02-12 9:34 ` Mika Westerberg
2014-02-13 1:09 ` Aaron Lu
0 siblings, 1 reply; 6+ messages in thread
From: Mika Westerberg @ 2014-02-12 9:34 UTC (permalink / raw)
To: Aaron Lu; +Cc: linux-acpi, Rafael J. Wysocki, Len Brown, linux-kernel
On Wed, Feb 12, 2014 at 10:31:59AM +0800, Aaron Lu wrote:
> On 02/07/2014 06:25 PM, Mika Westerberg wrote:
> > On Fri, Feb 07, 2014 at 09:29:58AM +0800, Aaron Lu wrote:
> >> On 02/03/2014 06:59 PM, Mika Westerberg wrote:
> >>> On HP EliteBook Revolve 810 the ACPI backlight device doesn't work as
> >>> expected. For example when resuming from system sleep, it seems to lose
> >>> backlight settings.
> >>>
> >>> Forcing Intel driver fixes the problem so add this machine the ACPI
> >>> video detect blacklist.
> >>
> >> For reference's purpose, can you please file a bug to kernel bugzilla
> >> under the ACPI/Power-Video category and attach the acpidump and dmesg
> >> there? Thanks.
> >
> > Done, the bug is here:
> >
> > https://bugzilla.kernel.org/show_bug.cgi?id=70231
> >
> > I noticed that using only the acpi_video0 for tuning backlight works but if
> > I use intel_backlight directly, on resume I get values from acpi_video0
> > instead. I'm not really familiar how this is supposed to work, though so
> > please let me know if I'm missing something.
>
> Thanks for the report, as communicated on the bug page, your system is
> already blacklisted for win8 by commit:
>
> commit 2d4054d8422462cb2771fdb4eb1925df55d2b320
> Author: Takashi Iwai <tiwai@suse.de> Fri Dec 20 00:09:12 2013
> Committer: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Fri Dec 20 22:50:56 2013
>
> ACPI: Blacklist Win8 OSI for some HP laptop 2013 models
>
> And the fact that acpi_video interface works made it not appropriate to
> add your system into the video_detect_dmi_table. You can just use acpi_video
> interface and everything should work fine.
OK, thanks for the investigation Aaron.
I have few questions, though.
1) Is it always right thing to do to use acpi_video0 over anything else?
In my case that device first disapeared and then reappeared so I got kind
of confused about that. I'm going to tune my scripts to use acpi_video0 as
you suggested.
2) What should we do with this commit? It is already in mainline so I
guess revert is the sane thing to do.
I should have asked/investigated this more before submitting the patch.
Sorry about that.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ACPI / video: Add HP EliteBook Revolve 810 to the blacklist
2014-02-12 9:34 ` Mika Westerberg
@ 2014-02-13 1:09 ` Aaron Lu
0 siblings, 0 replies; 6+ messages in thread
From: Aaron Lu @ 2014-02-13 1:09 UTC (permalink / raw)
To: Mika Westerberg; +Cc: linux-acpi, Rafael J. Wysocki, Len Brown, linux-kernel
On 02/12/2014 05:34 PM, Mika Westerberg wrote:
> On Wed, Feb 12, 2014 at 10:31:59AM +0800, Aaron Lu wrote:
>> On 02/07/2014 06:25 PM, Mika Westerberg wrote:
>>> On Fri, Feb 07, 2014 at 09:29:58AM +0800, Aaron Lu wrote:
>>>> On 02/03/2014 06:59 PM, Mika Westerberg wrote:
>>>>> On HP EliteBook Revolve 810 the ACPI backlight device doesn't work as
>>>>> expected. For example when resuming from system sleep, it seems to lose
>>>>> backlight settings.
>>>>>
>>>>> Forcing Intel driver fixes the problem so add this machine the ACPI
>>>>> video detect blacklist.
>>>>
>>>> For reference's purpose, can you please file a bug to kernel bugzilla
>>>> under the ACPI/Power-Video category and attach the acpidump and dmesg
>>>> there? Thanks.
>>>
>>> Done, the bug is here:
>>>
>>> https://bugzilla.kernel.org/show_bug.cgi?id=70231
>>>
>>> I noticed that using only the acpi_video0 for tuning backlight works but if
>>> I use intel_backlight directly, on resume I get values from acpi_video0
>>> instead. I'm not really familiar how this is supposed to work, though so
>>> please let me know if I'm missing something.
>>
>> Thanks for the report, as communicated on the bug page, your system is
>> already blacklisted for win8 by commit:
>>
>> commit 2d4054d8422462cb2771fdb4eb1925df55d2b320
>> Author: Takashi Iwai <tiwai@suse.de> Fri Dec 20 00:09:12 2013
>> Committer: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Fri Dec 20 22:50:56 2013
>>
>> ACPI: Blacklist Win8 OSI for some HP laptop 2013 models
>>
>> And the fact that acpi_video interface works made it not appropriate to
>> add your system into the video_detect_dmi_table. You can just use acpi_video
>> interface and everything should work fine.
>
> OK, thanks for the investigation Aaron.
>
> I have few questions, though.
>
> 1) Is it always right thing to do to use acpi_video0 over anything else?
Not necessarily I think. X will pick an interface to use and AFAIK, the X
driver for i915 favour acpi_video over the native one for some reason. But
of course you can override that in xorg.conf, I think this is the way you
have done, right?
> In my case that device first disapeared and then reappeared so I got kind
It is disappeared by some of my patches that didn't get into mainline :-)
> of confused about that. I'm going to tune my scripts to use acpi_video0 as
> you suggested.
It seems to be the guideline that kernel just provides functionality
without doing any decision. From this perspective, it seems to be a
correct thing for kernel to expose as many interfaces as possible as
long as they are not broken and leaving the decision on which interface
to use to user space. The fact that ACPI video driver will restore
backlight setting according to its own knowledge is not a right thing
to do IMO, how does it know that user space is using it? I would like
to remove that in video's resume callback but then I guess some user
would report regressions since I suppose the GUI has relied on this
behaviour and doesn't do anything on resume.
>
> 2) What should we do with this commit? It is already in mainline so I
> guess revert is the sane thing to do.
I agree.
>
> I should have asked/investigated this more before submitting the patch.
> Sorry about that.
Never mind, the handling of backlight is in a confusing state anyway.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-13 1:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-03 10:59 [PATCH] ACPI / video: Add HP EliteBook Revolve 810 to the blacklist Mika Westerberg
2014-02-07 1:29 ` Aaron Lu
2014-02-07 10:25 ` Mika Westerberg
2014-02-12 2:31 ` Aaron Lu
2014-02-12 9:34 ` Mika Westerberg
2014-02-13 1:09 ` Aaron Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).