linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Richard Weinberger <richard@nod.at>,
	Ben Dooks <ben-linux@fluff.org>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Sangbeom Kim <sbkim73@samsung.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/28] Remove MACH_SMDKC210
Date: Mon, 10 Feb 2014 14:12:55 +0000	[thread overview]
Message-ID: <20140210141255.GI1757@sirena.org.uk> (raw)
In-Reply-To: <1392039072.3585.15.camel@x220>

[-- Attachment #1: Type: text/plain, Size: 1800 bytes --]

On Mon, Feb 10, 2014 at 02:31:12PM +0100, Paul Bolle wrote:
> On Mon, 2014-02-10 at 11:41 +0000, Mark Brown wrote:
> > On Sun, Feb 09, 2014 at 07:47:52PM +0100, Richard Weinberger wrote:

> > Please fix whatever script you're using to generate your mails, it's
> > generating corrupt headers.

> I think Richard's mail didn't end up on lkml. But it's pretty clear what
> it must have looked like.

I can see what it looked like from my inbox, but my mail client can't
understand them at all and hence didn't think the mails were sent to me
and just ignored them when hitting reply.

> > >  config SND_SOC_SAMSUNG_SMDK_WM9713
> > >  	tristate "SoC AC97 Audio support for SMDK with WM9713"
> > > -	depends on SND_SOC_SAMSUNG && (MACH_SMDK6410 || MACH_SMDKC100 || MACH_SMDKV210 || MACH_SMDKC110 || MACH_SMDKV310 || MACH_SMDKC210)
> > > +	depends on SND_SOC_SAMSUNG && (MACH_SMDK6410 || MACH_SMDKC100 || MACH_SMDKV210 || MACH_SMDKC110 || MACH_SMDKV310)
> > 
> > Like I said to Paul this isn't fixing the actual issue - think about why
> > the symbol was there in the first place and why it was removed.  There
> > is a problem here but this would make it less likely that it would be
> > properly fixed.

> Would you mind going through this one step at a time, just to make sure
> _I_ understand what it is that you'd like to see?

> If so, to be absolutely sure we start from the same point: do you agree
> that the above line now effectively reads
>     depends on SND_SOC_SAMSUNG && (MACH_SMDK6410 || MACH_SMDKC100 || MACH_SMDKV210 || MACH_SMDKC110 || false || false)

> because there's neither a Kconfig symbol MACH_SMDKV310 nor a Kconfig
> symbol MACH_SMDKC210?

Yes, that's correct.  Now, like I say think about what the symbol was
there for in the first place.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2014-02-10 14:13 UTC|newest]

Thread overview: 173+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-09 18:47 Remove orphan kconfig symbols Richard Weinberger
2014-02-09 18:47 ` [PATCH 01/28] Remove CPU_MMP3 Richard Weinberger
2014-02-09 22:07   ` Paul Bolle
2014-02-11 21:30   ` Greg Kroah-Hartman
2014-02-11 22:01     ` Paul Bolle
2014-02-12  7:52       ` Geert Uytterhoeven
2014-02-09 18:47 ` [PATCH 02/28] Remove OF_I2C Richard Weinberger
2014-02-09 19:58   ` Paul Bolle
2014-03-13 21:39   ` Wolfram Sang
2014-02-09 18:47 ` [PATCH 03/28] Remove MACH_BCM2708 Richard Weinberger
2014-02-09 20:02   ` Paul Bolle
2014-02-09 18:47 ` [PATCH 04/28] Remove EXYNOS_DEV_SYSMMU Richard Weinberger
2014-02-09 20:08   ` Paul Bolle
2014-02-10  4:32     ` Sachin Kamat
2014-04-15  9:33       ` Paul Bolle
2014-02-09 18:47 ` [PATCH 05/28] Remove MPILIB_EXTRA Richard Weinberger
2014-02-09 20:18   ` Paul Bolle
2014-04-15  9:06     ` Paul Bolle
2014-04-15  9:21       ` Borislav Petkov
2014-06-18  8:09         ` Paul Bolle
2014-06-18  9:48           ` Borislav Petkov
2014-06-18 10:38             ` Jiri Kosina
2014-06-18 14:18               ` [PATCH] [TRIVIAL] " Paul Bolle
2014-02-09 18:47 ` [PATCH 06/28] Remove PICOXCELL_PC3X3 Richard Weinberger
2014-02-09 20:28   ` Paul Bolle
2014-04-15  8:55     ` [PATCH] hwrng: remove unbuildable picoxcell TRNG Paul Bolle
2014-04-15 10:06       ` Jamie Iles
2014-04-16 13:50         ` Herbert Xu
2014-02-09 18:47 ` [PATCH 07/28] Remove CPU_PXA988 Richard Weinberger
2014-02-09 22:24   ` Paul Bolle
     [not found]     ` <52F800B2.6010702@nod.at>
2014-04-15  7:47       ` Paul Bolle
2014-04-15  7:50         ` Richard Weinberger
2014-02-09 18:47 ` [PATCH 08/28] Remove SYS_HAS_DMA_OPS Richard Weinberger
2014-02-09 21:44   ` Paul Bolle
2014-02-09 18:47 ` [PATCH 09/28] Remove ATHEROS_AR231X Richard Weinberger
2014-02-09 19:09   ` Joe Perches
2014-02-09 19:43     ` Paul Bolle
     [not found]   ` <52F7D480.1050106@hauke-m.de>
2014-02-09 20:03     ` Richard Weinberger
2014-02-10 12:05       ` Sergey Ryazanov
2014-02-10 12:17         ` Oleksij Rempel
2014-02-10 12:38           ` Sergey Ryazanov
2014-02-10 22:37             ` Florian Fainelli
2014-02-10 23:43               ` Sergey Ryazanov
2014-02-12 10:50                 ` Sergey Ryazanov
2014-02-13 20:14                   ` John W. Linville
2014-04-15 17:08                     ` Paul Bolle
2014-04-16  9:20                       ` Sergey Ryazanov
2014-06-18 10:25                         ` Paul Bolle
2014-06-18 11:10                           ` Sergey Ryazanov
2014-06-18 11:46                             ` Paul Bolle
2014-06-18 13:15                               ` [ath5k-devel] " Holger Schurig
2014-06-18 13:42                                 ` Paul Bolle
2014-09-05 10:10                               ` Paul Bolle
2014-09-05 11:12                                 ` Sergey Ryazanov
2014-09-05 11:33                                   ` Paul Bolle
2014-09-05 12:02                                     ` Sergey Ryazanov
2014-09-09 18:27                                       ` John W. Linville
2014-09-10  8:53                                         ` [PATCH] [RESEND] ath5k: Remove AHB bus support Paul Bolle
2014-09-26 17:45                                           ` John W. Linville
2014-09-10 10:33                                         ` [PATCH 09/28] Remove ATHEROS_AR231X Sergey Ryazanov
2014-09-10 11:36                                           ` Jiri Slaby
2014-09-10 12:19                                             ` Sergey Ryazanov
2014-09-11 19:21                                               ` John W. Linville
2014-09-15 18:45                                                 ` John W. Linville
2014-09-16 20:26                                                   ` Paul Bolle
2014-09-16 20:33                                                     ` John W. Linville
2014-02-09 18:47 ` [PATCH 10/28] Remove SH_MOBILE Richard Weinberger
2014-02-09 20:32   ` Paul Bolle
2014-02-09 18:47 ` [PATCH 11/28] Remove ARCH_SUPPORTS_MSI Richard Weinberger
2014-02-09 20:35   ` Paul Bolle
2014-02-09 18:47 ` [PATCH 12/28] Remove GENERIC_TIME Richard Weinberger
2014-02-09 18:57   ` Alexander Shiyan
2014-02-09 20:02     ` Richard Weinberger
2014-02-19  6:12       ` Christian Daudt
2014-02-09 18:47 ` [PATCH 13/28] Remove S3C24XX_GPIO_EXTRA64 Richard Weinberger
2014-02-11  3:29   ` Kukjin Kim
2014-02-09 18:47 ` [PATCH 15/28] Remove TI_AEMIF Richard Weinberger
2014-02-09 20:54   ` Paul Bolle
2014-02-11 19:04     ` Brian Norris
2014-02-11 19:42       ` Ivan Khoronzhuk
2014-02-09 18:47 ` [PATCH 16/28] Remove GENERIC_HAS_IOMAP Richard Weinberger
2014-02-09 20:59   ` Paul Bolle
2014-02-09 21:37     ` Guenter Roeck
2014-02-10  2:24   ` Lennox Wu
2014-04-15  9:19     ` Paul Bolle
2014-04-16 17:29       ` Lennox Wu
2014-04-16 18:30         ` Paul Bolle
2014-06-18  9:10           ` Paul Bolle
2014-06-18 19:53             ` Lennox Wu
2014-09-05  9:32               ` Paul Bolle
2014-09-05 13:57                 ` Guenter Roeck
2014-09-05 14:00                   ` Richard Weinberger
2014-09-05 18:23                     ` Lennox Wu
2014-02-09 18:47 ` [PATCH 17/28] Remove USE_GENERIC_SMP_HELPERS Richard Weinberger
2014-02-09 21:04   ` Paul Bolle
2014-02-09 18:47 ` [PATCH 18/28] Remove MN10300_PROC_MN2WS0038 Richard Weinberger
2014-02-09 20:44   ` Paul Bolle
2014-02-09 18:47 ` [PATCH 19/28] Remove SI4713 Richard Weinberger
2014-02-09 19:13   ` Hans Verkuil
2014-02-09 20:03     ` Richard Weinberger
2014-02-09 18:47 ` [PATCH 20/28] Remove OMAP_PM_SRF Richard Weinberger
2014-02-09 19:55   ` Paul Bolle
2014-02-09 18:47 ` [PATCH 21/28] Remove CPU_SUBTYPE_SH7764 Richard Weinberger
2014-02-09 21:36   ` Paul Bolle
2014-04-15  9:39     ` Paul Bolle
2014-04-15  9:55       ` Geert Uytterhoeven
2014-06-18  9:32         ` [PATCH] " Paul Bolle
2014-06-18 19:08           ` Paul Bolle
2014-02-09 18:48 ` [PATCH 22/28] Remove S3C24XX_GPIO_EXTRA128 Richard Weinberger
2014-02-11  3:31   ` Kukjin Kim
2014-02-13 22:57     ` Kukjin Kim
2014-02-09 18:48 ` [PATCH 23/28] Remove MACH_OMAP_H4_OTG Richard Weinberger
2014-02-09 19:57   ` Aaro Koskinen
2014-02-09 18:48 ` [PATCH 24/28] Remove DEPRECATED Richard Weinberger
2014-02-09 19:38   ` Paul Bolle
2014-02-09 20:04     ` Richard Weinberger
2014-02-09 20:15       ` Paul Bolle
2014-02-09 20:21         ` Richard Weinberger
2014-02-10  8:49           ` Geert Uytterhoeven
2014-02-10  8:52             ` Richard Weinberger
2014-06-18  8:47               ` Paul Bolle
2014-02-09 21:35       ` Guenter Roeck
2014-02-09 21:38         ` Richard Weinberger
2014-02-09 21:54           ` Gene Heskett
2014-02-09 22:11             ` Paul Bolle
2014-02-09 22:41               ` Gene Heskett
2014-02-09 22:48                 ` Paul Bolle
2014-02-09 23:05                   ` Gene Heskett
2014-02-10  3:07                     ` Ken Moffat
2014-02-10  3:13                       ` Randy Dunlap
2014-02-10  3:46                         ` Gene Heskett
2014-02-10  3:57                           ` Randy Dunlap
2014-02-10  4:14                             ` make oldfonfig broken Gene Heskett
2014-02-10  4:17                               ` Randy Dunlap
2014-02-10  4:32                                 ` Gene Heskett
2014-02-10  5:01                                   ` Randy Dunlap
2014-02-10  9:52                                     ` Gene Heskett
2014-02-10 20:21                                     ` Gene Heskett
2014-02-10 22:55                                       ` Randy Dunlap
2014-02-11  0:13                                         ` Gene Heskett
2014-02-11  2:18                                           ` Randy Dunlap
2014-02-11 18:22                                           ` Randy Dunlap
2014-02-11 19:45                                             ` Gene Heskett
2014-02-11 20:10                                             ` Gene Heskett
2014-02-09 23:16           ` [PATCH 24/28] Remove DEPRECATED Guenter Roeck
2014-02-09 18:48 ` [PATCH 26/28] Remove LOCAL_TIMERS Richard Weinberger
2014-02-09 22:38   ` Paul Bolle
2014-02-09 18:48 ` [PATCH 27/28] Remove ARC_HAS_COH_RTSC Richard Weinberger
2014-02-09 19:46   ` Paul Bolle
2014-02-10  4:35     ` Vineet Gupta
2014-02-10 13:48       ` Paul Bolle
2014-02-10 14:06         ` Vineet Gupta
2014-02-10 15:08           ` Paul Bolle
2014-02-10  4:23   ` Vineet Gupta
2014-02-09 18:48 ` [PATCH 28/28] Remove LOCAL_TIMERS Richard Weinberger
2014-02-09 22:49   ` Paul Bolle
2014-02-10  0:58 ` Remove orphan kconfig symbols Paul Bolle
2014-02-10 11:00   ` Mark Brown
2014-02-10 13:16     ` Paul Bolle
     [not found] ` <1391971686-9517-15-git-send-email-richard@nod.at>
2014-02-10 11:41   ` [PATCH 14/28] Remove MACH_SMDKC210 Mark Brown
2014-02-10 13:31     ` Paul Bolle
2014-02-10 14:12       ` Mark Brown [this message]
2014-02-10 15:30         ` Paul Bolle
2014-02-10 16:36           ` Mark Brown
2014-02-10 22:09             ` Paul Bolle
2014-02-12 16:04               ` Mark Brown
2014-02-28 21:43                 ` Paul Bolle
2014-03-01  3:53                   ` Mark Brown
2014-02-10 14:58 ` [PATCH 18/28] Remove MN10300_PROC_MN2WS0038 David Howells
2014-04-15  9:13   ` Paul Bolle
2014-06-18  9:42     ` Paul Bolle
2014-09-05  9:45       ` Paul Bolle
2014-09-12 12:36         ` [PATCH] [TRIVIAL] " Paul Bolle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140210141255.GI1757@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=ben-linux@fluff.org \
    --cc=kgene.kim@samsung.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    --cc=perex@perex.cz \
    --cc=richard@nod.at \
    --cc=sbkim73@samsung.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).