From: Richard Weinberger <richard@nod.at>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Paul Bolle <pebolle@tiscali.nl>,
David Howells <dhowells@redhat.com>,
Koichi Yasutake <yasutake.koichi@jp.panasonic.com>,
"moderated list:PANASONIC MN10300..."
<linux-am33-list@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 24/28] Remove DEPRECATED
Date: Mon, 10 Feb 2014 09:52:32 +0100 [thread overview]
Message-ID: <52F89350.9090404@nod.at> (raw)
In-Reply-To: <CAMuHMdX-CFScoxBoE3SMHT4+12mbxBPEL53-HVd+6bkGd3XX_g@mail.gmail.com>
Am 10.02.2014 09:49, schrieb Geert Uytterhoeven:
> On Sun, Feb 9, 2014 at 9:21 PM, Richard Weinberger <richard@nod.at> wrote:
>> Am 09.02.2014 21:15, schrieb Paul Bolle:
>>> On Sun, 2014-02-09 at 21:04 +0100, Richard Weinberger wrote:
>>>> Am 09.02.2014 20:38, schrieb Paul Bolle:
>>>>> But now you've enabled a lot of stuff that, as far as I can tell, could
>>>>> not have been built since v2.6.39.
>>>>
>>>> This is by design. If the code does not build/work it needs to be fixed or removed.
>>>
>>> If that was the design goal of this patch (and similar patches you've
>>> sent) it would have been proper to at least say a few words along those
>>> lines in the commit explanation.
>>
>> I assumed that every kernel developer is aware of that fact that unreachable/dead code
>> should be removed.
>
> Yes, it should be removed.
>
> But that's not what you did. You did the Kconfig-equivalent of removing a
> "#if 0" in a C source file, which causes havoc.
Fair point. I'll remove that code in v2.
Hopefully I can catch all breakage on my testbed as many archs/configs are involved.
Thanks,
//richard
next prev parent reply other threads:[~2014-02-10 8:52 UTC|newest]
Thread overview: 173+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-09 18:47 Remove orphan kconfig symbols Richard Weinberger
2014-02-09 18:47 ` [PATCH 01/28] Remove CPU_MMP3 Richard Weinberger
2014-02-09 22:07 ` Paul Bolle
2014-02-11 21:30 ` Greg Kroah-Hartman
2014-02-11 22:01 ` Paul Bolle
2014-02-12 7:52 ` Geert Uytterhoeven
2014-02-09 18:47 ` [PATCH 02/28] Remove OF_I2C Richard Weinberger
2014-02-09 19:58 ` Paul Bolle
2014-03-13 21:39 ` Wolfram Sang
2014-02-09 18:47 ` [PATCH 03/28] Remove MACH_BCM2708 Richard Weinberger
2014-02-09 20:02 ` Paul Bolle
2014-02-09 18:47 ` [PATCH 04/28] Remove EXYNOS_DEV_SYSMMU Richard Weinberger
2014-02-09 20:08 ` Paul Bolle
2014-02-10 4:32 ` Sachin Kamat
2014-04-15 9:33 ` Paul Bolle
2014-02-09 18:47 ` [PATCH 05/28] Remove MPILIB_EXTRA Richard Weinberger
2014-02-09 20:18 ` Paul Bolle
2014-04-15 9:06 ` Paul Bolle
2014-04-15 9:21 ` Borislav Petkov
2014-06-18 8:09 ` Paul Bolle
2014-06-18 9:48 ` Borislav Petkov
2014-06-18 10:38 ` Jiri Kosina
2014-06-18 14:18 ` [PATCH] [TRIVIAL] " Paul Bolle
2014-02-09 18:47 ` [PATCH 06/28] Remove PICOXCELL_PC3X3 Richard Weinberger
2014-02-09 20:28 ` Paul Bolle
2014-04-15 8:55 ` [PATCH] hwrng: remove unbuildable picoxcell TRNG Paul Bolle
2014-04-15 10:06 ` Jamie Iles
2014-04-16 13:50 ` Herbert Xu
2014-02-09 18:47 ` [PATCH 07/28] Remove CPU_PXA988 Richard Weinberger
2014-02-09 22:24 ` Paul Bolle
[not found] ` <52F800B2.6010702@nod.at>
2014-04-15 7:47 ` Paul Bolle
2014-04-15 7:50 ` Richard Weinberger
2014-02-09 18:47 ` [PATCH 08/28] Remove SYS_HAS_DMA_OPS Richard Weinberger
2014-02-09 21:44 ` Paul Bolle
2014-02-09 18:47 ` [PATCH 09/28] Remove ATHEROS_AR231X Richard Weinberger
2014-02-09 19:09 ` Joe Perches
2014-02-09 19:43 ` Paul Bolle
[not found] ` <52F7D480.1050106@hauke-m.de>
2014-02-09 20:03 ` Richard Weinberger
2014-02-10 12:05 ` Sergey Ryazanov
2014-02-10 12:17 ` Oleksij Rempel
2014-02-10 12:38 ` Sergey Ryazanov
2014-02-10 22:37 ` Florian Fainelli
2014-02-10 23:43 ` Sergey Ryazanov
2014-02-12 10:50 ` Sergey Ryazanov
2014-02-13 20:14 ` John W. Linville
2014-04-15 17:08 ` Paul Bolle
2014-04-16 9:20 ` Sergey Ryazanov
2014-06-18 10:25 ` Paul Bolle
2014-06-18 11:10 ` Sergey Ryazanov
2014-06-18 11:46 ` Paul Bolle
2014-06-18 13:15 ` [ath5k-devel] " Holger Schurig
2014-06-18 13:42 ` Paul Bolle
2014-09-05 10:10 ` Paul Bolle
2014-09-05 11:12 ` Sergey Ryazanov
2014-09-05 11:33 ` Paul Bolle
2014-09-05 12:02 ` Sergey Ryazanov
2014-09-09 18:27 ` John W. Linville
2014-09-10 8:53 ` [PATCH] [RESEND] ath5k: Remove AHB bus support Paul Bolle
2014-09-26 17:45 ` John W. Linville
2014-09-10 10:33 ` [PATCH 09/28] Remove ATHEROS_AR231X Sergey Ryazanov
2014-09-10 11:36 ` Jiri Slaby
2014-09-10 12:19 ` Sergey Ryazanov
2014-09-11 19:21 ` John W. Linville
2014-09-15 18:45 ` John W. Linville
2014-09-16 20:26 ` Paul Bolle
2014-09-16 20:33 ` John W. Linville
2014-02-09 18:47 ` [PATCH 10/28] Remove SH_MOBILE Richard Weinberger
2014-02-09 20:32 ` Paul Bolle
2014-02-09 18:47 ` [PATCH 11/28] Remove ARCH_SUPPORTS_MSI Richard Weinberger
2014-02-09 20:35 ` Paul Bolle
2014-02-09 18:47 ` [PATCH 12/28] Remove GENERIC_TIME Richard Weinberger
2014-02-09 18:57 ` Alexander Shiyan
2014-02-09 20:02 ` Richard Weinberger
2014-02-19 6:12 ` Christian Daudt
2014-02-09 18:47 ` [PATCH 13/28] Remove S3C24XX_GPIO_EXTRA64 Richard Weinberger
2014-02-11 3:29 ` Kukjin Kim
2014-02-09 18:47 ` [PATCH 15/28] Remove TI_AEMIF Richard Weinberger
2014-02-09 20:54 ` Paul Bolle
2014-02-11 19:04 ` Brian Norris
2014-02-11 19:42 ` Ivan Khoronzhuk
2014-02-09 18:47 ` [PATCH 16/28] Remove GENERIC_HAS_IOMAP Richard Weinberger
2014-02-09 20:59 ` Paul Bolle
2014-02-09 21:37 ` Guenter Roeck
2014-02-10 2:24 ` Lennox Wu
2014-04-15 9:19 ` Paul Bolle
2014-04-16 17:29 ` Lennox Wu
2014-04-16 18:30 ` Paul Bolle
2014-06-18 9:10 ` Paul Bolle
2014-06-18 19:53 ` Lennox Wu
2014-09-05 9:32 ` Paul Bolle
2014-09-05 13:57 ` Guenter Roeck
2014-09-05 14:00 ` Richard Weinberger
2014-09-05 18:23 ` Lennox Wu
2014-02-09 18:47 ` [PATCH 17/28] Remove USE_GENERIC_SMP_HELPERS Richard Weinberger
2014-02-09 21:04 ` Paul Bolle
2014-02-09 18:47 ` [PATCH 18/28] Remove MN10300_PROC_MN2WS0038 Richard Weinberger
2014-02-09 20:44 ` Paul Bolle
2014-02-09 18:47 ` [PATCH 19/28] Remove SI4713 Richard Weinberger
2014-02-09 19:13 ` Hans Verkuil
2014-02-09 20:03 ` Richard Weinberger
2014-02-09 18:47 ` [PATCH 20/28] Remove OMAP_PM_SRF Richard Weinberger
2014-02-09 19:55 ` Paul Bolle
2014-02-09 18:47 ` [PATCH 21/28] Remove CPU_SUBTYPE_SH7764 Richard Weinberger
2014-02-09 21:36 ` Paul Bolle
2014-04-15 9:39 ` Paul Bolle
2014-04-15 9:55 ` Geert Uytterhoeven
2014-06-18 9:32 ` [PATCH] " Paul Bolle
2014-06-18 19:08 ` Paul Bolle
2014-02-09 18:48 ` [PATCH 22/28] Remove S3C24XX_GPIO_EXTRA128 Richard Weinberger
2014-02-11 3:31 ` Kukjin Kim
2014-02-13 22:57 ` Kukjin Kim
2014-02-09 18:48 ` [PATCH 23/28] Remove MACH_OMAP_H4_OTG Richard Weinberger
2014-02-09 19:57 ` Aaro Koskinen
2014-02-09 18:48 ` [PATCH 24/28] Remove DEPRECATED Richard Weinberger
2014-02-09 19:38 ` Paul Bolle
2014-02-09 20:04 ` Richard Weinberger
2014-02-09 20:15 ` Paul Bolle
2014-02-09 20:21 ` Richard Weinberger
2014-02-10 8:49 ` Geert Uytterhoeven
2014-02-10 8:52 ` Richard Weinberger [this message]
2014-06-18 8:47 ` Paul Bolle
2014-02-09 21:35 ` Guenter Roeck
2014-02-09 21:38 ` Richard Weinberger
2014-02-09 21:54 ` Gene Heskett
2014-02-09 22:11 ` Paul Bolle
2014-02-09 22:41 ` Gene Heskett
2014-02-09 22:48 ` Paul Bolle
2014-02-09 23:05 ` Gene Heskett
2014-02-10 3:07 ` Ken Moffat
2014-02-10 3:13 ` Randy Dunlap
2014-02-10 3:46 ` Gene Heskett
2014-02-10 3:57 ` Randy Dunlap
2014-02-10 4:14 ` make oldfonfig broken Gene Heskett
2014-02-10 4:17 ` Randy Dunlap
2014-02-10 4:32 ` Gene Heskett
2014-02-10 5:01 ` Randy Dunlap
2014-02-10 9:52 ` Gene Heskett
2014-02-10 20:21 ` Gene Heskett
2014-02-10 22:55 ` Randy Dunlap
2014-02-11 0:13 ` Gene Heskett
2014-02-11 2:18 ` Randy Dunlap
2014-02-11 18:22 ` Randy Dunlap
2014-02-11 19:45 ` Gene Heskett
2014-02-11 20:10 ` Gene Heskett
2014-02-09 23:16 ` [PATCH 24/28] Remove DEPRECATED Guenter Roeck
2014-02-09 18:48 ` [PATCH 26/28] Remove LOCAL_TIMERS Richard Weinberger
2014-02-09 22:38 ` Paul Bolle
2014-02-09 18:48 ` [PATCH 27/28] Remove ARC_HAS_COH_RTSC Richard Weinberger
2014-02-09 19:46 ` Paul Bolle
2014-02-10 4:35 ` Vineet Gupta
2014-02-10 13:48 ` Paul Bolle
2014-02-10 14:06 ` Vineet Gupta
2014-02-10 15:08 ` Paul Bolle
2014-02-10 4:23 ` Vineet Gupta
2014-02-09 18:48 ` [PATCH 28/28] Remove LOCAL_TIMERS Richard Weinberger
2014-02-09 22:49 ` Paul Bolle
2014-02-10 0:58 ` Remove orphan kconfig symbols Paul Bolle
2014-02-10 11:00 ` Mark Brown
2014-02-10 13:16 ` Paul Bolle
[not found] ` <1391971686-9517-15-git-send-email-richard@nod.at>
2014-02-10 11:41 ` [PATCH 14/28] Remove MACH_SMDKC210 Mark Brown
2014-02-10 13:31 ` Paul Bolle
2014-02-10 14:12 ` Mark Brown
2014-02-10 15:30 ` Paul Bolle
2014-02-10 16:36 ` Mark Brown
2014-02-10 22:09 ` Paul Bolle
2014-02-12 16:04 ` Mark Brown
2014-02-28 21:43 ` Paul Bolle
2014-03-01 3:53 ` Mark Brown
2014-02-10 14:58 ` [PATCH 18/28] Remove MN10300_PROC_MN2WS0038 David Howells
2014-04-15 9:13 ` Paul Bolle
2014-06-18 9:42 ` Paul Bolle
2014-09-05 9:45 ` Paul Bolle
2014-09-12 12:36 ` [PATCH] [TRIVIAL] " Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F89350.9090404@nod.at \
--to=richard@nod.at \
--cc=dhowells@redhat.com \
--cc=geert@linux-m68k.org \
--cc=linux-am33-list@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=yasutake.koichi@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).