[PATCH 1/2] ASoC: fsl: make sure the regmap-mmio is actually enabled

[PATCH 1/2] ASoC: fsl: make sure the regmap-mmio is actually enabled

[Xiubo Li]

Since the Freescale SAI, ESAI and SPDIF are using the regmap-mmio,
there needs a select of REGMAP_MMIO in the Kconfig to ensure that
regmap-mmio is actually enabled.

Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
Cc: Nicolin Chen <Guangyu.Chen@freescale.com>
Cc: Mark Brown <broonie@linaro.org>
---
 sound/soc/fsl/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index 07f8f14..d0914c0 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -1,5 +1,6 @@
 config SND_SOC_FSL_SAI
 	tristate
+	select REGMAP_MMIO
 	select SND_SOC_GENERIC_DMAENGINE_PCM
 
 config SND_SOC_FSL_SSI
@@ -7,9 +8,11 @@ config SND_SOC_FSL_SSI
 
 config SND_SOC_FSL_SPDIF
 	tristate
+	select REGMAP_MMIO
 
 config SND_SOC_FSL_ESAI
 	tristate
+	select REGMAP_MMIO
 
 config SND_SOC_FSL_UTILS
 	tristate
@@ -204,7 +207,6 @@ config SND_SOC_IMX_SPDIF
 	tristate "SoC Audio support for i.MX boards with S/PDIF"
 	select SND_SOC_IMX_PCM_DMA
 	select SND_SOC_FSL_SPDIF
-	select REGMAP_MMIO
 	help
 	  SoC Audio support for i.MX boards with S/PDIF
 	  Say Y if you want to add support for SoC audio on an i.MX board with
-- 
1.8.4

[PATCH 2/2] ASoC: fsl: Make Freescale SAI/ESAI/SPDIF to be visible in Kconfig

[Xiubo Li]

For simple card since the whole idea is to support any CODEC and
any CPU DAI with the same driver, we should probably just make sure
that all the individual CODEC and CPU DAI drivers can be enabled in
Kconfig. That way we don't have to have specific Kconfig entries for
boards and loose some of the benefit of the generic card.

This will make the Freescale SAI/ESAI/SPDIF device be visible in
Kconfig.

Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
Cc: Nicolin Chen <Guangyu.Chen@freescale.com>
Cc: Mark Brown <broonie@linaro.org>
---
 sound/soc/fsl/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index d0914c0..f397144 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -1,5 +1,5 @@
 config SND_SOC_FSL_SAI
-	tristate
+	tristate "ALSA SoC support for the Freescale SAI device"
 	select REGMAP_MMIO
 	select SND_SOC_GENERIC_DMAENGINE_PCM
 
@@ -7,11 +7,11 @@ config SND_SOC_FSL_SSI
 	tristate
 
 config SND_SOC_FSL_SPDIF
-	tristate
+	tristate "ALSA SoC support for the Freescale SPDIF device"
 	select REGMAP_MMIO
 
 config SND_SOC_FSL_ESAI
-	tristate
+	tristate "ALSA SoC support for the Freescale ESAI device"
 	select REGMAP_MMIO
 
 config SND_SOC_FSL_UTILS
-- 
1.8.4

Re: [PATCH 1/2] ASoC: fsl: make sure the regmap-mmio is actually enabled

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 248 bytes --]

On Tue, Feb 11, 2014 at 10:47:04AM +0800, Xiubo Li wrote:
> Since the Freescale SAI, ESAI and SPDIF are using the regmap-mmio,
> there needs a select of REGMAP_MMIO in the Kconfig to ensure that
> regmap-mmio is actually enabled.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

RE: [PATCH 2/2] ASoC: fsl: Make Freescale SAI/ESAI/SPDIF to be visible in Kconfig

[Li.Xiubo]

Hi Mark,

I'm not very sure of this patch, maybe should we add one menu
in Kconfig for all visible CPU DAIs firstly like for code drivers?

Thanks,

--
Best Regards,
Xiubo


> Subject: [PATCH 2/2] ASoC: fsl: Make Freescale SAI/ESAI/SPDIF to be visible in
> Kconfig
> 
> For simple card since the whole idea is to support any CODEC and
> any CPU DAI with the same driver, we should probably just make sure
> that all the individual CODEC and CPU DAI drivers can be enabled in
> Kconfig. That way we don't have to have specific Kconfig entries for
> boards and loose some of the benefit of the generic card.
> 
> This will make the Freescale SAI/ESAI/SPDIF device be visible in
> Kconfig.
> 
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> Cc: Nicolin Chen <Guangyu.Chen@freescale.com>
> Cc: Mark Brown <broonie@linaro.org>
> ---
>  sound/soc/fsl/Kconfig | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> index d0914c0..f397144 100644
> --- a/sound/soc/fsl/Kconfig
> +++ b/sound/soc/fsl/Kconfig
> @@ -1,5 +1,5 @@
>  config SND_SOC_FSL_SAI
> -	tristate
> +	tristate "ALSA SoC support for the Freescale SAI device"
>  	select REGMAP_MMIO
>  	select SND_SOC_GENERIC_DMAENGINE_PCM
> 
> @@ -7,11 +7,11 @@ config SND_SOC_FSL_SSI
>  	tristate
> 
>  config SND_SOC_FSL_SPDIF
> -	tristate
> +	tristate "ALSA SoC support for the Freescale SPDIF device"
>  	select REGMAP_MMIO
> 
>  config SND_SOC_FSL_ESAI
> -	tristate
> +	tristate "ALSA SoC support for the Freescale ESAI device"
>  	select REGMAP_MMIO
> 
>  config SND_SOC_FSL_UTILS
> --
> 1.8.4
> 

Re: [PATCH 2/2] ASoC: fsl: Make Freescale SAI/ESAI/SPDIF to be visible in Kconfig

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]

On Thu, Feb 20, 2014 at 02:06:20AM +0000, Li.Xiubo@freescale.com wrote:

> I'm not very sure of this patch, maybe should we add one menu
> in Kconfig for all visible CPU DAIs firstly like for code drivers?

Allowing them to be individually selected is definitely useful if people
are trying to minimise their kernel size and/or build time.  However
none of the other Freescale people have commented on this patch (which
I'd have expected) so I was giving them time and IIRC it needs a rebase
against current code.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 2/2] ASoC: fsl: Make Freescale SAI/ESAI/SPDIF to be visible in Kconfig

[Nicolin Chen]

On Thu, Feb 20, 2014 at 11:44:32AM +0900, Mark Brown wrote:
> On Thu, Feb 20, 2014 at 02:06:20AM +0000, Li.Xiubo@freescale.com wrote:
> 
> > I'm not very sure of this patch, maybe should we add one menu
> > in Kconfig for all visible CPU DAIs firstly like for code drivers?
> 
> Allowing them to be individually selected is definitely useful if people
> are trying to minimise their kernel size and/or build time.  However
> none of the other Freescale people have commented on this patch (which
> I'd have expected) so I was giving them time and IIRC it needs a rebase
> against current code.

Last month I was revising a new CODEC driver for ESAI and meanwhile abort
to plan to try simple card for this combination but being suspended due to
some tough internal issues. So I think it should be a good idea for us to
move towards simple card starting from this patch.

Surely, Acked.
Nicolin Chen

RE: [PATCH 2/2] ASoC: fsl: Make Freescale SAI/ESAI/SPDIF to be visible in Kconfig

[Li.Xiubo]

> Subject: Re: [PATCH 2/2] ASoC: fsl: Make Freescale SAI/ESAI/SPDIF to be
> visible in Kconfig
> 
> On Thu, Feb 20, 2014 at 02:06:20AM +0000, Li.Xiubo@freescale.com wrote:
> 
> > I'm not very sure of this patch, maybe should we add one menu
> > in Kconfig for all visible CPU DAIs firstly like for code drivers?
> 
> Allowing them to be individually selected is definitely useful if people
> are trying to minimise their kernel size and/or build time.  However
> none of the other Freescale people have commented on this patch (which
> I'd have expected) so I was giving them time and IIRC it needs a rebase
> against current code.

Yes, Surely.

As we can see that there will be many CPU DAI drivers to be visible in the
future, and they will get a bit noisy too. IMHO, put the CPU DAI drivers in
a menu is a good choice for other separate patches.

Thanks very much,

--
Best Regards,
Xiubo

RE: [PATCH 2/2] ASoC: fsl: Make Freescale SAI/ESAI/SPDIF to be visible in Kconfig

[Li.Xiubo]

Hi Mark,

Has this patch been missing? I couldn't found it anywhere in the next branch.
:)

Thanks very much,

--
Best Regards,
Xiubo



> -----Original Message-----
> From: Nicolin Chen [mailto:Guangyu.Chen@freescale.com]
> Sent: Thursday, February 20, 2014 11:08 AM
> To: Mark Brown
> Cc: Xiubo Li-B47053; lgirdwood@gmail.com; shawn.guo@linaro.org; perex@perex.cz;
> tiwai@suse.de; Estevam Fabio-R49496; alsa-devel@alsa-project.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH 2/2] ASoC: fsl: Make Freescale SAI/ESAI/SPDIF to be
> visible in Kconfig
> 
> On Thu, Feb 20, 2014 at 11:44:32AM +0900, Mark Brown wrote:
> > On Thu, Feb 20, 2014 at 02:06:20AM +0000, Li.Xiubo@freescale.com wrote:
> >
> > > I'm not very sure of this patch, maybe should we add one menu
> > > in Kconfig for all visible CPU DAIs firstly like for code drivers?
> >
> > Allowing them to be individually selected is definitely useful if people
> > are trying to minimise their kernel size and/or build time.  However
> > none of the other Freescale people have commented on this patch (which
> > I'd have expected) so I was giving them time and IIRC it needs a rebase
> > against current code.
> 
> Last month I was revising a new CODEC driver for ESAI and meanwhile abort
> to plan to try simple card for this combination but being suspended due to
> some tough internal issues. So I think it should be a good idea for us to
> move towards simple card starting from this patch.
> 
> Surely, Acked.
> Nicolin Chen
>