From: Sebastian Reichel <sre@debian.org>
To: Belisko Marek <marek.belisko@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer
Date: Fri, 28 Feb 2014 22:08:57 +0100 [thread overview]
Message-ID: <20140228210857.GA17467@earth.universe> (raw)
In-Reply-To: <CAAfyv36jJoMxZQ5e43pEC2rzNBHHW9Jt_4dg5O-fS8e+Aim7jA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2035 bytes --]
On Fri, Feb 28, 2014 at 09:32:12PM +0100, Belisko Marek wrote:
> On Fri, Feb 28, 2014 at 3:05 AM, Sebastian Reichel <sre@debian.org> wrote:
> > On Thu, Feb 27, 2014 at 10:34:35PM +0100, Belisko Marek wrote:
> >> Well I've tried and it's worse :). I got during booting:
> >> [ 2.218383] ERROR: could not get IIO channel /battery:temp(0)
> >> [ 2.224639] platform battery.4: Driver twl4030_madc_battery
> >> requests probe deferral
> >> Not sure if it's just error or warning but temp is always reported as
> >> 0 (and also other values in sysfs).
> >
> > This is an error, which basically means, that twl4030-madc has not
> > yet been loaded. Do you get proper values when you use the old madc
> > API with the patchset applied?
>
> It works without converting to iio consumer (at least I get some
> reasonable values). With conversion it fails with above error. I
> recheck (add printk to iio twl4030-madc) that madc driver is
> loaded. Could this be that twl4030_madc_battery is loaded earlier
> then twl4030_madc and than it fails to get iio channels?
The error above implies, that twl4030-madc has not been loaded when
twl4030-madc-battery was loaded. This iio_channel_get() fails and
returns -EPROBE_DEFER. This results in twl4030-madc-battery probe
function returning -EPROBE_DEFER. Thus you can simply ignore the
error if the twl4030-madc-battery driver is loaded later.
I guess the easiest way to debug the problem is adding some
dev_dbg() at the start of twl4030_madc_conversion(), which
prints out the entries of twl4030_madc_request. Currently
the IIO API simply calls twl4030_madc_request(), so you
should be able to find out the difference.
Also: Can you post you DTS? I use the following for Nokia N900:
/ {
battery: n900-battery {
compatible = "nokia,n900-battery";
io-channels = <&twl_madc 0>, <&twl_madc 4>, <&twl_madc 12>;
io-channel-names = "temp", "bsi", "vbat";
};
};
&twl {
twl_madc: madc {
compatible = "ti,twl4030-madc";
interrupts = <3>;
#io-channel-cells = <1>;
};
};
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-02-28 21:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 0:46 [PATCHv1 0/2] Convert rx51-battery to IIO API and add DT support Sebastian Reichel
2014-02-26 0:46 ` [PATCHv1 1/2] rx51_battery: convert to iio consumer Sebastian Reichel
2014-02-26 21:43 ` Belisko Marek
2014-02-26 21:54 ` Sebastian Reichel
2014-02-27 21:34 ` Belisko Marek
2014-02-28 2:05 ` Sebastian Reichel
2014-02-28 20:32 ` Belisko Marek
2014-02-28 20:59 ` Belisko Marek
2014-02-28 21:08 ` Sebastian Reichel [this message]
2014-02-28 21:13 ` Belisko Marek
2014-02-28 22:32 ` Belisko Marek
2014-02-28 23:22 ` Sebastian Reichel
2014-03-04 21:20 ` Belisko Marek
2014-03-04 22:02 ` Sebastian Reichel
2014-03-01 11:17 ` Jonathan Cameron
2014-03-01 11:22 ` Jonathan Cameron
2014-02-26 0:46 ` [PATCHv1 2/2] Documentation: DT: Document rx51-battery binding Sebastian Reichel
2014-02-26 7:40 ` [PATCHv1 0/2] Convert rx51-battery to IIO API and add DT support Pali Rohár
2014-02-26 17:51 ` Sebastian Reichel
2014-03-01 20:22 ` [PATCHv2 " Sebastian Reichel
2014-03-01 20:22 ` [PATCHv2 1/2] rx51_battery: convert to iio consumer Sebastian Reichel
2014-03-29 11:09 ` Jonathan Cameron
2014-04-20 12:08 ` Pavel Machek
2014-04-23 16:09 ` Sebastian Reichel
2014-06-14 8:32 ` Pavel Machek
2014-06-14 15:47 ` Sebastian Reichel
2014-03-01 20:22 ` [PATCHv2 2/2] Documentation: DT: Document rx51-battery binding Sebastian Reichel
2014-03-29 11:10 ` Jonathan Cameron
2014-04-20 12:09 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228210857.GA17467@earth.universe \
--to=sre@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).