From: Belisko Marek <marek.belisko@gmail.com>
To: Sebastian Reichel <sre@debian.org>
Cc: "Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Grant Likely" <grant.likely@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-iio@vger.kernel.org, "Pali Rohár" <pali.rohar@gmail.com>
Subject: Re: [PATCHv1 1/2] rx51_battery: convert to iio consumer
Date: Thu, 27 Feb 2014 22:34:35 +0100 [thread overview]
Message-ID: <CAAfyv340pA2ihUAoFytBgevLtedvtj5Z0aw_=G9Rbx5occtyqw@mail.gmail.com> (raw)
In-Reply-To: <20140226215452.GA11468@earth.universe>
Hi Sebastian,
On Wed, Feb 26, 2014 at 10:54 PM, Sebastian Reichel <sre@debian.org> wrote:
> Hi,
>
> On Wed, Feb 26, 2014 at 10:43:40PM +0100, Belisko Marek wrote:
>> [...]
>> > + int val, err;
>> > + err = iio_read_channel_average_raw(channel, &val);
>> Where this function comes from? I cannot find it in current linux-next
>> (only iio_read_channel_raw()). Am I missing some patches? Thx.
>
> Ah right. I planned to send a patch adding this function together
> with the rx51-battery patchset, but it seems I forgot to include it.
>
> Sorry for the inconvenience. I will send it out as a separate patch
> now.
>
>> BTW when I convert to iio consumer and use DT some of values work
>> but some of them just report 0 :( (I don't have latest twl4030-madc
>> iio patches).
>
> Can you retry with the twl4030-madc iio patch from today? The
> older patchsets, which do not contain the "tested on real hw"
> note are slightly broken.
Well I've tried and it's worse :). I got during booting:
[ 2.218383] ERROR: could not get IIO channel /battery:temp(0)
[ 2.224639] platform battery.4: Driver twl4030_madc_battery
requests probe deferral
Not sure if it's just error or warning but temp is always reported as
0 (and also other values in sysfs).
My patches ca be found here:
https://patchwork.kernel.org/patch/3735981/
https://patchwork.kernel.org/patch/3735961/
https://patchwork.kernel.org/patch/3735941/
>
> -- Sebastian
BR,
marek
--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
next prev parent reply other threads:[~2014-02-27 21:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 0:46 [PATCHv1 0/2] Convert rx51-battery to IIO API and add DT support Sebastian Reichel
2014-02-26 0:46 ` [PATCHv1 1/2] rx51_battery: convert to iio consumer Sebastian Reichel
2014-02-26 21:43 ` Belisko Marek
2014-02-26 21:54 ` Sebastian Reichel
2014-02-27 21:34 ` Belisko Marek [this message]
2014-02-28 2:05 ` Sebastian Reichel
2014-02-28 20:32 ` Belisko Marek
2014-02-28 20:59 ` Belisko Marek
2014-02-28 21:08 ` Sebastian Reichel
2014-02-28 21:13 ` Belisko Marek
2014-02-28 22:32 ` Belisko Marek
2014-02-28 23:22 ` Sebastian Reichel
2014-03-04 21:20 ` Belisko Marek
2014-03-04 22:02 ` Sebastian Reichel
2014-03-01 11:17 ` Jonathan Cameron
2014-03-01 11:22 ` Jonathan Cameron
2014-02-26 0:46 ` [PATCHv1 2/2] Documentation: DT: Document rx51-battery binding Sebastian Reichel
2014-02-26 7:40 ` [PATCHv1 0/2] Convert rx51-battery to IIO API and add DT support Pali Rohár
2014-02-26 17:51 ` Sebastian Reichel
2014-03-01 20:22 ` [PATCHv2 " Sebastian Reichel
2014-03-01 20:22 ` [PATCHv2 1/2] rx51_battery: convert to iio consumer Sebastian Reichel
2014-03-29 11:09 ` Jonathan Cameron
2014-04-20 12:08 ` Pavel Machek
2014-04-23 16:09 ` Sebastian Reichel
2014-06-14 8:32 ` Pavel Machek
2014-06-14 15:47 ` Sebastian Reichel
2014-03-01 20:22 ` [PATCHv2 2/2] Documentation: DT: Document rx51-battery binding Sebastian Reichel
2014-03-29 11:10 ` Jonathan Cameron
2014-04-20 12:09 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAfyv340pA2ihUAoFytBgevLtedvtj5Z0aw_=G9Rbx5occtyqw@mail.gmail.com' \
--to=marek.belisko@gmail.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pali.rohar@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).