Fwd: cx23885-dvb.c:undefined reference to `tda18271_attach'

Fwd: cx23885-dvb.c:undefined reference to `tda18271_attach'

[Peter Senna Tschudin]

Hi,

I'm being blamed for some bugs for more than one year, and this
weekend I was able to reproduce the error for the first time. I have
the impression that the issue is related to Kconfig because when
compiling the Kernel for x86(not x86_64), and
when:
CONFIG_VIDEO_CX23885=y

and

CONFIG_MEDIA_TUNER_TDA18271=m

the build fails as the tuner code was compiled as a module when it
should have been compiled as part of the Kernel. On the Kconfig file
drivers/media/pci/cx23885/Kconfig:
config VIDEO_CX23885
        tristate "Conexant cx23885 (2388x successor) support"
        ...
        select MEDIA_TUNER_TDA18271 if MEDIA_SUBDRV_AUTOSELECT

which I think is the problem. Can I just remove this 'if
MEDIA_SUBDRV_AUTOSELECT'? Or what is the correct way of telling
Kconfig to set CONFIG_MEDIA_TUNER_TDA18271 based on the value of
CONFIG_VIDEO_CX23885?

There are at least 6 similar cases which I'm willing to send patches.

Thank you,

Peter

Re: cx23885-dvb.c:undefined reference to `tda18271_attach'

[Mauro Carvalho Chehab]

Hi Peter,

Em Mon, 24 Mar 2014 16:34:17 +0100
Peter Senna Tschudin <peter.senna@gmail.com> escreveu:

> Hi,
> 
> I'm being blamed for some bugs for more than one year, and this
> weekend I was able to reproduce the error for the first time. I have
> the impression that the issue is related to Kconfig because when
> compiling the Kernel for x86(not x86_64), and
> when:
> CONFIG_VIDEO_CX23885=y
> 
> and
> 
> CONFIG_MEDIA_TUNER_TDA18271=m
> 
> the build fails as the tuner code was compiled as a module when it
> should have been compiled as part of the Kernel. 

No. It is valid to have those I2C drivers compiled as module while
the main driver is compiled builtin.

The trick is to use dvb_attach() macro. This macro is very bad
named. It should be named as something like:
	request_module_and_execute_symbol()
In order to express what it really does.

> On the Kconfig file
> drivers/media/pci/cx23885/Kconfig:
> config VIDEO_CX23885
>         tristate "Conexant cx23885 (2388x successor) support"
>         ...
>         select MEDIA_TUNER_TDA18271 if MEDIA_SUBDRV_AUTOSELECT
> 
> which I think is the problem. Can I just remove this 'if
> MEDIA_SUBDRV_AUTOSELECT'? Or what is the correct way of telling
> Kconfig to set CONFIG_MEDIA_TUNER_TDA18271 based on the value of
> CONFIG_VIDEO_CX23885?

You shouldn't be doing any of this. In this specific setup,
we have:

# CONFIG_MEDIA_SUBDRV_AUTOSELECT is not set
CONFIG_MEDIA_TUNER_TDA18271=m
CONFIG_VIDEO_CX23885=y

With should be a valid configuration. 

I'll try to reproduce and fix this one locally and send a fix for it
latter.

> There are at least 6 similar cases which I'm willing to send patches.
> 
> Thank you,
> 
> Peter
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 

Regards,
Mauro