* [PATCH][linux-next] staging/rtl8821ae: fix sparse address space warning
@ 2014-04-23 12:06 Anders Darander
2014-04-23 12:30 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Anders Darander @ 2014-04-23 12:06 UTC (permalink / raw)
To: devel, linux-kernel; +Cc: gregkh, Anders Darander
When unmapping the pci memory, the pointer was explicitly casted to void*,
thus omitting the __iomem designation.
Signed-off-by: Anders Darander <anders.darander@gmail.com>
---
drivers/staging/rtl8821ae/pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8821ae/pci.c b/drivers/staging/rtl8821ae/pci.c
index a562aa6..d934ecb 100644
--- a/drivers/staging/rtl8821ae/pci.c
+++ b/drivers/staging/rtl8821ae/pci.c
@@ -2416,7 +2416,7 @@ fail3:
ieee80211_free_hw(hw);
if (rtlpriv->io.pci_mem_start != 0)
- pci_iounmap(pdev, (void *)rtlpriv->io.pci_mem_start);
+ pci_iounmap(pdev, (void __iomem *)rtlpriv->io.pci_mem_start);
fail2:
pci_release_regions(pdev);
@@ -2479,7 +2479,7 @@ void rtl_pci_disconnect(struct pci_dev *pdev)
list_del(&rtlpriv->list);
if (rtlpriv->io.pci_mem_start != 0) {
- pci_iounmap(pdev, (void *)rtlpriv->io.pci_mem_start);
+ pci_iounmap(pdev, (void __iomem *)rtlpriv->io.pci_mem_start);
pci_release_regions(pdev);
}
--
2.0.0.rc0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][linux-next] staging/rtl8821ae: fix sparse address space warning
2014-04-23 12:06 [PATCH][linux-next] staging/rtl8821ae: fix sparse address space warning Anders Darander
@ 2014-04-23 12:30 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-04-23 12:30 UTC (permalink / raw)
To: Anders Darander; +Cc: devel, linux-kernel, gregkh
On Wed, Apr 23, 2014 at 02:06:25PM +0200, Anders Darander wrote:
> When unmapping the pci memory, the pointer was explicitly casted to void*,
> thus omitting the __iomem designation.
It looks like the struct definition should be updated instead of every
single reference being casted.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-23 12:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-23 12:06 [PATCH][linux-next] staging/rtl8821ae: fix sparse address space warning Anders Darander
2014-04-23 12:30 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).