From: Don Zickus <dzickus@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@kernel.org>, Paul Mackerras <paulus@samba.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4)
Date: Wed, 23 Apr 2014 08:58:28 -0400 [thread overview]
Message-ID: <20140423125828.GL5328@redhat.com> (raw)
In-Reply-To: <87lhuwr2pk.fsf@sejong.aot.lge.com>
On Wed, Apr 23, 2014 at 03:15:35PM +0900, Namhyung Kim wrote:
> Hi Don,
>
> On Tue, 22 Apr 2014 17:16:47 -0400, Don Zickus wrote:
> > On Wed, Apr 16, 2014 at 12:05:37PM +0900, Namhyung Kim wrote:
> >> Hello,
> >>
> >> This is a patchset implementing -F/--fields option to setup output
> >> field/column as Ingo requested. It depends on my --percentage
> >> patchset [1].
> >>
> >> The -F option can receive any sort keys that -s option recognize, plus
> >> following fields (name can be changed):
> >>
> >> overhead, overhead_sys, overhead_us, sample, period
> >>
> >> The overhead_guest_sys and overhead_guest_us might be avaiable when
> >> you profile guest machines.
> >>
> >> Output will be sorted by in order of fields and sort keys passed by -s
> >> option will be added to the output field list automatically. If you
> >> want to change the order of sorting you can give -s option in addition
> >> to -F option. To support old behavior, it'll also prepend 'overhead'
> >> field to the sort keys unless you give -F option explicitly.
> >
> > So I am struggling a little bit to get this working correctly. I had it
> > in my head that I could sort internally with -s and re-sort the output
> > based on -F, but it doesn't seem to be working that way.
>
> Hmm.. probably it's me miss something on perf mem side.. I don't have
> an access to a machine to test it now.
>
> >
> > For example with
> >
> > ./perf mem record -a grep -r foo /* > /dev/null
> > ./perf mem report -F overhead,symbol_daddr,pid -s symbol_daddr,pid --stdio
> >
> > I was thinking I could sort everything based on the symbol_daddr and pid.
> > Then re-sort the output to display the highest 'symbol_daddr,pid' pair.
> > But it didn't seem to work that way. Instead it seems like I get the
> > original sort just displayed in the -F format.
>
> Could you please show me the output of your example?
# To display the perf.data header info, please use --header/--header-only
# options.
#
# Samples: 96K of event 'cpu/mem-loads/pp'
# Total weight : 1102938
# Sort order : symbol_daddr,pid
#
# Overhead Data Symbol Command: Pid
# ........ ......................................................................
#
0.00% [k] 0xffff8807a8c1cf80 grep:116437
0.00% [k] 0xffff8807a8c8cee0 grep:116437
0.00% [k] 0xffff8807a8dceea0 grep:116437
0.01% [k] 0xffff8807a9298dc0 grep:116437
0.01% [k] 0xffff8807a934be40 grep:116437
0.00% [k] 0xffff8807a9416ec0 grep:116437
0.02% [k] 0xffff8807a9735700 grep:116437
0.00% [k] 0xffff8807a98e9460 grep:116437
0.02% [k] 0xffff8807a9afc890 grep:116437
0.00% [k] 0xffff8807aa64feb0 grep:116437
0.02% [k] 0xffff8807aa6b0030 grep:116437
Cheers,
Don
next prev parent reply other threads:[~2014-04-23 12:58 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 3:05 [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4) Namhyung Kim
2014-04-16 3:05 ` [PATCH 01/17] perf tools: Add ->cmp(), ->collapse() and ->sort() to perf_hpp_fmt Namhyung Kim
2014-04-16 3:05 ` [PATCH 02/17] perf tools: Convert sort entries to hpp formats Namhyung Kim
2014-04-16 3:05 ` [PATCH 03/17] perf tools: Use hpp formats to sort hist entries Namhyung Kim
2014-04-16 3:05 ` [PATCH 04/17] perf tools: Support event grouping in hpp ->sort() Namhyung Kim
2014-04-16 3:05 ` [PATCH 05/17] perf tools: Use hpp formats to sort final output Namhyung Kim
2014-04-16 3:05 ` [PATCH 06/17] perf tools: Consolidate output field handling to hpp format routines Namhyung Kim
2014-04-16 3:05 ` [PATCH 07/17] perf ui: Get rid of callback from __hpp__fmt() Namhyung Kim
2014-04-16 3:05 ` [PATCH 08/17] perf tools: Allow hpp fields to be sort keys Namhyung Kim
2014-04-16 3:05 ` [PATCH 09/17] perf tools: Consolidate management of default sort orders Namhyung Kim
2014-04-16 3:05 ` [PATCH 10/17] perf tools: Call perf_hpp__init() before setting up GUI browsers Namhyung Kim
2014-04-16 3:05 ` [PATCH 11/17] perf report: Add -F option to specify output fields Namhyung Kim
2014-04-16 3:05 ` [PATCH 12/17] perf tools: Add ->sort() member to struct sort_entry Namhyung Kim
2014-04-16 3:05 ` [PATCH 13/17] perf report/tui: Fix a bug when --fields/sort is given Namhyung Kim
2014-04-16 3:05 ` [PATCH 14/17] perf top: Add --fields option to specify output fields Namhyung Kim
2014-04-16 3:05 ` [PATCH 15/17] perf diff: Add missing setup_output_field() Namhyung Kim
2014-04-16 3:05 ` [PATCH 16/17] perf tools: Skip elided sort entries Namhyung Kim
2014-04-16 3:05 ` [PATCH 17/17] perf hists: Reset width of output fields with header length Namhyung Kim
2014-04-22 21:16 ` [PATCHSET 00/17] perf report: Add -F option for specifying output fields (v4) Don Zickus
2014-04-23 6:15 ` Namhyung Kim
2014-04-23 12:58 ` Don Zickus [this message]
2014-04-24 13:41 ` Namhyung Kim
2014-04-24 21:00 ` Don Zickus
2014-04-25 7:58 ` Namhyung Kim
2014-04-28 19:46 ` Don Zickus
2014-04-29 1:13 ` Namhyung Kim
2014-04-29 17:27 ` Don Zickus
2014-04-29 23:38 ` Namhyung Kim
2014-04-30 13:35 ` Don Zickus
2014-05-07 3:05 ` Namhyung Kim
2014-05-07 15:22 ` Don Zickus
2014-05-09 6:11 ` Namhyung Kim
2014-05-09 13:33 ` Don Zickus
2014-05-04 17:53 ` Jiri Olsa
2014-05-07 3:09 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423125828.GL5328@redhat.com \
--to=dzickus@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).