From: Felipe Balbi <balbi@ti.com>
To: Paul Fertser <fercerpav@gmail.com>
Cc: Felipe Balbi <balbi@ti.com>, Li Yang <leoli@freescale.com>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<suresh.gupta@freescale.com>
Subject: Re: [PATCH] usb: gadget: fsl: check vbus presence on probe
Date: Wed, 30 Apr 2014 15:12:02 -0500 [thread overview]
Message-ID: <20140430201202.GF3839@saruman.home> (raw)
In-Reply-To: <20140430192745.GI3876@home.lan>
[-- Attachment #1: Type: text/plain, Size: 1608 bytes --]
+Suresh
(top-posting, yeah yeah :-)
On Wed, Apr 30, 2014 at 11:27:45PM +0400, Paul Fertser wrote:
> Hello,
>
> Thank you for the review.
>
> On Wed, Apr 30, 2014 at 11:06:25AM -0500, Felipe Balbi wrote:
> > On Thu, Apr 24, 2014 at 12:54:13PM +0400, Paul Fertser wrote:
> > > If VBUS is already present during the driver initialisation, the
> >
> > s/initialisation/initialization
>
> If I'm understanding [1] properly, both spelling variants are correct.
>
> > > + /* Now let it settle a bit and sense VBUS */
> > > + msleep_interruptible(1);
> > > + if (fsl_readl(&dr_regs->otgsc) & OTGSC_STS_B_SESSION_VALID)
> > > + udc_controller->vbus_active = 1;
> >
> > good fix, should this go to stable ?
>
> I was reluctant to Cc stable because I'm not sure which versions need
> to be fixed, as I've seen an earlier version (3.0 something or a bit
> before that probably) working without this (no idea why); also I'm not
> sure about that msleep as it's deduced solely from experimenting with
> a particular i.MX model, I hoped someone from Freescale would comment
> on it. I've seen your review [2] on a related patch and my fix should
> have been obvious to Suresh (and trivial to test on different boards),
> yet he didn't implement it, that worries me a bit.
>
> [1] https://en.wikipedia.org/wiki/American_and_British_English_spelling_differences#-ise.2C_-ize_.28-isation.2C_-ization.29
> [2] https://patchwork.kernel.org/patch/3822321/
> --
> Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
> mailto:fercerpav@gmail.com
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-04-30 20:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 8:54 [PATCH] usb: gadget: fsl: check vbus presence on probe Paul Fertser
2014-04-30 16:06 ` Felipe Balbi
2014-04-30 19:27 ` Paul Fertser
2014-04-30 20:12 ` Felipe Balbi [this message]
2014-05-01 14:27 ` suresh.gupta
2014-05-08 14:30 ` suresh.gupta
2014-05-08 15:38 ` Paul Fertser
2014-05-08 18:42 ` suresh.gupta
2014-05-08 20:14 ` Paul Fertser
2014-05-09 9:07 ` suresh.gupta
2014-05-09 11:18 ` Paul Fertser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140430201202.GF3839@saruman.home \
--to=balbi@ti.com \
--cc=fercerpav@gmail.com \
--cc=leoli@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=suresh.gupta@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).