From: "suresh.gupta@freescale.com" <suresh.gupta@freescale.com>
To: Paul Fertser <fercerpav@gmail.com>, "balbi@ti.com" <balbi@ti.com>
Cc: "LeoLi@freescale.com" <LeoLi@freescale.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: gadget: fsl: check vbus presence on probe
Date: Thu, 8 May 2014 18:42:53 +0000 [thread overview]
Message-ID: <2d0cb4d1c8d7499ea6382cbb4c34c8d8@BL2PR03MB579.namprd03.prod.outlook.com> (raw)
In-Reply-To: <20140508153845.GA3876@home.lan>
> -----Original Message-----
> From: Paul Fertser [mailto:fercerpav@gmail.com]
> Sent: Thursday, May 08, 2014 9:09 PM
> To: Gupta Suresh-B42813
> Cc: balbi@ti.com; Li Yang-Leo-R58472; linux-usb@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH] usb: gadget: fsl: check vbus presence on probe
>
> Hi,
>
> On Thu, May 08, 2014 at 02:30:39PM +0000, suresh.gupta@freescale.com
> wrote:
> > As per my limited knowledge, the purpose of OTGSC_STS_B_SESSION_VALID
> > bit is to tell either VBUS is above the B session valid threshold and
> > which comes only Host is attached.
>
> Yes, that matches the datasheet I've read.
>
> > And Host might be attach after system bootup or after driver
> > initialization. So putting this check in probe will not help much.
>
> If the host is attached after the driver was initialised, the interrupt
> will trigger and the driver will get notified that VBUS appeared and
> everything will go smooth, at least that's how it should work (I do not
> have any board handy to real-life check that, but AFAICT that's the
> intent of the current code).
If is go through the code flow starting from usb_composite_probe the sequence is
usb_composite_probe->usb_gadget_probe_driver->udc_bind_to_driver->
udc_bind_to_driver->usb_gadget_udc_start->fsl_udc_start->usbcmd=RUN
udc_bind_to_driver->usb_gadget_connect->fsl_pullup
The function fsl_pullup make usbcmd=STOP if my fix is not there and if controller
is stopped we do not get any interrupt.
>
> I actually do not have any iMX demoboards at all, I've only got some
> custom-designed i.MX25 boards where I can't control VBUS, it's
> permanently pulled up.
>
> But I was fixing the problem that was clearly, 100% reproducibly
> happening when VBUS was applied before the interrupt was configured. So
Wait a minute, are you using OTG. If your VBUS is permanently pulled up, that
means you are only Gadget(I might miss something) then why you use OTG mode.
> what exactly do you mean here? Do you mean this check I've added doesn't
> fix the bug? Or do you mean this bug should be fixed somehow else? Or do
What expertly my concern is, probe is not proper place to check VBUS valid.
I think we should wait to hear what Balbi has to say.
> you mean there's no bug in the first place and my board doesn't work
> because of something else?
>
> --
> Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software!
> mailto:fercerpav@gmail.com
next prev parent reply other threads:[~2014-05-08 18:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 8:54 [PATCH] usb: gadget: fsl: check vbus presence on probe Paul Fertser
2014-04-30 16:06 ` Felipe Balbi
2014-04-30 19:27 ` Paul Fertser
2014-04-30 20:12 ` Felipe Balbi
2014-05-01 14:27 ` suresh.gupta
2014-05-08 14:30 ` suresh.gupta
2014-05-08 15:38 ` Paul Fertser
2014-05-08 18:42 ` suresh.gupta [this message]
2014-05-08 20:14 ` Paul Fertser
2014-05-09 9:07 ` suresh.gupta
2014-05-09 11:18 ` Paul Fertser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d0cb4d1c8d7499ea6382cbb4c34c8d8@BL2PR03MB579.namprd03.prod.outlook.com \
--to=suresh.gupta@freescale.com \
--cc=LeoLi@freescale.com \
--cc=balbi@ti.com \
--cc=fercerpav@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).