From: Steven Rostedt <rostedt@goodmis.org>
To: "Elliott, Robert (Server Storage)" <Elliott@hp.com>
Cc: "fweisbec@gmail.com" <fweisbec@gmail.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-kernel (linux-kernel@vger.kernel.org)"
<linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] ftrace function-graph: print the function name on all } lines
Date: Fri, 2 May 2014 15:32:49 -0400 [thread overview]
Message-ID: <20140502153249.1ee6aadd@gandalf.local.home> (raw)
In-Reply-To: <94D0CD8314A33A4D9D801C0FE68B402956EE7D16@G9W0745.americas.hpqcorp.net>
On Fri, 2 May 2014 19:11:11 +0000
"Elliott, Robert (Server Storage)" <Elliott@hp.com> wrote:
> Using ftrace function-graph to examine the times consumed by
> functions, the time shows up on the line where the call is made
> if no other traceable functions were called by that function:
> 11) 0.672 us | cmd_alloc [hpsa]();
>
> but the time shows up down by the } if the were other traceable
> functions called by that function:
> 11) | cmd_alloc [hpsa]() {
> 11) 0.129 us | cmd_free [hpsa]();
> 11) 0.106 us | cmd_free [hpsa]();
> 11) 2.014 us | }
>
> On its own, the } line doesn't indicate which function it is
> closing, so grep cannot be used to search for all the times
> for this function. You have to write a parser.
>
> The function name does get printed on those lines when the
> start of the function is off the trace, so I modified
> trace_functions_graph.c to do that in all cases.
>
> 11) | hpsa_scsi_ioaccel_raid_map [hpsa]() {
> 11) | hpsa_scsi_ioaccel_queue_command [hpsa]() {
> 11) | hpsa_scsi_ioaccel2_queue_command [hpsa]() {
> 11) 0.067 us | fixup_ioaccel_cdb [hpsa]();
> 11) 0.053 us | set_encrypt_ioaccel2 [hpsa]();
> 11) 0.199 us | enqueue_cmd_and_start_io [hpsa]();
> 11) 1.952 us | } /* hpsa_scsi_ioaccel2_queue_command [hpsa] */
> 11) 2.501 us | } /* hpsa_scsi_ioaccel_queue_command [hpsa] */
> 11) 3.093 us | } /* hpsa_scsi_ioaccel_raid_map [hpsa] */
> 11) 4.667 us | } /* hpsa_scsi_queue_command [hpsa] */
>
> rather than:
> 11) | hpsa_scsi_ioaccel_raid_map [hpsa]() {
> 11) | hpsa_scsi_ioaccel_queue_command [hpsa]() {
> 11) | hpsa_scsi_ioaccel2_queue_command [hpsa]() {
> 11) 0.067 us | fixup_ioaccel_cdb [hpsa]();
> 11) 0.053 us | set_encrypt_ioaccel2 [hpsa]();
> 11) 0.199 us | enqueue_cmd_and_start_io [hpsa]();
> 11) 1.952 us | }
> 11) 2.501 us | }
> 11) 3.093 us | }
> 11) 4.667 us | }
>
> Is this a change you would be interested in taking, or
> do you think that makes the output too cluttered?
Yes it is too cluttered. Please make this a tracing option that is
default off.
Thanks,
-- Steve
>
> A potential patch (based on kernel-3.14) is:
>
next prev parent reply other threads:[~2014-05-02 19:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 19:11 [RFC PATCH] ftrace function-graph: print the function name on all } lines Elliott, Robert (Server Storage)
2014-05-02 19:32 ` Steven Rostedt [this message]
2014-05-05 19:21 ` Elliott, Robert (Server Storage)
2014-05-05 19:38 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140502153249.1ee6aadd@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=Elliott@hp.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).