From: Steven Rostedt <rostedt@goodmis.org>
To: "Elliott, Robert (Server Storage)" <Elliott@hp.com>
Cc: "fweisbec@gmail.com" <fweisbec@gmail.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux-kernel (linux-kernel@vger.kernel.org)"
<linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] ftrace function-graph: print the function name on all } lines
Date: Mon, 5 May 2014 15:38:38 -0400 [thread overview]
Message-ID: <20140505153838.4cba1e09@gandalf.local.home> (raw)
In-Reply-To: <94D0CD8314A33A4D9D801C0FE68B402956EEB76B@G9W0745.americas.hpqcorp.net>
On Mon, 5 May 2014 19:21:03 +0000
"Elliott, Robert (Server Storage)" <Elliott@hp.com> wrote:
> > From: Steven Rostedt [mailto:rostedt@goodmis.org]
> > ...
> > Yes it is too cluttered. Please make this a tracing option that is
> > default off.
>
> The TRACE_GRAPH_PRINT_xx macros exist in two places:
> * trace.h has one set
> * trace_functions_graph.c has redefinitions of them and adds
> TRACE_GRAPH_PRINT_IRQS.
>
> The new macro will only be used inside trace_functions_graph.c.
> That is true of some of the others like TRACE_GRAPH_PRINT_OVERRUN,
> so doesn't seem to be the guiding principle for separate sets.
>
> Should the new one be added to both places, or should the
> duplicate definitions in trace_functions_graph.c be removed?
>
> trace_functions_graph.c:
> #include "trace.h"
> ...
> /* Flag options */
> #define TRACE_GRAPH_PRINT_OVERRUN 0x1
> #define TRACE_GRAPH_PRINT_CPU 0x2
> #define TRACE_GRAPH_PRINT_OVERHEAD 0x4
> #define TRACE_GRAPH_PRINT_PROC 0x8
> #define TRACE_GRAPH_PRINT_DURATION 0x10
> #define TRACE_GRAPH_PRINT_ABS_TIME 0x20
> #define TRACE_GRAPH_PRINT_IRQS 0x40
> #define TRACE_GRAPH_PRINT_TAIL 0x80 /* <-- new */
>
> trace.h:
> /* Flag options */
> #define TRACE_GRAPH_PRINT_OVERRUN 0x1
> #define TRACE_GRAPH_PRINT_CPU 0x2
> #define TRACE_GRAPH_PRINT_OVERHEAD 0x4
> #define TRACE_GRAPH_PRINT_PROC 0x8
> #define TRACE_GRAPH_PRINT_DURATION 0x10
> #define TRACE_GRAPH_PRINT_ABS_TIME 0x20
> #define TRACE_GRAPH_PRINT_FILL_SHIFT 28
> #define TRACE_GRAPH_PRINT_FILL_MASK (0x3 << TRACE_GRAPH_PRINT_FILL_SHIFT)
This is a bit sloppy. Looks like some of them were copied over to
trace.h to be used in other files, but never deleted from their
original location :-/
Probably should just move them all to trace.h. I want to change this
code in the near future anyway.
-- Steve
>
> ---
> Rob Elliott HP Server Storage
prev parent reply other threads:[~2014-05-05 19:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-02 19:11 [RFC PATCH] ftrace function-graph: print the function name on all } lines Elliott, Robert (Server Storage)
2014-05-02 19:32 ` Steven Rostedt
2014-05-05 19:21 ` Elliott, Robert (Server Storage)
2014-05-05 19:38 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140505153838.4cba1e09@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=Elliott@hp.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).