* [PATCH] driver/net/ethernet/ec_bhf.c: fix sparse warnings
@ 2014-05-14 6:04 Darek Marcinkiewicz
2014-05-14 20:09 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Darek Marcinkiewicz @ 2014-05-14 6:04 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-kernel
Sparse was reporting quite a few warnings for the driver.
Those get fixed by this patch.
Signed-off-by: Dariusz Marcinkiewicz <reksio@newterm.pl>
---
drivers/net/ethernet/ec_bhf.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/ec_bhf.c b/drivers/net/ethernet/ec_bhf.c
index 4884205..056b44b 100644
--- a/drivers/net/ethernet/ec_bhf.c
+++ b/drivers/net/ethernet/ec_bhf.c
@@ -134,17 +134,17 @@ struct ec_bhf_priv {
struct pci_dev *dev;
- void * __iomem io;
- void * __iomem dma_io;
+ void __iomem *io;
+ void __iomem *dma_io;
struct hrtimer hrtimer;
int tx_dma_chan;
int rx_dma_chan;
- void * __iomem ec_io;
- void * __iomem fifo_io;
- void * __iomem mii_io;
- void * __iomem mac_io;
+ void __iomem *ec_io;
+ void __iomem *fifo_io;
+ void __iomem *mii_io;
+ void __iomem *mac_io;
struct bhf_dma rx_buf;
struct rx_desc *rx_descs;
@@ -297,7 +297,7 @@ static int ec_bhf_setup_offsets(struct ec_bhf_priv *priv)
{
struct device *dev = PRIV_TO_DEV(priv);
unsigned block_count, i;
- void * __iomem ec_info;
+ void __iomem *ec_info;
dev_dbg(dev, "Info block:\n");
dev_dbg(dev, "Type of function: %x\n", (unsigned)ioread16(priv->io));
@@ -569,8 +569,8 @@ static int ec_bhf_probe(struct pci_dev *dev, const struct pci_device_id *id)
{
struct net_device *net_dev;
struct ec_bhf_priv *priv;
- void * __iomem dma_io;
- void * __iomem io;
+ void __iomem *dma_io;
+ void __iomem *io;
int err = 0;
err = pci_enable_device(dev);
@@ -615,7 +615,7 @@ static int ec_bhf_probe(struct pci_dev *dev, const struct pci_device_id *id)
}
net_dev = alloc_etherdev(sizeof(struct ec_bhf_priv));
- if (net_dev == 0) {
+ if (net_dev == NULL) {
err = -ENOMEM;
goto err_unmap_dma_io;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] driver/net/ethernet/ec_bhf.c: fix sparse warnings
2014-05-14 6:04 [PATCH] driver/net/ethernet/ec_bhf.c: fix sparse warnings Darek Marcinkiewicz
@ 2014-05-14 20:09 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2014-05-14 20:09 UTC (permalink / raw)
To: reksio; +Cc: netdev, linux-kernel
From: Darek Marcinkiewicz <reksio@newterm.pl>
Date: Wed, 14 May 2014 08:04:32 +0200
> Sparse was reporting quite a few warnings for the driver.
> Those get fixed by this patch.
>
> Signed-off-by: Dariusz Marcinkiewicz <reksio@newterm.pl>
Applied to net-next, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] driver/net/ethernet/ec_bhf.c: fix sparse warnings
2014-05-11 7:56 Darek Marcinkiewicz
@ 2014-05-13 21:44 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2014-05-13 21:44 UTC (permalink / raw)
To: reksio; +Cc: netdev, linux-kernel
From: Darek Marcinkiewicz <reksio@newterm.pl>
Date: Sun, 11 May 2014 09:56:08 +0200
>
> Sparse was reporting quite a few warnings for the driver.
> Those get fixed by this patch.
This is not a proper submission, you need to provide a proper
signoff with your patch.
Please make a new, fresh, patch posting, with the necessary
signoff in your commit message.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] driver/net/ethernet/ec_bhf.c: fix sparse warnings
@ 2014-05-11 7:56 Darek Marcinkiewicz
2014-05-13 21:44 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Darek Marcinkiewicz @ 2014-05-11 7:56 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-kernel
Sparse was reporting quite a few warnings for the driver.
Those get fixed by this patch.
---
drivers/net/ethernet/ec_bhf.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/ec_bhf.c b/drivers/net/ethernet/ec_bhf.c
index 4884205..056b44b 100644
--- a/drivers/net/ethernet/ec_bhf.c
+++ b/drivers/net/ethernet/ec_bhf.c
@@ -134,17 +134,17 @@ struct ec_bhf_priv {
struct pci_dev *dev;
- void * __iomem io;
- void * __iomem dma_io;
+ void __iomem *io;
+ void __iomem *dma_io;
struct hrtimer hrtimer;
int tx_dma_chan;
int rx_dma_chan;
- void * __iomem ec_io;
- void * __iomem fifo_io;
- void * __iomem mii_io;
- void * __iomem mac_io;
+ void __iomem *ec_io;
+ void __iomem *fifo_io;
+ void __iomem *mii_io;
+ void __iomem *mac_io;
struct bhf_dma rx_buf;
struct rx_desc *rx_descs;
@@ -297,7 +297,7 @@ static int ec_bhf_setup_offsets(struct ec_bhf_priv *priv)
{
struct device *dev = PRIV_TO_DEV(priv);
unsigned block_count, i;
- void * __iomem ec_info;
+ void __iomem *ec_info;
dev_dbg(dev, "Info block:\n");
dev_dbg(dev, "Type of function: %x\n", (unsigned)ioread16(priv->io));
@@ -569,8 +569,8 @@ static int ec_bhf_probe(struct pci_dev *dev, const struct pci_device_id *id)
{
struct net_device *net_dev;
struct ec_bhf_priv *priv;
- void * __iomem dma_io;
- void * __iomem io;
+ void __iomem *dma_io;
+ void __iomem *io;
int err = 0;
err = pci_enable_device(dev);
@@ -615,7 +615,7 @@ static int ec_bhf_probe(struct pci_dev *dev, const struct pci_device_id *id)
}
net_dev = alloc_etherdev(sizeof(struct ec_bhf_priv));
- if (net_dev == 0) {
+ if (net_dev == NULL) {
err = -ENOMEM;
goto err_unmap_dma_io;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-14 20:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-14 6:04 [PATCH] driver/net/ethernet/ec_bhf.c: fix sparse warnings Darek Marcinkiewicz
2014-05-14 20:09 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2014-05-11 7:56 Darek Marcinkiewicz
2014-05-13 21:44 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).