Re: [PATCH V2 1/2] fs: include device name in error messages about freezing

[Jan Kara <jack@suse.cz>]

On Wed 14-05-14 00:04:42, Mateusz Guzik wrote:
> While here use pr_err instead of printk(KERN_ERR...)
  The patch looks good. Just one nit below:

> Signed-off-by: Mateusz Guzik <mguzik@redhat.com>
> Cc: linux-fsdevel@vger.kernel.org
> Cc: Josef Bacik <jbacik@fb.com>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Al Viro <viro@ZenIV.linux.org.uk>
> Cc: Eric Sandeen <esandeen@redhat.com>
> ---
>  fs/super.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/super.c b/fs/super.c
> index 48377f7..017e10a 100644
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -1323,8 +1323,7 @@ int freeze_super(struct super_block *sb)
>  	if (sb->s_op->freeze_fs) {
>  		ret = sb->s_op->freeze_fs(sb);
>  		if (ret) {
> -			printk(KERN_ERR
> -				"VFS:Filesystem freeze failed\n");
> +			pr_err("VFS:Filesystem %s freeze failed\n", sb->s_id);
  I'd somewhat prefer to have the format like:
VFS (device %s): Filesystem freeze failed\n

  That should easy to programatically parse if necessary and also more
consistent with how filesystems report errors. Now VFS itself doesn't have
any unified style but still...

								Honza

>  			sb->s_writers.frozen = SB_UNFROZEN;
>  			smp_wmb();
>  			wake_up(&sb->s_writers.wait_unfrozen);
> @@ -1364,8 +1363,7 @@ int thaw_super(struct super_block *sb)
>  	if (sb->s_op->unfreeze_fs) {
>  		error = sb->s_op->unfreeze_fs(sb);
>  		if (error) {
> -			printk(KERN_ERR
> -				"VFS:Filesystem thaw failed\n");
> +			pr_err("VFS:Filesystem %s thaw failed\n", sb->s_id);
>  			up_write(&sb->s_umount);
>  			return error;
>  		}
> -- 
> 1.8.3.1
> 
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR