From: Wolfram Sang <wsa@the-dreams.de>
To: "Karicheri, Muralidharan" <m-karicheri2@ti.com>
Cc: "davinci-linux-open-source@linux.davincidsp.com"
<davinci-linux-open-source@linux.davincidsp.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Ding, Garrett" <g-ding@ti.com>, "Nori, Sekhar" <nsekhar@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
"Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Subject: Re: [PATCH] i2c: davinci: Add block read functionality for IPMI
Date: Thu, 22 May 2014 11:00:41 +0200 [thread overview]
Message-ID: <20140522090041.GA2573@katana> (raw)
In-Reply-To: <3E54258959B69E4282D79E01AB1F32B70472F6AC@DFLE11.ent.ti.com>
[-- Attachment #1: Type: text/plain, Size: 2474 bytes --]
Hi,
thanks for the patch.
> >+/* capabilities */
> >+#define I2C_CAPABILITIES (I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL | \
> >+ I2C_FUNC_SMBUS_READ_BLOCK_DATA)
I don't see the need for a seperate define.
> >+
> > struct davinci_i2c_dev {
> > struct device *dev;
> > void __iomem *base;
> >@@ -318,7 +322,13 @@ i2c_davinci_xfer_msg(struct i2c_adapter *adap, struct i2c_msg
> >*msg, int stop)
> > davinci_i2c_write_reg(dev, DAVINCI_I2C_SAR_REG, msg->addr);
> >
> > dev->buf = msg->buf;
> >- dev->buf_len = msg->len;
> >+
> >+ /* if first received byte is length, set buf_len = 0xffff as flag */
> >+ if (msg->flags & I2C_M_RECV_LEN)
> >+ dev->buf_len = 0xffff;
a) this magic value should be a define instead of a comment
b) i2c messages easily have a 16 bit range, so 0xffff is a troublesome
choice.
> >+ else
> >+ dev->buf_len = msg->len;
> >+
> > dev->stop = stop;
> >
> > davinci_i2c_write_reg(dev, DAVINCI_I2C_CNT_REG, dev->buf_len); @@ -456,7
> >+466,7 @@ i2c_davinci_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
> >
> > static u32 i2c_davinci_func(struct i2c_adapter *adap) {
> >- return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
> >+ return I2C_CAPABILITIES;
> > }
> >
> > static void terminate_read(struct davinci_i2c_dev *dev) @@ -528,10 +538,32 @@ static
> >irqreturn_t i2c_davinci_isr(int this_irq, void *dev_id)
> >
> > case DAVINCI_I2C_IVR_RDR:
> > if (dev->buf_len) {
> >- *dev->buf++ =
> >- davinci_i2c_read_reg(dev,
> >- DAVINCI_I2C_DRR_REG);
> >+ *dev->buf++ = davinci_i2c_read_reg(dev,
> >+ DAVINCI_I2C_DRR_REG);
> >+ /*
> >+ * check if the first received byte is message
> >+ * length, i.e, I2C_M_RECV_LEN
> >+ */
> >+ if (dev->buf_len == 0xffff)
> >+ dev->buf_len = *(dev->buf - 1) + 1;
Please rework the code to get rid of the '- 1' and '+ 1'. They look
hackish and make the code less readable.
> >+
> > dev->buf_len--;
> >+ /*
> >+ * send NACK/STOP bits BEFORE last byte is
> >+ * received
> >+ */
> >+ if (dev->buf_len == 1) {
> >+ w = davinci_i2c_read_reg(dev,
> >+ DAVINCI_I2C_MDR_REG);
> >+ w |= DAVINCI_I2C_MDR_NACK;
> >+ davinci_i2c_write_reg(dev,
> >+ DAVINCI_I2C_MDR_REG, w);
> >+
> >+ w |= DAVINCI_I2C_MDR_STP;
> >+ davinci_i2c_write_reg(dev,
> >+ DAVINCI_I2C_MDR_REG, w);
> >+ }
> >+
Looks like an unreleated change to me? Why is this I2C_M_RECV_LEN
specific?
Kind regards,
Wolfram
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-05-22 9:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 18:49 [PATCH] i2c: davinci: Add block read functionality for IPMI Murali Karicheri
2014-05-05 20:30 ` Karicheri, Muralidharan
2014-05-22 9:00 ` Wolfram Sang [this message]
2014-06-02 16:28 ` Murali Karicheri
2014-05-22 10:51 ` Sekhar Nori
2014-06-02 16:29 ` Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140522090041.GA2573@katana \
--to=wsa@the-dreams.de \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=g-ding@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=nsekhar@ti.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).