From: Murali Karicheri <m-karicheri2@ti.com>
To: Sekhar Nori <nsekhar@ti.com>
Cc: <davinci-linux-open-source@linux.davincidsp.com>,
<linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Garrett Ding <g-ding@ti.com>,
Kevin Hilman <khilman@deeprootsystems.com>,
Wolfram Sang <wsa@the-dreams.de>,
Santosh Shilimkar <santosh.shilimkar@ti.com>
Subject: Re: [PATCH] i2c: davinci: Add block read functionality for IPMI
Date: Mon, 2 Jun 2014 12:29:55 -0400 [thread overview]
Message-ID: <538CA683.40108@ti.com> (raw)
In-Reply-To: <537DD6B1.9010200@ti.com>
On 5/22/2014 6:51 AM, Sekhar Nori wrote:
> On Friday 02 May 2014 12:19 AM, Murali Karicheri wrote:
>> Intelligent Plaform Management Interface (IPMI) requires I2C driver
>> to support block read, where the first byte received from slave is
>> the length of following data:-
>> Added length check if the read type is block read (I2C_M_RECV_LEN)
>> Send NACK/STOP bits before last byte is received
>>
>> Signed-off-by: Garrett Ding <g-ding@ti.com>
>> Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
> I tested this on a DA850 using i2cdetect and it did not seem to break
> anything so:
>
> Tested-by: Sekhar Nori <nsekhar@ti.com>
>
> There are some checks that were triggered in checkpatch. You may want
> to fix them up.
>
> Thanks,
> Sekhar
>
> CHECK: Alignment should match open parenthesis
> #112: FILE: drivers/i2c/busses/i2c-davinci.c:557:
> + w = davinci_i2c_read_reg(dev,
> + DAVINCI_I2C_MDR_REG);
>
> CHECK: Alignment should match open parenthesis
> #115: FILE: drivers/i2c/busses/i2c-davinci.c:560:
> + davinci_i2c_write_reg(dev,
> + DAVINCI_I2C_MDR_REG, w);
>
> CHECK: Alignment should match open parenthesis
> #119: FILE: drivers/i2c/busses/i2c-davinci.c:564:
> + davinci_i2c_write_reg(dev,
> + DAVINCI_I2C_MDR_REG, w);
>
> total: 0 errors, 0 warnings, 3 checks, 67 lines checked
>
Sekhar,
Thanks for testing this. I have other comments against this patch and
will be sending an
updated patch in few weeks.
Thanks and regards,
Murali
prev parent reply other threads:[~2014-06-02 16:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-01 18:49 [PATCH] i2c: davinci: Add block read functionality for IPMI Murali Karicheri
2014-05-05 20:30 ` Karicheri, Muralidharan
2014-05-22 9:00 ` Wolfram Sang
2014-06-02 16:28 ` Murali Karicheri
2014-05-22 10:51 ` Sekhar Nori
2014-06-02 16:29 ` Murali Karicheri [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538CA683.40108@ti.com \
--to=m-karicheri2@ti.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=g-ding@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).