* [PATCH] remove duplicated comment and fix brace placement in drivers/staging/comedi/drivers/addi-data/hwdrv_acpi3501.c
@ 2014-05-27 14:17 Marcin Kostrzewa
2014-05-27 21:24 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Marcin Kostrzewa @ 2014-05-27 14:17 UTC (permalink / raw)
To: Ian Abbott, H Hartley Sweeten, Greg Kroah-Hartman, Fred Akers,
devel, linux-kernel
Cc: Marcin Kostrzewa
Signed-off-by: Marcin Kostrzewa <marckostrzewa@gmail.com>
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
index 20e89b0..8add8d8 100644
--- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
+++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
@@ -104,9 +104,7 @@ static int apci3501_write_insn_timer(struct comedi_device *dev,
outl(ul_Command1, dev->iobase + APCI3501_TIMER_CTRL_REG);
}
- else if (data[1] == 0) /* Stop The Watchdog */
- {
- /* Stop The Watchdog */
+ else if (data[1] == 0) { /* Stop The Watchdog */
ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
ul_Command1 = ul_Command1 & 0xFFFFF9FEUL;
outl(0x0, dev->iobase + APCI3501_TIMER_CTRL_REG);
--
1.9.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] remove duplicated comment and fix brace placement in drivers/staging/comedi/drivers/addi-data/hwdrv_acpi3501.c
2014-05-27 14:17 [PATCH] remove duplicated comment and fix brace placement in drivers/staging/comedi/drivers/addi-data/hwdrv_acpi3501.c Marcin Kostrzewa
@ 2014-05-27 21:24 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-05-27 21:24 UTC (permalink / raw)
To: Marcin Kostrzewa
Cc: Ian Abbott, H Hartley Sweeten, Greg Kroah-Hartman, Fred Akers,
devel, linux-kernel
The subject should be:
[PATCH] Staging: comedi: addi-data: <short title. clean up else statement>
On Tue, May 27, 2014 at 02:17:35PM +0000, Marcin Kostrzewa wrote:
> Signed-off-by: Marcin Kostrzewa <marckostrzewa@gmail.com>
> ---
> drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> index 20e89b0..8add8d8 100644
> --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c
> @@ -104,9 +104,7 @@ static int apci3501_write_insn_timer(struct comedi_device *dev,
> outl(ul_Command1, dev->iobase + APCI3501_TIMER_CTRL_REG);
> }
>
> - else if (data[1] == 0) /* Stop The Watchdog */
> - {
> - /* Stop The Watchdog */
> + else if (data[1] == 0) { /* Stop The Watchdog */
While you're at it, could you also move it like this:
} else if (data[1] == 0) { /* Stop The Watchdog */
(I wouldn't have asked you to do this, except that you need to resend
anyway with a fixed subject line).
regards,
dan carpenter
> ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
> ul_Command1 = ul_Command1 & 0xFFFFF9FEUL;
> outl(0x0, dev->iobase + APCI3501_TIMER_CTRL_REG);
> --
> 1.9.2
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-27 21:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-27 14:17 [PATCH] remove duplicated comment and fix brace placement in drivers/staging/comedi/drivers/addi-data/hwdrv_acpi3501.c Marcin Kostrzewa
2014-05-27 21:24 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).